Re: Review Request 120287: [OS X] make kde-workspace build

> On Sept. 22, 2014, 6:52 p.m., Martin Gräßlin wrote: > > CMakeLists.txt, line 249 > > > > > > just as a note: kinfocenter shold(tm) work on macos. at least there is > > a source file called info_osx.cpp > > Re

Re: Review Request 120287: [OS X] make kde-workspace build

> On Sept. 22, 2014, 6:52 nachm., Martin Gräßlin wrote: > > CMakeLists.txt, line 249 > > > > > > just as a note: kinfocenter shold(tm) work on macos. at least there is > > a source file called info_osx.cpp > >

Re: Review Request 120287: [OS X] make kde-workspace build

> On Sept. 22, 2014, 6:52 p.m., Martin Gräßlin wrote: > > I assume you did not want to include those debug messages in > > qguiplatformplugin_kde.cpp? Oooops, no ... > On Sept. 22, 2014, 6:52 p.m., Martin Gräßlin wrote: > > CMakeLists.txt, line 249 > >

Re: Review Request 120287: [OS X] make kde-workspace build

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120287/#review67219 --- I assume you did not want to include those debug messages in

Re: Review Request 120287: [OS X] make kde-workspace build

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120287/ --- (Updated Sept. 22, 2014, 6:17 p.m.) Review request for KDE Software on Ma

Review Request 120319: Make Kate mousewheel zoom feature respect the corresponding global setting (KGlobalSettings::wheelMouseZooms())

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120319/ --- Review request for Kate, KDE Software on Mac OS X and kdelibs. Repository

Re: Review Request 120287: [OS X] make kde-workspace build

> On Sept. 20, 2014, 3:51 p.m., Martin Gräßlin wrote: > > CMakeLists.txt, lines 223-239 > > > > > > out of interest: this is now a huge NOT WIN32 block with two NOT APPLE > > blocks. If I see correctly, what rem

Re: Review Request 120287: [OS X] make kde-workspace build

> On Sept. 20, 2014, 3:51 p.m., Martin Gräßlin wrote: > > CMakeLists.txt, lines 223-239 > > > > > > out of interest: this is now a huge NOT WIN32 block with two NOT APPLE > > blocks. If I see correctly, what rem

Re: Review Request 120287: [OS X] make kde-workspace build

> On Sept. 20, 2014, 3:51 p.m., Martin Gräßlin wrote: > > CMakeLists.txt, lines 223-239 > > > > > > out of interest: this is now a huge NOT WIN32 block with two NOT APPLE > > blocks. If I see correctly, what rem

Re: Review Request 120287: [OS X] make kde-workspace build

> On Sept. 20, 2014, 1:51 nachm., Martin Gräßlin wrote: > > CMakeLists.txt, lines 223-239 > > > > > > out of interest: this is now a huge NOT WIN32 block with two NOT APPLE > > blocks. If I see correctly, what r

Re: Using Gerrit for code review in KDE

The language for Code-Review +2 now reads "Looks good to me and I know this code, approved". I hope people won't be afraid to approve changes now :). Cheers, Jan -- Trojitá, a fast Qt IMAP e-mail client -- http://trojita.flaska.net/

Re: Review Request 120287: [OS X] make kde-workspace build

> On Sept. 20, 2014, 3:51 p.m., Martin Gräßlin wrote: > > CMakeLists.txt, lines 223-239 > > > > > > out of interest: this is now a huge NOT WIN32 block with two NOT APPLE > > blocks. If I see correctly, what rem

Re: Review Request 120287: [OS X] make kde-workspace build

> On Sept. 20, 2014, 3:51 p.m., Martin Gräßlin wrote: > > CMakeLists.txt, lines 223-239 > > > > > > out of interest: this is now a huge NOT WIN32 block with two NOT APPLE > > blocks. If I see correctly, what rem

Re: Review Request 120287: [OS X] make kde-workspace build

> On Sept. 21, 2014, 1:53 p.m., Gilles Caulier wrote: > > Martin, > > > > Since this file is openn, you can considerate this entry as obsolete : > > > > https://git.reviewboard.kde.org/r/112991/ Gilles, you seemed to have issues with the standard 'macintosh' Qt theme for digikam's GUI. What's