Re: Review Request 120287: [OS X] make kde-workspace build

> On Sept. 20, 2014, 3:51 p.m., Martin Gräßlin wrote: > > CMakeLists.txt, lines 223-239 > > > > > > out of interest: this is now a huge NOT WIN32 block with two NOT APPLE > > blocks. If I see correctly, what rem

"Quality is in the eye of the beholder" BoF summary

Hi all, this is the summary for the BoF that as follow up of https://conf.kde.org/en/Akademy2014/public/events/96 * We are Big and small at the same time, not sure how to fix it :D * We need more tests and CI in different archs and OS * We need more tools - What are the most important crashes

Re: Review Request 120202: [OS X] improvements to the kwallet/OSX keychain integration

> On Sept. 21, 2014, 8:11 p.m., Thomas Lübking wrote: > > kdeui/util/qosxkeychain.h, line 99 > > > > > > If OSXKaychain is an exported class (i don't know), this is an ABI > > incompatible change. > > > >

Re: Review Request 120120: kmenuedit: do not resize app icons (fixes #338883)

> On Sept. 9, 2014, 8:02 nachm., Thomas Lübking wrote: > > treeview.cpp, line 232 > > > > > > Maybe rather try to limit to the font height instead? > > Christoph Feck wrote: > Why? We use "Small" icon size n

Re: Review Request 120120: kmenuedit: do not resize app icons (fixes #338883)

> On Sept. 9, 2014, 8:02 p.m., Thomas Lübking wrote: > > treeview.cpp, line 232 > > > > > > Maybe rather try to limit to the font height instead? > > Christoph Feck wrote: > Why? We use "Small" icon size nex

Re: Review Request 120202: [OS X] improvements to the kwallet/OSX keychain integration

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120202/#review67155 --- kdeui/util/qosxkeychain.h

Re: KConfigGroup parent() and isValid()

On Friday, September 19, 2014 17.28:04 Thomas Lübking wrote: > On Freitag, 19. September 2014 13:06:41 CEST, Aaron J. Seigo wrote: > > KConfigGroup group = ; > > while (group.isValid()) { > > > > group = group.parent(); > > > > } > > I'm checking for existance rather than validity in kconfig

Re: Review Request 120202: [OS X] improvements to the kwallet/OSX keychain integration

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120202/ --- (Updated Sept. 21, 2014, 6:40 p.m.) Review request for KDE Software on Ma

Re: Review Request 120202: [OS X] improvements to the kwallet/OSX keychain integration

> On Sept. 19, 2014, 12:28 a.m., Albert Astals Cid wrote: > > kdeui/util/kwallet.h, line 545 > > > > > > This is bad, slots in an ifdef are a bad idea. > > > > Is there any reason this slot has to be in

Re: Review Request 120202: [OS X] improvements to the kwallet/OSX keychain integration

> OK, implementation question. > > How do I declare a slot in a private class that doesn't have a specific > header file? Putting `private QSLOT` above the function definition makes > things compile, but the runtime complains about a missing slot (curiously > even expecting it in KWallet::Wallet).

Re: Review Request 120202: [OS X] improvements to the kwallet/OSX keychain integration

> On set. 18, 2014, 10:28 p.m., Albert Astals Cid wrote: > > kdeui/util/kwallet.h, line 545 > > > > > > This is bad, slots in an ifdef are a bad idea. > > > > Is there any reason this slot has to be in K

Re: Review Request 120202: [OS X] improvements to the kwallet/OSX keychain integration

> On Sept. 19, 2014, 12:28 a.m., Albert Astals Cid wrote: > > kdeui/util/kwallet.h, line 545 > > > > > > This is bad, slots in an ifdef are a bad idea. > > > > Is there any reason this slot has to be in

Re: Review Request 112991: Fix compilation rules of KDE-Workspace under OSX/Macports

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112991/#review67133 --- Thanks, Gilles, for letting us know, that this is covered anew

Re: Review Request 120287: [OS X] make kde-workspace build

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120287/#review67125 --- Martin, Since this file is openn, you can considerate this en

Re: Review Request 120202: [OS X] improvements to the kwallet/OSX keychain integration

> On Sept. 18, 2014, 10:28 nachm., Albert Astals Cid wrote: > > kdeui/util/kwallet.h, line 545 > > > > > > This is bad, slots in an ifdef are a bad idea. > > > > Is there any reason this slot has to be i

Re: Review Request 120202: [OS X] improvements to the kwallet/OSX keychain integration

> On set. 18, 2014, 10:28 p.m., Albert Astals Cid wrote: > > kdeui/util/kwallet.h, line 545 > > > > > > This is bad, slots in an ifdef are a bad idea. > > > > Is there any reason this slot has to be in K

Re: Review Request 120287: [OS X] make kde-workspace build

> On Sept. 20, 2014, 1:51 nachm., Martin Gräßlin wrote: > > CMakeLists.txt, lines 223-239 > > > > > > out of interest: this is now a huge NOT WIN32 block with two NOT APPLE > > blocks. If I see correctly, what r

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash)

> On Juli 29, 2014, 3:33 nachm., Aleix Pol Gonzalez wrote: > > kinit/kinit.cpp, line 1481 > > > > > > do you need $DISPLAY in OS X? > > René J.V. Bertin wrote: > Nope. It can be set if the user has XQuartz

Re: Review Request 120202: [OS X] improvements to the kwallet/OSX keychain integration

> On Sept. 19, 2014, 12:28 a.m., Albert Astals Cid wrote: > > kdeui/util/kwallet.h, line 545 > > > > > > This is bad, slots in an ifdef are a bad idea. > > > > Is there any reason this slot has to be in

Re: Review Request 120202: [OS X] improvements to the kwallet/OSX keychain integration

> On Sept. 18, 2014, 10:28 nachm., Albert Astals Cid wrote: > > kdeui/util/kwallet.h, line 545 > > > > > > This is bad, slots in an ifdef are a bad idea. > > > > Is there any reason this slot has to be i

Re: Review Request 120202: [OS X] improvements to the kwallet/OSX keychain integration

> On set. 18, 2014, 10:28 p.m., Albert Astals Cid wrote: > > kdeui/util/kwallet.h, line 545 > > > > > > This is bad, slots in an ifdef are a bad idea. > > > > Is there any reason this slot has to be in K

Re: Review Request 120202: [OS X] improvements to the kwallet/OSX keychain integration

> On Sept. 19, 2014, 12:28 a.m., Albert Astals Cid wrote: > > kdeui/util/kwallet.h, line 545 > > > > > > This is bad, slots in an ifdef are a bad idea. > > > > Is there any reason this slot has to be in

Re: Review Request 120287: [OS X] make kde-workspace build

> On Sept. 20, 2014, 3:51 p.m., Martin Gräßlin wrote: > > CMakeLists.txt, lines 223-239 > > > > > > out of interest: this is now a huge NOT WIN32 block with two NOT APPLE > > blocks. If I see correctly, what rem

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash)

> On July 29, 2014, 5:33 p.m., Aleix Pol Gonzalez wrote: > > kinit/kinit.cpp, line 1481 > > > > > > do you need $DISPLAY in OS X? > > René J.V. Bertin wrote: > Nope. It can be set if the user has XQuartz in

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

> On Sept. 19, 2014, 10:16 a.m., Ben Cooksley wrote: > > Unless anyone has any objections in the next 24 hours, I think this can go > > in as it makes Dr Konqi usable on another platform. > > Thomas Lübking wrote: > +1 - "Shit It" ... from my side. > > Certainly no technical concer

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

> On Sept. 19, 2014, 12:16 p.m., Ben Cooksley wrote: > > Unless anyone has any objections in the next 24 hours, I think this can go > > in as it makes Dr Konqi usable on another platform. > > Thomas Lübking wrote: > +1 - "Shit It" ... from my side. > > Certainly no technical concer

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

> On Sept. 19, 2014, 10:16 vorm., Ben Cooksley wrote: > > Unless anyone has any objections in the next 24 hours, I think this can go > > in as it makes Dr Konqi usable on another platform. > > Thomas Lübking wrote: > +1 - "Shit It" ... from my side. > > Certainly no technical conce