Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119498/#review67098 --- Ship it! Ship It! - Ian Wadham On Sept. 18, 2014, 10:57 a.

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

> On Sept. 19, 2014, 10:16 vorm., Ben Cooksley wrote: > > Unless anyone has any objections in the next 24 hours, I think this can go > > in as it makes Dr Konqi usable on another platform. +1 - "Shit It" ... from my side. Certainly no technical concerns remaining here - but i'm not the code o

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash)

> On July 29, 2014, 3:33 p.m., Aleix Pol Gonzalez wrote: > > kinit/kinit.cpp, line 1481 > > > > > > do you need $DISPLAY in OS X? > > René J.V. Bertin wrote: > Nope. It can be set if the user has XQuartz in

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash)

> On Juli 29, 2014, 3:33 nachm., Aleix Pol Gonzalez wrote: > > kinit/kinit.cpp, line 1481 > > > > > > do you need $DISPLAY in OS X? > > René J.V. Bertin wrote: > Nope. It can be set if the user has XQuartz

Re: Review Request 119372: Fix Bug 337486 - Should not permit moving of read-only folder to a different directory

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119372/#review67082 --- Ship it! Ship It! - David Faure On Sept. 19, 2014, 11:56 a

Re: Review Request 120287: [OS X] make kde-workspace build

9.4 with KDE/MacPorts (4.12.5 and more recently kdelibs > git/master, 4.14.1). > > > File Attachments > > > copy of the diff file saved locally, which had no tabs when I uploaded it. > Checksum: 3989cdd46af3c891e570974d66c330403dcd41c4ee5e17a372fa385080cbabd1 > > https://git.reviewboard.kde.org/media/uploaded/files/2014/09/20/b212730f-6258-4277-851c-226bc0673aa1__patchreview-20140920.patch > > > Thanks, > > René J.V. Bertin > >

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash)

> On July 29, 2014, 3:33 p.m., Aleix Pol Gonzalez wrote: > > kinit/kinit.cpp, line 1481 > > > > > > do you need $DISPLAY in OS X? > > René J.V. Bertin wrote: > Nope. It can be set if the user has XQuartz in

Re: Review Request 120287: [OS X] make kde-workspace build

576fe > > Diff: https://git.reviewboard.kde.org/r/120287/diff/ > > > Testing > --- > > On OS X 10.6.8 and 10.9.4 with KDE/MacPorts (4.12.5 and more recently kdelibs > git/master, 4.14.1). > > > File Attachments > > > copy of the diff file saved locally, which had no tabs when I uploaded it. > Checksum: 3989cdd46af3c891e570974d66c330403dcd41c4ee5e17a372fa385080cbabd1 > > https://git.reviewboard.kde.org/media/uploaded/files/2014/09/20/b212730f-6258-4277-851c-226bc0673aa1__patchreview-20140920.patch > > > Thanks, > > René J.V. Bertin > >

Re: Review Request 120287: [OS X] make kde-workspace build

-6258-4277-851c-226bc0673aa1__patchreview-20140920.patch Thanks, René J.V. Bertin

Re: Review Request 120287: [OS X] make kde-workspace build

gt; File Attachments > ---- > > copy of the diff file saved locally, which had no tabs when I uploaded it. > Checksum: 3989cdd46af3c891e570974d66c330403dcd41c4ee5e17a372fa385080cbabd1 > > https://git.reviewboard.kde.org/media/uploaded/files/2014/09/20/b212730f-6258-4277-851c-226bc0673aa1__patchreview-20140920.patch > > > Thanks, > > René J.V. Bertin > >

Re: Review Request 120287: [OS X] make kde-workspace build

ating glitches due > to compositing. > > I'm submitting this patch partly in hope it may be useful in bringing > kf5-workspace to OS X, one day. > > > Diffs > - > > CMakeLists.txt 195f99c > kcontrol/CMakeLists.txt fc666b1 > kcontrol/krdb/krdb.cpp 36fc99c > kcontrol/style/CMakeLists.txt d832b20 > libs/CMakeLists.txt c0576fe > > Diff: https://git.reviewboard.kde.org/r/120287/diff/ > > > Testing > --- > > On OS X 10.6.8 and 10.9.4 with KDE/MacPorts (4.12.5 and more recently kdelibs > git/master, 4.14.1). > > > File Attachments > > > copy of the diff file saved locally, which had no tabs when I uploaded it. > Checksum: 3989cdd46af3c891e570974d66c330403dcd41c4ee5e17a372fa385080cbabd1 > > https://git.reviewboard.kde.org/media/uploaded/files/2014/09/20/b212730f-6258-4277-851c-226bc0673aa1__patchreview-20140920.patch > > > Thanks, > > René J.V. Bertin > >

Re: Review Request 120287: [OS X] make kde-workspace build

iff/ > > > Testing > --- > > On OS X 10.6.8 and 10.9.4 with KDE/MacPorts (4.12.5 and more recently kdelibs > git/master, 4.14.1). > > > File Attachments > > > copy of the diff file saved locally, which had no tabs when I uploa

Re: Review Request 120287: [OS X] make kde-workspace build

ven style. > The oxygen style builds and looks good but shows some updating glitches due > to compositing. > > I'm submitting this patch partly in hope it may be useful in bringing > kf5-workspace to OS X, one day. > > > Diffs > - > > CMakeLists.txt 195f99c >

Re: Review Request 120287: [OS X] make kde-workspace build

.5 and more recently kdelibs > git/master, 4.14.1). > > > File Attachments > > > copy of the diff file saved locally, which had no tabs when I uploaded it. > Checksum: 3989cdd46af3c891e570974d66c330403dcd41c4ee5e17a372fa385080cbabd1 > > https://git.reviewboard.kde.org/media/uploaded/files/2014/09/20/b212730f-6258-4277-851c-226bc0673aa1__patchreview-20140920.patch > > > Thanks, > > René J.V. Bertin > >

Re: Review Request 120287: [OS X] make kde-workspace build

> kcontrol/CMakeLists.txt fc666b1 > kcontrol/krdb/krdb.cpp 36fc99c > kcontrol/style/CMakeLists.txt d832b20 > libs/CMakeLists.txt c0576fe > > Diff: https://git.reviewboard.kde.org/r/120287/diff/ > > > Testing > --- > > On OS X 10.6.8 and 10.9.4 with KDE/MacPorts (4.12.5 and more recently kdelibs > git/master, 4.14.1). > > > File Attachments > > > copy of the diff file saved locally, which had no tabs when I uploaded it. > Checksum: 3989cdd46af3c891e570974d66c330403dcd41c4ee5e17a372fa385080cbabd1 > > https://git.reviewboard.kde.org/media/uploaded/files/2014/09/20/b212730f-6258-4277-851c-226bc0673aa1__patchreview-20140920.patch > > > Thanks, > > René J.V. Bertin > >

Re: Review Request 120287: [OS X] make kde-workspace build

> - > > CMakeLists.txt 195f99c > kcontrol/CMakeLists.txt fc666b1 > kcontrol/krdb/krdb.cpp 36fc99c > kcontrol/style/CMakeLists.txt d832b20 > libs/CMakeLists.txt c0576fe > > Diff: https://git.reviewboard.kde.org/r/120287/diff/ > > > Testing > --- > > On OS X 10.6.8 and 10.9.4 with KDE/MacPorts (4.12.5 and more recently kdelibs > git/master, 4.14.1). > > > File Attachments > > > copy of the diff file saved locally, which had no tabs when I uploaded it. > Checksum: 3989cdd46af3c891e570974d66c330403dcd41c4ee5e17a372fa385080cbabd1 > > https://git.reviewboard.kde.org/media/uploaded/files/2014/09/20/b212730f-6258-4277-851c-226bc0673aa1__patchreview-20140920.patch > > > Thanks, > > René J.V. Bertin > >

Re: Review Request 120287: [OS X] make kde-workspace build

--- > > CMakeLists.txt 195f99c > kcontrol/CMakeLists.txt fc666b1 > kcontrol/krdb/krdb.cpp 36fc99c > kcontrol/style/CMakeLists.txt d832b20 > libs/CMakeLists.txt c0576fe > > Diff: https://git.reviewboard.kde.org/r/120287/diff/ > > > Testing > --

Re: Review Request 120287: [OS X] make kde-workspace build

> libs/CMakeLists.txt c0576fe > > Diff: https://git.reviewboard.kde.org/r/120287/diff/ > > > Testing > --- > > On OS X 10.6.8 and 10.9.4 with KDE/MacPorts (4.12.5 and more recently kdelibs > git/master, 4.14.1). > > > File Attachments > > > copy of the diff file saved locally, which had no tabs when I uploaded it. > Checksum: 3989cdd46af3c891e570974d66c330403dcd41c4ee5e17a372fa385080cbabd1 > > https://git.reviewboard.kde.org/media/uploaded/files/2014/09/20/b212730f-6258-4277-851c-226bc0673aa1__patchreview-20140920.patch > > > Thanks, > > René J.V. Bertin > >

Re: Review Request 120287: [OS X] make kde-workspace build

0.6.8 and 10.9.4 with KDE/MacPorts (4.12.5 and more recently kdelibs > git/master, 4.14.1). > > > File Attachments > > > copy of the diff file saved locally, which had no tabs when I uploaded it. > Checksum: 3989cdd46af3c891e570974d66c330403dcd41c4ee5e17a372fa385080cbabd1 > > https://git.reviewboard.kde.org/media/uploaded/files/2014/09/20/b212730f-6258-4277-851c-226bc0673aa1__patchreview-20140920.patch > > > Thanks, > > René J.V. Bertin > >

Re: Review Request 120287: [OS X] make kde-workspace build

kdelibs > git/master, 4.14.1). > > > File Attachments > > > copy of the diff file saved locally, which had no tabs when I uploaded it. > Checksum: 3989cdd46af3c891e570974d66c330403dcd41c4ee5e17a372fa385080cbabd1 > > https://git.reviewboard.kde.org/media/uploaded/files/2014/09/20/b212730f-6258-4277-851c-226bc0673aa1__patchreview-20140920.patch > > > Thanks, > > René J.V. Bertin > >

Re: Review Request 120287: [OS X] make kde-workspace build

kcontrol/CMakeLists.txt fc666b1 > kcontrol/krdb/krdb.cpp 36fc99c > kcontrol/style/CMakeLists.txt d832b20 > libs/CMakeLists.txt c0576fe > > Diff: https://git.reviewboard.kde.org/r/120287/diff/ > > > Testing > --- > > On OS X 10.6.8 and 10.9.4 with KDE/MacPorts (4.12.5 and more recently kdelibs > git/master, 4.14.1). > > > File Attachments > > > copy of the diff file saved locally, which had no tabs when I uploaded it. > Checksum: 3989cdd46af3c891e570974d66c330403dcd41c4ee5e17a372fa385080cbabd1 > > https://git.reviewboard.kde.org/media/uploaded/files/2014/09/20/b212730f-6258-4277-851c-226bc0673aa1__patchreview-20140920.patch > > > Thanks, > > René J.V. Bertin > >

Re: Review Request 120287: [OS X] make kde-workspace build

MakeLists.txt d832b20 > libs/CMakeLists.txt c0576fe > > Diff: https://git.reviewboard.kde.org/r/120287/diff/ > > > Testing > --- > > On OS X 10.6.8 and 10.9.4 with KDE/MacPorts (4.12.5 and more recently kdelibs > git/master, 4.14.1). > > > File Attachments >

Re: Review Request 120287: [OS X] make kde-workspace build

s/CMakeLists.txt c0576fe > > Diff: https://git.reviewboard.kde.org/r/120287/diff/ > > > Testing > --- > > On OS X 10.6.8 and 10.9.4 with KDE/MacPorts (4.12.5 and more recently kdelibs > git/master, 4.14.1). > > > File Attachments > > > cop

Re: Review Request 120287: [OS X] make kde-workspace build

-4277-851c-226bc0673aa1__patchreview-20140920.patch Thanks, René J.V. Bertin

Re: Review Request 120287: [OS X] make kde-workspace build

ed locally, which had no tabs when I uploaded it https://git.reviewboard.kde.org/media/uploaded/files/2014/09/20/b212730f-6258-4277-851c-226bc0673aa1__patchreview-20140920.patch Thanks, René J.V. Bertin

Re: Review Request 120287: [OS X] make kde-workspace build

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120287/ --- (Updated Sept. 20, 2014, 12:51 p.m.) Review request for KDE Software on M

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

> On Sept. 18, 2014, 9:19 vorm., Thomas Lübking wrote: > > drkonqi/main.cpp, line 47 > > > > > > this sounds fishy - at least the comment to be incorrect? > > i hope that OSX does not just actually abort() whe

Re: Review Request 120287: [OS X] make kde-workspace build

> On Sept. 20, 2014, 10:20 a.m., Martin Gräßlin wrote: > > CMakeLists.txt, lines 225-234 > > > > > > tabs instead of whitespaces > > René J.V. Bertin wrote: > I looked into those yesterday, and cannot find t

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash)

> On Juli 29, 2014, 3:33 nachm., Aleix Pol Gonzalez wrote: > > kinit/kinit.cpp, line 1481 > > > > > > do you need $DISPLAY in OS X? > > René J.V. Bertin wrote: > Nope. It can be set if the user has XQuartz

Re: Review Request 120287: [OS X] make kde-workspace build

> On Sept. 20, 2014, 10:20 a.m., Martin Gräßlin wrote: > > kcontrol/krdb/krdb.cpp, line 56 > > > > > > added newline > > René J.V. Bertin wrote: > Ah, the famous German rigor ... is this really an issue, shou

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

> On Sept. 18, 2014, 11:19 a.m., Thomas Lübking wrote: > > drkonqi/main.cpp, line 47 > > > > > > this sounds fishy - at least the comment to be incorrect? > > i hope that OSX does not just actually abort() whe

Re: Review Request 120287: [OS X] make kde-workspace build

> On Sept. 20, 2014, 8:20 vorm., Martin Gräßlin wrote: > > kcontrol/krdb/krdb.cpp, line 56 > > > > > > added newline > > René J.V. Bertin wrote: > Ah, the famous German rigor ... is this really an issue, shou

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

> On Sept. 18, 2014, 9:19 vorm., Thomas Lübking wrote: > > drkonqi/main.cpp, line 47 > > > > > > this sounds fishy - at least the comment to be incorrect? > > i hope that OSX does not just actually abort() whe

Re: Review Request 120287: [OS X] make kde-workspace build

> On Sept. 20, 2014, 10:20 a.m., Martin Gräßlin wrote: > > kcontrol/krdb/krdb.cpp, line 56 > > > > > > added newline > > René J.V. Bertin wrote: > Ah, the famous German rigor ... is this really an issue, shou

Re: Review Request 120287: [OS X] make kde-workspace build

> On Sept. 20, 2014, 10:25 a.m., René J.V. Bertin wrote: > > While we're discussing krdb's function on non-X11 systems: > > > > I seem to recall that the colour theme selector kcm had an effect like it > > has under X11: applying the new theme to running applications instantly. I > > can no lo

Re: Review Request 120287: [OS X] make kde-workspace build

> On Sept. 20, 2014, 8:20 vorm., Martin Gräßlin wrote: > > kcontrol/krdb/krdb.cpp, line 56 > > > > > > added newline > > René J.V. Bertin wrote: > Ah, the famous German rigor ... is this really an issue, shou

Re: Review Request 120287: [OS X] make kde-workspace build

> On Sept. 20, 2014, 8:20 vorm., Martin Gräßlin wrote: > > kcontrol/krdb/krdb.cpp, line 56 > > > > > > added newline > > René J.V. Bertin wrote: > Ah, the famous German rigor ... is this really an issue, shou

Re: Review Request 120287: [OS X] make kde-workspace build

> On Sept. 20, 2014, 10:20 vorm., Martin Gräßlin wrote: > > kcontrol/krdb/krdb.cpp, line 56 > > > > > > added newline > > René J.V. Bertin wrote: > Ah, the famous German rigor ... is this really an issue, sho

Re: Review Request 120287: [OS X] make kde-workspace build

> On Sept. 20, 2014, 10:20 a.m., Martin Gräßlin wrote: > > kcontrol/krdb/krdb.cpp, line 56 > > > > > > added newline Ah, the famous German rigor ... is this really an issue, shouldn't that empty line have been t

Re: Review Request 120287: [OS X] make kde-workspace build

> On Sept. 20, 2014, 10:20 vorm., Martin Gräßlin wrote: > > libs/CMakeLists.txt, line 10 > > > > > > why is that Darwin and all other cases are APPLE? > > René J.V. Bertin wrote: > Good one. Look just a bit d

Re: Review Request 120287: [OS X] make kde-workspace build

> On Sept. 20, 2014, 10:25 vorm., René J.V. Bertin wrote: > > While we're discussing krdb's function on non-X11 systems: > > > > I seem to recall that the colour theme selector kcm had an effect like it > > has under X11: applying the new theme to running applications instantly. I > > can no l

Re: Review Request 120287: [OS X] make kde-workspace build

> On Sept. 20, 2014, 10:20 vorm., Martin Gräßlin wrote: > > CMakeLists.txt, lines 225-234 > > > > > > tabs instead of whitespaces > > René J.V. Bertin wrote: > I looked into those yesterday, and cannot find

Re: Review Request 120287: [OS X] make kde-workspace build

> On Sept. 20, 2014, 10:20 a.m., Martin Gräßlin wrote: > > CMakeLists.txt, lines 225-234 > > > > > > tabs instead of whitespaces I looked into those yesterday, and cannot find tabs on my end. No idea where they

Re: Review Request 120287: [OS X] make kde-workspace build

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120287/#review67024 --- While we're discussing krdb's function on non-X11 systems: I

Re: Review Request 120287: [OS X] make kde-workspace build

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120287/#review67023 --- CMakeLists.txt

Re: Review Request 120287: [OS X] make kde-workspace build

> On Sept. 19, 2014, 10:24 nachm., Martin Gräßlin wrote: > > overall I rather tend to -1 for these changes. I consider changing the > > build system in a long term release as way too risky considering that the > > core development doesn't use this iteration any more. Any unintended > > breakag

Re: Review Request 120287: [OS X] make kde-workspace build

> On Sept. 20, 2014, 12:26 a.m., Christoph Feck wrote: > > You added APPLE to the if() but not always to the matching endif()... > > René J.V. Bertin wrote: > True. But that's optional, no? On Saturday September 20 2014, Rolf Eike Beer wrote regarding "Re: Review Request 120287: [OS X] mak

Re: Review Request 120287: [OS X] make kde-workspace build

Am Freitag, 19. September 2014, 22:57:40 schrieb René J.V. Bertin: > > On Sept. 20, 2014, 12:26 a.m., Christoph Feck wrote: > > > You added APPLE to the if() but not always to the matching endif()... > > True. But that's optional, no? The endif needs to have either a matching argument to the last