Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner "system tray"

> On Sept. 17, 2014, 6:13 nachm., Pino Toscano wrote: > > kdeui/actions/kaction.cpp, lines 150-179 > > > > > > The whole setTextWithCorrectMenuRole is totally broken from an i18n > > point of view: > > - we

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119498/#review66801 --- Please would someone give this a "Ship It", or should I do it

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner "system tray"

> On Sept. 15, 2014, 12:19 p.m., Thomas Lübking wrote: > > kdeui/actions/kaction.cpp, line 149 > > > > > > what if > > KAction *foo = new KAction(this); > > foo->setText("Foo"); > > > > -> you ra

Re: Review Request 120182: KIO::CopyJob: Do not query for free space when filesystem type is unknown

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120182/ --- (Updated Sept. 18, 2014, 3:52 a.m.) Review request for kdelibs and David

Re: Review Request 120182: KIO::CopyJob: Do not query for free space when filesystem type is unknown

> On Sept. 17, 2014, 7:49 p.m., David Faure wrote: > > I like this patch :-) > > > > Well, maybe we could even get rid of the fsType checks? I was going to suggest the same thing. For our purposes here, we do not care if the filesystem type is identified. We only care about whether or not the

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner "system tray"

> On Sept. 17, 2014, 8:13 p.m., Pino Toscano wrote: > > kdeui/actions/kaction.cpp, lines 150-179 > > > > > > The whole setTextWithCorrectMenuRole is totally broken from an i18n > > point of view: > > - we do

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner "system tray"

> On Sept. 17, 2014, 6:13 nachm., Pino Toscano wrote: > > kdeui/actions/kaction.cpp, lines 150-179 > > > > > > The whole setTextWithCorrectMenuRole is totally broken from an i18n > > point of view: > > - we

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner "system tray"

> On Sept. 17, 2014, 8:13 p.m., Pino Toscano wrote: > > kdeui/actions/kaction.cpp, lines 150-179 > > > > > > The whole setTextWithCorrectMenuRole is totally broken from an i18n > > point of view: > > - we do

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner "system tray"

> On Sept. 17, 2014, 6:13 nachm., Pino Toscano wrote: > > kdeui/actions/kaction.cpp, lines 150-179 > > > > > > The whole setTextWithCorrectMenuRole is totally broken from an i18n > > point of view: > > - we

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner "system tray"

> On Sept. 17, 2014, 8:13 p.m., Pino Toscano wrote: > > kdeui/actions/kaction.cpp, lines 150-179 > > > > > > The whole setTextWithCorrectMenuRole is totally broken from an i18n > > point of view: > > - we do

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner "system tray"

> On Set. 17, 2014, 6:13 p.m., Pino Toscano wrote: > > kdeui/actions/kaction.cpp, lines 150-179 > > > > > > The whole setTextWithCorrectMenuRole is totally broken from an i18n > > point of view: > > - we don

Re: Review Request 119372: Fix Bug 337486 - Should not permit moving of read-only folder to a different directory

> On Sept. 17, 2014, 7:39 p.m., David Faure wrote: > > Interesting, didn't know about this posix restriction (a bit inconsistent > > imho, the readonly dir vs readonly file difference). > > Thomas Lübking wrote: > The ro flag only guarantees integrity, not presence. > > The absent

Re: Review Request 119372: Fix Bug 337486 - Should not permit moving of read-only folder to a different directory

> On Sept. 17, 2014, 7:39 nachm., David Faure wrote: > > Interesting, didn't know about this posix restriction (a bit inconsistent > > imho, the readonly dir vs readonly file difference). The ro flag only guarantees integrity, not presence. The absent write permission of a directory esp. prote

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner "system tray"

> On Sept. 17, 2014, 8:13 p.m., Pino Toscano wrote: > > kdeui/notifications/kstatusnotifieritem.cpp, lines 728-730 > > > > > > What is this used for? > > If it is not used, please remove it, otherwise just in

Re: Review Request 120182: KIO::CopyJob: Do not query for free space when filesystem type is unknown

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120182/#review66775 --- Ship it! I like this patch :-) Well, maybe we could even get

Re: Review Request 119372: Fix Bug 337486 - Should not permit moving of read-only folder to a different directory

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119372/#review66430 --- Interesting, didn't know about this posix restriction (a bit i

Re: Review Request 110563: Crash fix: hide symbols from static lib QtUitools.a (generically by new macro KDE4_HIDE_SYMBOLS_FROM_STATIC_LIBS)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/110563/ --- (Updated Sept. 17, 2014, 7:36 nachm.) Status -- This change has been

Re: "Automatic Info Reporting" BoF summary

El Dimecres, 17 de setembre de 2014, a les 10:02:08, Mario Fux va escriure: > Am Dienstag, 16. September 2014, 00.52:28 schrieb Albert Astals Cid: > > Morning > > Thanks a lot for bringing this forward. IMHO it's a very important topic and > future communication channel with our users but I think

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner "system tray"

> On Set. 17, 2014, 6:13 p.m., Pino Toscano wrote: > > Two general notes: > > - please respect the kdelibs coding style, for example removing the extra > > spaces in instructions > > - please remove the extra kDebug Oops, I accidentally checked "Ship it!", while this is totally not the case (r

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner "system tray"

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120149/#review66764 --- Ship it! Two general notes: - please respect the kdelibs codi

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner "system tray"

> On Sept. 15, 2014, 2:19 p.m., Thomas Lübking wrote: > > kdeui/actions/kaction.cpp, line 149 > > > > > > what if > > KAction *foo = new KAction(this); > > foo->setText("Foo"); > > > > -> you rat

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner "system tray"

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120149/ --- (Updated Sept. 17, 2014, 7:48 p.m.) Review request for KDE Software on Ma

Re: Review Request 120182: KIO::CopyJob: Do not query for free space when filesystem type is unknown

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120182/ --- (Updated Sept. 17, 2014, 12:55 p.m.) Review request for kdelibs and David

Re: Review Request 120182: KIO::CopyJob: Do not query for free space when filesystem type is unknown

> On Sept. 16, 2014, 3:39 p.m., David Faure wrote: > > better idea, testing for KDiskFreeSpaceInfo's success. > > > > http://www.davidfaure.fr/2014/copyjob.cpp.diff That works as well. - Dawit --- This is an automatically generated e-m

Re: "Automatic Info Reporting" BoF summary

Am Dienstag, 16. September 2014, 00.52:28 schrieb Albert Astals Cid: Morning Thanks a lot for bringing this forward. IMHO it's a very important topic and future communication channel with our users but I think as well that it's a multi-year thing before we can earn the first fruits. So let's st