Re: KF5 tab style issues

2014-09-16 Thread Hugo Pereira Da Costa
On 09/15/2014 10:42 PM, Michal Humpula wrote: Hi there, I've encountered strange issue with the style of kf5 kdevelop tabs. Specifically the close button takes more space then anything else. It seems to be drawn by QCommonStyle class, which is inherited by KStyle. What I'm not sure, where is th

Re: KF5 tab style issues

2014-09-16 Thread Thomas Lübking
On Montag, 15. September 2014 22:42:03 CEST, Michal Humpula wrote: I've encountered strange issue with the style of kf5 kdevelop tabs. Specifically the close button takes more space then anything else. It seems to be drawn by QCommonStyle class, which is inherited by KStyle. If it's the stock

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash)

2014-09-16 Thread René J . V . Bertin
On Tuesday September 16 2014 11:31:30 Ian Wadham wrote: > The socket name is generated in 3 or 4 places, I am not sure how many. All of > these must "line up" if KCrash, kdeinit4, klauncher, kded4 and kwrapper are > to run as and when required and interact correctly on Apple OS X. And I am > no

KF5 tab style issues

2014-09-16 Thread Michal Humpula
Hi there, I've encountered strange issue with the style of kf5 kdevelop tabs. Specifically the close button takes more space then anything else. It seems to be drawn by QCommonStyle class, which is inherited by KStyle. What I'm not sure, where is the bug. Is it in the * QCommonStyle because it

Re: Using Gerrit for code review in KDE

2014-09-16 Thread Oswald Buddenhagen
On Mon, Sep 15, 2014 at 09:34:27AM -0700, Thiago Macieira wrote: > On Monday 15 September 2014 16:49:39 Milian Wolff wrote: > > Where do I see the diff there? In the gerrit that runs on qt-project, I can > > easily click one button to go to a unified or side-by-side diff view. Is > > that a custom

Re: Review Request 120182: KIO::CopyJob: Do not query for free space when filesystem type is unknown

2014-09-16 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120182/#review66682 --- better idea, testing for KDiskFreeSpaceInfo's success. http:/

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner "system tray"

2014-09-16 Thread René J . V . Bertin
> On Sept. 15, 2014, 2:19 p.m., Thomas Lübking wrote: > > kdeui/actions/kaction.cpp, line 164 > > > > > > would this eg. work with kwrite ("Configure Editor...")? - or other > > kpart driven things? > > René J.

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner "system tray"

2014-09-16 Thread René J . V . Bertin
> On Sept. 15, 2014, 2:19 p.m., Thomas Lübking wrote: > > kdeui/widgets/kmenu.cpp, line 174 > > > > > > this is *utterly* wrong - you're manipulating a QAction reference just > > because it (at this very time!)

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash)

2014-09-16 Thread Ian Wadham
> On July 29, 2014, 3:33 p.m., Aleix Pol Gonzalez wrote: > > kinit/kinit.cpp, line 1481 > > > > > > do you need $DISPLAY in OS X? > > René J.V. Bertin wrote: > Nope. It can be set if the user has XQuartz in

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash)

2014-09-16 Thread Ian Wadham
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119497/ --- (Updated Sept. 16, 2014, 11:14 a.m.) Review request for KDE Software on M

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

2014-09-16 Thread Ian Wadham
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119498/ --- (Updated Sept. 16, 2014, 11:08 a.m.) Review request for KDE Software on M

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

2014-09-16 Thread Ian Wadham
> On July 27, 2014, 11:17 a.m., Thomas Lübking wrote: > > This part of the patch, to fix the bug in the backtrace lines highlighter, has been re-written as suggested by Thomas, by adding a dummy entry to the lines, and the ASSERT remains because we should never get past the dummy, however many

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

2014-09-16 Thread Ian Wadham
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119498/ --- (Updated Sept. 16, 2014, 10:49 a.m.) Review request for KDE Software on M

Re: Using Gerrit for code review in KDE

2014-09-16 Thread Jan Kundrát
On Monday, 15 September 2014 16:49:39 CEST, Milian Wolff wrote: Where do I see the diff there? Thanks to Ben and his review of my patches, Gerrit is now replicating all of the changes under review into KDE's git as well. In the context of this discussion, it means that there's now a link to K

Re: About X11's WM_HINTS.UrgencyHint and KF5's NET::DemandsAttention

2014-09-16 Thread Martin Gräßlin
On Wednesday 03 September 2014 14:36:48 Paulo Lieuthier wrote: > Hello everyone, > > I'm a LXQt contributor and I've been working on getting it rid of Xlib calls > by using KF5's WindowSystem. It looks nice so far. > > The problem I'm having now is that I can't get the taskbar to indicate a > win

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash)

2014-09-16 Thread René J . V . Bertin
> On July 29, 2014, 5:33 p.m., Aleix Pol Gonzalez wrote: > > kinit/kinit.cpp, line 1481 > > > > > > do you need $DISPLAY in OS X? > > René J.V. Bertin wrote: > Nope. It can be set if the user has XQuartz in