Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner "system tray"

> On Sept. 15, 2014, 12:19 nachm., Thomas Lübking wrote: > > kdeui/actions/kaction.cpp, line 188 > > > > > > given KAction, KMenu and KMenuBar are all deprecated in KF5, is this > > actually of any upstream rele

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119498/#review66626 --- And this should be marked as depending on RR 119497 in "Depend

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash)

> On Sept. 15, 2014, 9:26 p.m., Marko Käning wrote: > > Hi Ian, shall I test this on a Mavericks VM before you're committing this? > > In case I shall do it, do you have a test case for me? Greets, Marko > > Ian Wadham wrote: > Thanks, but please wait until I drop the other shoe, review 119

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash)

> On Sept. 15, 2014, 9:26 p.m., Marko Käning wrote: > > Hi Ian, shall I test this on a Mavericks VM before you're committing this? > > In case I shall do it, do you have a test case for me? Greets, Marko > > Ian Wadham wrote: > Thanks, but please wait until I drop the other shoe, review 119

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash)

> On Sept. 15, 2014, 7:26 p.m., Marko Käning wrote: > > Hi Ian, shall I test this on a Mavericks VM before you're committing this? > > In case I shall do it, do you have a test case for me? Greets, Marko Thanks, but please wait until I drop the other shoe, review 119498, fix Dr Konqi. The tes

Re: Review Request 120210: kdoctools: style images more elegantly

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120210/ --- (Updated Sept. 16, 2014, 1:15 a.m.) Review request for Documentation, kde

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner "system tray"

> On Sept. 15, 2014, 2:19 p.m., Thomas Lübking wrote: > > kdeui/actions/kaction.cpp, line 164 > > > > > > would this eg. work with kwrite ("Configure Editor...")? - or other > > kpart driven things? > > René J.

"Automatic Info Reporting" BoF summary

BoF that that is a follow up of https://conf.kde.org/system/attachments/45/original/spyware.pdf?1410020392 and http://files.kde.org/akademy/2014/videos/The_case_for_spyware_-_Albert_Astals_Cid.webm Albert's plan. 1. Have a KDED. --- On First Run -> Show "Dialog" --- Send data every

Re: Using Gerrit for code review in KDE

On Monday, 15 September 2014 16:49:39 CEST, Milian Wolff wrote: Where do I see the diff there? For me, it's easiest to just click on any file name. That will open a diff view (either side-by-side or a unidiff one, based on your prefs). The diff shows just a single file, but you can use "[" an

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner "system tray"

> On Sept. 15, 2014, 12:19 nachm., Thomas Lübking wrote: > > kdeui/actions/kaction.cpp, line 149 > > > > > > what if > > KAction *foo = new KAction(this); > > foo->setText("Foo"); > > > > -> you

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119497/#review66598 --- Hi Ian, shall I test this on a Mavericks VM before you're comm

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner "system tray"

> On Sept. 15, 2014, 2:19 p.m., Thomas Lübking wrote: > > kdeui/widgets/kmenu.cpp, line 174 > > > > > > this is *utterly* wrong - you're manipulating a QAction reference just > > because it (at this very time!)

Re: Using Gerrit for code review in KDE

On Monday 15 September 2014 16:49:39 Milian Wolff wrote: > Where do I see the diff there? In the gerrit that runs on qt-project, I can > easily click one button to go to a unified or side-by-side diff view. Is > that a custom extension? Generally, it seems as if the qt-project gerrit > has a much

Re: Using Gerrit for code review in KDE

On Saturday 13 September 2014 23:05:48 Eike Hein wrote: > On 13.09.2014 22:50, Sven Brauch wrote: > > That's my opinion as well. It would be nice to have an explicit way to > > differentiate the "I think this patch is okay, but I'm not very > > familiar with the code you changed" (+1) and "I'm conf

Re: Using Gerrit for code review in KDE

On Saturday, 13 September 2014 23:05:48 CEST, Eike Hein wrote: Yeah, that's something I'm OK with too. Maybe we can even adapt the UI to use strings like Sven proposes? https://gerrit.vesnicky.cesnet.cz/r/35 With kind regards, Jan -- Trojitá, a fast Qt IMAP e-mail client -- http://trojita.fla

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner "system tray"

> On Sept. 15, 2014, 2:19 p.m., Thomas Lübking wrote: > > kdeui/actions/kaction.cpp, line 164 > > > > > > would this eg. work with kwrite ("Configure Editor...")? - or other > > kpart driven things? > > René J.

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner "system tray"

> On Sept. 15, 2014, 2:19 p.m., Thomas Lübking wrote: > > kdeui/actions/kaction.cpp, line 188 > > > > > > given KAction, KMenu and KMenuBar are all deprecated in KF5, is this > > actually of any upstream relevan

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner "system tray"

> On Sept. 15, 2014, 2:45 a.m., Ian Wadham wrote: > > I cannot see how "static void setTextWithCorrectMenuRole()" could work in > > all languages. > > > > Does not the "text" parameter come translated into the user's language, not > > necessarily English? So how can the ".contains" checks work

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner "system tray"

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120149/#review66546 --- In general coding style is systematically wrong ( "if (a", not

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner "system tray"

> On Sept. 15, 2014, 2:45 a.m., Ian Wadham wrote: > > I cannot see how "static void setTextWithCorrectMenuRole()" could work in > > all languages. > > > > Does not the "text" parameter come translated into the user's language, not > > necessarily English? So how can the ".contains" checks work

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner "system tray"

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120149/ --- (Updated Sept. 15, 2014, 1:03 p.m.) Review request for KDE Software on Ma

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash)

> On July 27, 2014, 1:32 p.m., Thomas Lübking wrote: > > kdeui/util/kcrash.cpp, line 316 > > > > > > is libdispatch OSX only or is it also used on FreeBSD? > > > > The question (more to Michael ;-) is wh

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119497/#review66509 --- Ship it! The "wrong socket name" sounds like a workaround for