Re: Using Gerrit for code review in KDE

2014-09-09 Thread Jan Kundrát
On Tuesday, 9 September 2014 21:44:25 CEST, Alexander Neundorf wrote: Having two different patch review systems for one project... I mean, this is surely not a good idea. Two places to send patches, to places to review patches, two different user interfaces, This is not a final state. To be h

Re: Using Gerrit for code review in KDE

2014-09-09 Thread Jan Kundrát
On Tuesday, 9 September 2014 20:02:55 CEST, Aaron J. Seigo wrote: That would honestly make more sense for Plasma imho, though it still would make sense to start small and consistent. A suggestion made by sysadmins was to start with just a couple of repos to prevent further confusion and to bui

Re: Using Gerrit for code review in KDE

2014-09-09 Thread Jan Kundrát
On Tuesday, 9 September 2014 17:39:54 CEST, Aaron J. Seigo wrote: Would it not make more sense to trial it using newer / smaller / unstable projects, as it is an experiment? Yes, which is why trojita.git was dogfooding Gerrit before I announced this. As it stands with plasma-framework in par

Re: Review Request 120120: kmenuedit: do not resize app icons (fixes #338883)

2014-09-09 Thread Thomas Lübking
> On Sept. 9, 2014, 8:02 nachm., Thomas Lübking wrote: > > treeview.cpp, line 232 > > > > > > Maybe rather try to limit to the font height instead? > > Christoph Feck wrote: > Why? We use "Small" icon size n

Re: Review Request 120120: kmenuedit: do not resize app icons (fixes #338883)

2014-09-09 Thread Boris Egorov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120120/ --- (Updated Sept. 9, 2014, 8:10 p.m.) Review request for kde-workspace. Bu

Re: Review Request 120120: kmenuedit: do not resize app icons (fixes #338883)

2014-09-09 Thread Christoph Feck
> On Sept. 9, 2014, 8:02 p.m., Thomas Lübking wrote: > > treeview.cpp, line 232 > > > > > > Maybe rather try to limit to the font height instead? Why? We use "Small" icon size next to text everywhere (buttons, m

Re: Review Request 120120: kmenuedit: do not resize app icons (fixes #338883)

2014-09-09 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120120/#review66152 --- treeview.cpp

Re: Using Gerrit for code review in KDE

2014-09-09 Thread Alexander Neundorf
On Tuesday, September 09, 2014 20:02:55 Aaron J. Seigo wrote: > On Tuesday, September 9, 2014 18.49:24 Kevin Ottens wrote: > > > As it stands with plasma-framework in particular, there is now a > > > difference > > > in workflow depending on what *part* of plasma one is working on > > > (framework

Re: Using Gerrit for code review in KDE

2014-09-09 Thread Ben Cooksley
Hi all, Just to clarify what is happening here, based on my reading of the discussion here thus far, and in #kde-devel earlier today. I concur with the majority that a unified tool, similar to Gitlab would be an excellent improvement on our current infrastructure. Unfortunately we found that at o

Re: Review Request 120120: kmenuedit: do not resize app icons (fixes #338883)

2014-09-09 Thread Boris Egorov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120120/ --- (Updated Sept. 9, 2014, 6:37 p.m.) Review request for kde-workspace. Ch

Re: Using Gerrit for code review in KDE

2014-09-09 Thread Aaron J. Seigo
On Tuesday, September 9, 2014 18.32:41 Pier Luigi Fiorini wrote: > 2014-09-09 17:39 GMT+02:00 Aaron J. Seigo : > > [1] even if I have my personal doubts w/regards to gerrit's > > appropriateness > > for KDE > > Probably I'm too late for the party, but have you considered gitlab? Yes; I helped tri

Re: Using Gerrit for code review in KDE

2014-09-09 Thread Aaron J. Seigo
On Tuesday, September 9, 2014 18.49:24 Kevin Ottens wrote: > > As it stands with plasma-framework in particular, there is now a > > difference > > in workflow depending on what *part* of plasma one is working on > > (framework > > or workspace). So not only is it now different from the majority of

Re: Review Request 120120: kmenuedit: do not resize app icons (fixes #338883)

2014-09-09 Thread Boris Egorov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120120/ --- (Updated Sept. 9, 2014, 5:06 p.m.) Review request for kde-workspace. Ch

Review Request 120120: kmenuedit: do not resize app icons

2014-09-09 Thread Boris Egorov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120120/ --- Review request for kde-workspace. Repository: kmenuedit Description ---

Re: Using Gerrit for code review in KDE

2014-09-09 Thread Kevin Ottens
Hello, OK, I guess there might be some misunderstanding or at least partial information due to live meeting vs short announcement on list. On Tuesday 09 September 2014 17:39:54 Aaron J. Seigo wrote: > On Tuesday, September 9, 2014 16.59:35 Jan Kundrát wrote: > > On Tuesday, 9 September 2014 16:4

Re: Review Request 120119: KRecursiveFilterProxyModel: Fixed the model

2014-09-09 Thread Christian Mollekopf
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120119/ --- (Updated Sept. 9, 2014, 4:26 p.m.) Review request for kdelibs and Stephen

Re: Review Request 120119: KRecursiveFilterProxyModel: Fixed the model

2014-09-09 Thread Christian Mollekopf
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120119/ --- (Updated Sept. 9, 2014, 4:18 p.m.) Review request for kdelibs. Bugs: 33

Review Request 120119: KRecursiveFilterProxyModel: Fixed the model

2014-09-09 Thread Christian Mollekopf
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120119/ --- Review request for kdelibs. Repository: kdelibs Description --- KR

Retiring and testament

2014-09-09 Thread Kevin Ottens
Hello dear KDE contributors, I'm sending this from Akademy 2014. Our KDE Frameworks BoF is now over, as usual we did great progress: https://community.kde.org/Frameworks/Meetings/201409Akademy Also I put in place the goals for the months to come before coming: https://community.kde.org/Framework

Re: Using Gerrit for code review in KDE

2014-09-09 Thread Aaron J. Seigo
On Tuesday, September 9, 2014 16.59:35 Jan Kundrát wrote: > On Tuesday, 9 September 2014 16:44:22 CEST, Eike Hein wrote: > > Exclusively, or do they remain on ReviewBoard as well? > > My understanding is that they do remain on RB as well for now. The goal of > this excercise is to get some underst

Re: Using Gerrit for code review in KDE

2014-09-09 Thread Jan Kundrát
On Tuesday, 9 September 2014 16:44:22 CEST, Eike Hein wrote: Exclusively, or do they remain on ReviewBoard as well? My understanding is that they do remain on RB as well for now. The goal of this excercise is to get some understanding on how Gerrit works and whether it's a good match for fram

Re: Using Gerrit for code review in KDE

2014-09-09 Thread Eike Hein
On 09.09.2014 15:51, Jan Kundrát wrote: Hi, we agreed on the Frameworks BoF that the following two repos are now using Gerrit for some initial testing: Exclusively, or do they remain on ReviewBoard as well? Cheers, Eike

Re: Using Gerrit for code review in KDE

2014-09-09 Thread Jan Kundrát
Hi, we agreed on the Frameworks BoF that the following two repos are now using Gerrit for some initial testing: - kio - plasma-framework Some rudimentary instructions are at https://techbase.kde.org/Development/Gerrit , edits are welcome. If you would like to become a Gerrit admin, want to

Re: Location of Dr Konqi in Frameworks/KF 5

2014-09-09 Thread Aleix Pol
On Fri, Sep 5, 2014 at 8:36 AM, Ian Wadham wrote: > Hi guys, > > I have heard that Dr Konqi source code for Frameworks/KF 5 > has been placed in plasma-workspace. > > Please could you consider keeping it in some location that is > common to all platforms? This includes both Linux platforms and >