Re: Review Request 116481: Calculate remaining battery lifetime considering ALL installed batteries

2014-08-31 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116481/#review65604 --- Ship it! Please fix the style related issues Mark pointed out

Re: Review Request 116481: Calculate remaining battery lifetime considering ALL installed batteries

2014-08-31 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116481/#review65591 --- a/powerdevil/daemon/backends/upower/powerdevilupowerbackend.c

Re: Review Request 116481: Calculate remaining battery lifetime considering ALL installed batteries

2014-08-31 Thread Christoph Feck
> On March 2, 2014, 12:03 a.m., Kai Uwe Broulik wrote: > > Thanks for looking into this, I have a few code-styling related issues, see > > below. > > > > In the future I want to get rid of all of this, especially the magic ints > > instead of enums, and move that stuff to Solid - where it's al