Re: Review Request 119892: [Dolphin] Implement "Add to archive" option when dragging and dropping onto an archive file in dolphin

2014-08-22 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119892/#review65070 --- Thanks for the patch, but I still think (see bug report) that

Re: Review Request 119869: KIO: Correctly handle .directory files

2014-08-22 Thread Maarten De Meyer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119869/ --- (Updated Aug. 22, 2014, 3:48 p.m.) Status -- This change has been ma

Re: Review Request 118763: Remove find_package(XCB) call as it is handled already by the top-level cmake file

2014-08-22 Thread Hugo Pereira Da Costa
> On June 16, 2014, 6:57 a.m., Martin Gräßlin wrote: > > looks good to me, +1. Please add Hugo Pereira Da Costa to the Review > > Request, though. > > > > The review request made me wonder whether we still need to find XLib in > > Oxygen, though. The parts shown only use XCB, so maybe we could

Re: Review Request 118763: Remove find_package(XCB) call as it is handled already by the top-level cmake file

2014-08-22 Thread Bernd Steinhauser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118763/ --- (Updated Aug. 22, 2014, 3:31 p.m.) Status -- This change has been ma