Re: [kde-community] Closing the kde-core-devel mailing list

2014-08-04 Thread Aleix Pol
On Tue, Aug 5, 2014 at 1:17 AM, Milian Wolff wrote: > On Monday 04 August 2014 20:36:44 Vishesh Handa wrote: > > Hello people > > > > Random Idea: How about we close the k-c-d mailing list? It's main purpose > > used to be to discuss kdelibs changes, but now since we have > > kde-frameworks, the

Re: [kde-community] Closing the kde-core-devel mailing list

2014-08-04 Thread Milian Wolff
On Monday 04 August 2014 20:36:44 Vishesh Handa wrote: > Hello people > > Random Idea: How about we close the k-c-d mailing list? It's main purpose > used to be to discuss kdelibs changes, but now since we have > kde-frameworks, the mailing list seems less useful. We already have > kde-devel for o

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

2014-08-04 Thread Ian Wadham
> On July 27, 2014, 11:17 a.m., Thomas Lübking wrote: > > drkonqi/reportassistantpages_bugzilla.cpp, line 300 > > > > > > this is commented. > > > > if the test is pointless altogether (i do not know. no

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash, kinit)

2014-08-04 Thread Michael Pyne
> On July 27, 2014, 11:32 a.m., Thomas Lübking wrote: > > kdeui/util/kcrash.cpp, line 316 > > > > > > is libdispatch OSX only or is it also used on FreeBSD? > > > > The question (more to Michael ;-) is w

Re: Review Request 119594: fix FileDialog size restorage

2014-08-04 Thread Thomas Lübking
> On Aug. 4, 2014, 12:11 nachm., Martin Klapetek wrote: > > This does fix the issue here; +1 from me > > > > Also, are you investigating/reporting the bug to Qt devs? > > Thomas Lübking wrote: > On a quick glimpse, it looks like the issue is that QWidgetWindow syncs > stuff and that it syn

Re: Review Request 119593: Ensure there's a platform window before restoring the window geometry and then process the resize

2014-08-04 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119593/ --- (Updated Aug. 4, 2014, 8:39 nachm.) Review request for KDE Frameworks, kd

Closing the kde-core-devel mailing list

2014-08-04 Thread Vishesh Handa
Hello people Random Idea: How about we close the k-c-d mailing list? It's main purpose used to be to discuss kdelibs changes, but now since we have kde-frameworks, the mailing list seems less useful. We already have kde-devel for other generic kde stuff. -- Vishesh Handa

Re: Review Request 119593: Ensure there's a plastform window before restoring the window geometry

2014-08-04 Thread Lukáš Tinkl
> On Srp. 4, 2014, 1:13 dop., Lukáš Tinkl wrote: > > No change here, ie. it doesn't restore the window geometry. > > Martin Klapetek wrote: > Same here, Qt 5.3.1. Thomas, which Qt are you using? > > Nevertheless, as your knowledge about windows stuff is much better and if > you thi

Re: Review Request 119594: fix FileDialog size restorage

2014-08-04 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119594/#review63770 --- Ship it! Great, this works for me :) Now what about https://

Re: Review Request 119572: Part: use correct slots for QStatusbar

2014-08-04 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119572/#review63769 --- Ship it! Ship It! - Martin Tobias Holmedahl Sandsmark On A

Re: Review Request 119594: fix FileDialog size restorage

2014-08-04 Thread Thomas Lübking
> On Aug. 4, 2014, 12:11 nachm., Martin Klapetek wrote: > > This does fix the issue here; +1 from me > > > > Also, are you investigating/reporting the bug to Qt devs? On a quick glimpse, it looks like the issue is that QWidgetWindow syncs stuff and that it syncs (only) in ::event() ie. the eve

Re: Review Request 119594: fix FileDialog size restorage

2014-08-04 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119594/#review63765 --- Ship it! This does fix the issue here; +1 from me Also, are

Re: Review Request 119594: fix FileDialog size restorage

2014-08-04 Thread Thomas Lübking
> On Aug. 3, 2014, 11:13 nachm., Lukáš Tinkl wrote: > > No change here, ie. it doesn't restore the file dialog geometry. > > Thomas Lübking wrote: > what is your precise testcase? > a bit remote because of your other patches: did you check that the > correct platformtheme lib is used? (

Re: Review Request 119594: fix FileDialog size restorage

2014-08-04 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119594/ --- (Updated Aug. 4, 2014, 11:57 vorm.) Review request for KDE Frameworks, kd

Re: Review Request 119593: Ensure there's a plastform window before restoring the window geometry

2014-08-04 Thread Martin Klapetek
> On Aug. 4, 2014, 1:13 a.m., Lukáš Tinkl wrote: > > No change here, ie. it doesn't restore the window geometry. Same here, Qt 5.3.1. Thomas, which Qt are you using? Nevertheless, as your knowledge about windows stuff is much better and if you think this patch is needed anyway, go for it. -

Re: Review Request 119594: ensure there's ::windowHandle() and then restore the a file dialogs size before calling ::exec()

2014-08-04 Thread Martin Klapetek
> On Aug. 4, 2014, 1:13 a.m., Lukáš Tinkl wrote: > > No change here, ie. it doesn't restore the file dialog geometry. > > Thomas Lübking wrote: > what is your precise testcase? > a bit remote because of your other patches: did you check that the > correct platformtheme lib is used? (ran

Re: Review Request 119594: ensure there's ::windowHandle() and then restore the a file dialogs size before calling ::exec()

2014-08-04 Thread Lukáš Tinkl
> On Srp. 4, 2014, 1:13 dop., Lukáš Tinkl wrote: > > No change here, ie. it doesn't restore the file dialog geometry. > > Thomas Lübking wrote: > what is your precise testcase? > a bit remote because of your other patches: did you check that the > correct platformtheme lib is used? (ran

Re: Review Request 119594: ensure there's ::windowHandle() and then restore the a file dialogs size before calling ::exec()

2014-08-04 Thread Martin Klapetek
> On Aug. 4, 2014, 1:13 a.m., Lukáš Tinkl wrote: > > No change here, ie. it doesn't restore the file dialog geometry. > > Thomas Lübking wrote: > what is your precise testcase? > a bit remote because of your other patches: did you check that the > correct platformtheme lib is used? (ran

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

2014-08-04 Thread Ben Cooksley
> On July 27, 2014, 11:17 a.m., Thomas Lübking wrote: > > drkonqi/reportassistantpages_bugzilla.cpp, line 300 > > > > > > this is commented. > > > > if the test is pointless altogether (i do not know. no

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

2014-08-04 Thread RJVB Bertin
> On July 27, 2014, 1:17 p.m., Thomas Lübking wrote: > > drkonqi/reportassistantpages_bugzilla.cpp, line 300 > > > > > > this is commented. > > > > if the test is pointless altogether (i do not know. no

Re: Review Request 119594: ensure there's ::windowHandle() and then restore the a file dialogs size before calling ::exec()

2014-08-04 Thread Lukáš Tinkl
> On Srp. 4, 2014, 1:13 dop., Lukáš Tinkl wrote: > > No change here, ie. it doesn't restore the file dialog geometry. > > Thomas Lübking wrote: > what is your precise testcase? > a bit remote because of your other patches: did you check that the > correct platformtheme lib is used? (ran

Re: Review Request 119594: ensure there's ::windowHandle() and then restore the a file dialogs size before calling ::exec()

2014-08-04 Thread Thomas Lübking
> On Aug. 3, 2014, 11:13 nachm., Lukáš Tinkl wrote: > > No change here, ie. it doesn't restore the file dialog geometry. what is your precise testcase? a bit remote because of your other patches: did you check that the correct platformtheme lib is used? (ran into this in a custom installation.