Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

2014-08-01 Thread Ian Wadham
> On July 27, 2014, 11:17 a.m., Thomas Lübking wrote: > > drkonqi/reportassistantpages_bugzilla.cpp, line 300 > > > > > > this is commented. > > > > if the test is pointless altogether (i do not know. no

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

2014-08-01 Thread Ben Cooksley
> On July 27, 2014, 11:17 a.m., Thomas Lübking wrote: > > drkonqi/reportassistantpages_bugzilla.cpp, line 300 > > > > > > this is commented. > > > > if the test is pointless altogether (i do not know. no

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-08-01 Thread Thomas Lübking
On Juli 28, 2014, 10:17 vorm., Lukáš Tinkl wrote: > > If the only issue is the open ::exec() TODO, you might "trick" it by > > calling ::winId(), then restore the size and ultimately ::exec() > > > > Otherwise you could open an own nested eventloop instead of relying on the > > dialogs exec, b

Re: Review Request 119014: KUrlRequester: fixing handling of start directory

2014-08-01 Thread Simon Bachmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119014/ --- (Updated Aug. 1, 2014, 9:39 nachm.) Review request for kdelibs. Bugs: 9

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-08-01 Thread Lukáš Tinkl
On Čec. 28, 2014, 12:17 odp., Lukáš Tinkl wrote: > > If the only issue is the open ::exec() TODO, you might "trick" it by > > calling ::winId(), then restore the size and ultimately ::exec() > > > > Otherwise you could open an own nested eventloop instead of relying on the > > dialogs exec, bu

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-08-01 Thread Thomas Lübking
On Juli 28, 2014, 10:17 vorm., Lukáš Tinkl wrote: > > If the only issue is the open ::exec() TODO, you might "trick" it by > > calling ::winId(), then restore the size and ultimately ::exec() > > > > Otherwise you could open an own nested eventloop instead of relying on the > > dialogs exec, b