Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

> On July 27, 2014, 11:17 a.m., Thomas Lübking wrote: > > drkonqi/gdbhighlighter.cpp, line 74 > > > > > > an abort is not a crash ;-) > > > > If you hit this assert, the looked up (lineNr - 1) is somehow

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash, kinit)

> On July 29, 2014, 3:33 p.m., Aleix Pol Gonzalez wrote: > > kinit/kinit.cpp, line 1481 > > > > > > do you need $DISPLAY in OS X? > > RJVB Bertin wrote: > Nope. It can be set if the user has XQuartz install

Re: Review Request 114910: Patch for bug 317066 ("systray leaves garbage on the panel when resizing ")

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114910/ --- (Updated July 29, 2014, 9:03 p.m.) Status -- This change has been ma

Re: Review Request 114910: Patch for bug 317066 ("systray leaves garbage on the panel when resizing ")

> On jul. 29, 2014, 5:12 p.m., Marco Martin wrote: > > Ship It! Marco, Dmitry doesn't have an account, can you please push this to 4.11? - Albert --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kd

Re: Review Request 114910: Patch for bug 317066 ("systray leaves garbage on the panel when resizing ")

> On July 29, 2014, 10:31 a.m., Marco Martin wrote: > > this would require some testing before pushing to 4.x, too delicate to just > > commit > > Dmitry Ivanov wrote: > Well, I've been living with this patch for half a year already, since > January 8 :) I used it with a number of KDE 4.x

Re: Review Request 114910: Patch for bug 317066 ("systray leaves garbage on the panel when resizing ")

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114910/#review63466 --- Ship it! Ship It! - Marco Martin On Jan. 8, 2014, 4:25 p.m

Re: Review Request 119454: Make FindPyKDE4 work with PyQt's new build system.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119454/ --- (Updated July 29, 2014, 5:10 p.m.) Status -- This change has been ma

Re: Review Request 114910: Patch for bug 317066 ("systray leaves garbage on the panel when resizing ")

> On Июль 29, 2014, 2:31 п.п., Marco Martin wrote: > > this would require some testing before pushing to 4.x, too delicate to just > > commit Well, I've been living with this patch for half a year already, since January 8 :) I used it with a number of KDE 4.x versions from 4.11.3 to 4.13.1 (co

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash, kinit)

> On July 29, 2014, 5:33 p.m., Aleix Pol Gonzalez wrote: > > kinit/kinit.cpp, line 1481 > > > > > > do you need $DISPLAY in OS X? Nope. It can be set if the user has XQuartz installed and running, but that sho

Re: Review Request 118180: slideshow BUG patch fix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/ --- (Updated July 29, 2014, 3:24 p.m.) Review request for kde-workspace and P

Re: Review Request 118180: slideshow BUG patch fix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/#review63445 --- weird issue when using reviewboard with the chrome. that why t

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash, kinit)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119497/#review63447 --- kdeui/util/kcrash.cpp

Re: Review Request 118180: slideshow BUG patch fix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/ --- (Updated 七月 29, 2014, 3:19 p.m.) Status -- This change has been disc

Re: Review Request 118180: slideshow BUG patch fix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/ --- (Updated 七月 29, 2014, 2:15 p.m.) Review request for kde-workspace and Pla

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

> On Juli 27, 2014, 11:17 vorm., Thomas Lübking wrote: > > drkonqi/gdbhighlighter.cpp, line 74 > > > > > > an abort is not a crash ;-) > > > > If you hit this assert, the looked up (lineNr - 1) is somehow

Re: Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar

> On July 21, 2014, 7:16 a.m., Ian Wadham wrote: > > So where are we leaving this? Any conclusions? Any solutions or further > > patches? > > > > Should we report the inconsistent handling of Native file dialogs as a bug > > on bugs.kde.org (without a patch this time)? > > > > If so, against

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

> On Juli 27, 2014, 11:17 vorm., Thomas Lübking wrote: > > drkonqi/main.cpp, line 111 > > > > > > This can go unconditionally. > > > > Show really only shows the window. > > Becoming active and then

Re: Review Request 114910: Patch for bug 317066 ("systray leaves garbage on the panel when resizing ")

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114910/#review63413 --- this would require some testing before pushing to 4.x, too del

Re: Review Request 118180: slideshow BUG patch fix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/ --- (Updated 七月 29, 2014, 10:05 a.m.) Review request for kde-workspace and Pl

Re: Review Request 118180: slideshow BUG patch fix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/ --- (Updated 七月 29, 2014, 10:04 a.m.) Review request for kde-workspace and Pl

Re: Review Request 118180: slideshow BUG patch fix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/#review63401 --- Reviewboard wasn't showing the patch, not sure why. We can't d

Re: Review Request 118180: slideshow BUG patch fix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/ --- (Updated July 29, 2014, 9:43 a.m.) Status -- This change has been di

Re: Review Request 115727: Deafult for not executing kwalletmanager once a wallet is open

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115727/#review63398 --- What's the status of this. Can we at least merge this in 5.x?

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

> On July 27, 2014, 11:17 a.m., Thomas Lübking wrote: > > drkonqi/gdbhighlighter.cpp, line 74 > > > > > > an abort is not a crash ;-) > > > > If you hit this assert, the looked up (lineNr - 1) is somehow

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

> On July 27, 2014, 1:17 p.m., Thomas Lübking wrote: > > drkonqi/reportassistantpages_bugzilla.cpp, line 286 > > > > > > #ifndef > > Ian Wadham wrote: > No, #ifdef. The lines following 286 apply to Apple OS

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

> On July 27, 2014, 11:17 a.m., Thomas Lübking wrote: > > drkonqi/reportassistantpages_bugzilla.cpp, line 286 > > > > > > #ifndef No, #ifdef. The lines following 286 apply to Apple OS X and nothing else. ATM th

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

> On July 27, 2014, 11:17 a.m., Thomas Lübking wrote: > > drkonqi/main.cpp, line 111 > > > > > > This can go unconditionally. > > > > Show really only shows the window. > > Becoming active and then r

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash, kinit)

> On July 28, 2014, 12:57 a.m., Ian Wadham wrote: > > kinit/kinit.cpp, line 119 > > > > > > The real issue is on this line. I do not know how "MAC_DISPLAY" got > > into the act, but clearly it has not been teste