Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash, kinit)

2014-07-27 Thread Ian Wadham
> On July 27, 2014, 11:32 a.m., Thomas Lübking wrote: > > kinit/kinit.cpp, line 118 > > > > > > this looks fishy, because this should be related to the Window System, > > not the OS (ie. if you're running X11 on

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash, kinit)

2014-07-27 Thread Ian Wadham
> On July 27, 2014, 11:32 a.m., Thomas Lübking wrote: > > kinit/kinit.cpp, line 1478 > > > > > > this and line 1504 look like debug leftovers? or are they needed for > > extra logging? I was using them for dia

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash, kinit)

2014-07-27 Thread Ian Wadham
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119497/#review63291 --- kinit/kinit.cpp

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash, kinit)

2014-07-27 Thread Thomas Lübking
> On Juli 27, 2014, 11:32 vorm., Thomas Lübking wrote: > > kinit/kinit.cpp, line 118 > > > > > > this looks fishy, because this should be related to the Window System, > > not the OS (ie. if you're running X11 o

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash, kinit)

2014-07-27 Thread Ian Wadham
> On July 27, 2014, 11:32 a.m., Thomas Lübking wrote: > > kinit/kinit.cpp, line 118 > > > > > > this looks fishy, because this should be related to the Window System, > > not the OS (ie. if you're running X11 on

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash, kinit)

2014-07-27 Thread RJVB Bertin
> On July 27, 2014, 1:32 p.m., Thomas Lübking wrote: > > kinit/kinit.cpp, line 118 > > > > > > this looks fishy, because this should be related to the Window System, > > not the OS (ie. if you're running X11 on

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash, kinit)

2014-07-27 Thread Thomas Lübking
> On Juli 27, 2014, 11:32 vorm., Thomas Lübking wrote: > > kinit/kinit.cpp, line 118 > > > > > > this looks fishy, because this should be related to the Window System, > > not the OS (ie. if you're running X11 o

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash, kinit)

2014-07-27 Thread RJVB Bertin
> On July 27, 2014, 1:32 p.m., Thomas Lübking wrote: > > kinit/kinit.cpp, line 118 > > > > > > this looks fishy, because this should be related to the Window System, > > not the OS (ie. if you're running X11 on

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash, kinit)

2014-07-27 Thread Thomas Lübking
> On Juli 27, 2014, 11:32 vorm., Thomas Lübking wrote: > > kinit/kinit.cpp, line 118 > > > > > > this looks fishy, because this should be related to the Window System, > > not the OS (ie. if you're running X11 o

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash, kinit)

2014-07-27 Thread RJVB Bertin
> On July 27, 2014, 1:32 p.m., Thomas Lübking wrote: > > kinit/kinit.cpp, line 118 > > > > > > this looks fishy, because this should be related to the Window System, > > not the OS (ie. if you're running X11 on

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash, kinit)

2014-07-27 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119497/#review63257 --- kdeui/util/kcrash.cpp

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

2014-07-27 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119498/#review63254 --- drkonqi/gdbhighlighter.cpp

Re: Review Request 119454: Make FindPyKDE4 work with PyQt's new build system.

2014-07-27 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119454/#review63256 --- Ship it! Looks OK to me. - Luca Beltrame On Lug. 24, 2014,

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

2014-07-27 Thread Ian Wadham
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119498/ --- (Updated July 27, 2014, 9:16 a.m.) Review request for KDE Software on Mac

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash, kinit)

2014-07-27 Thread Ian Wadham
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119497/ --- (Updated July 27, 2014, 9:15 a.m.) Review request for KDE Software on Mac

Re: Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar

2014-07-27 Thread RJVB Bertin
> On July 21, 2014, 7:16 a.m., Ian Wadham wrote: > > So where are we leaving this? Any conclusions? Any solutions or further > > patches? > > > > Should we report the inconsistent handling of Native file dialogs as a bug > > on bugs.kde.org (without a patch this time)? > > > > If so, against

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1)

2014-07-27 Thread RJVB Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119497/#review63245 --- Could you develop a bit of what you currently know about the p

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2)

2014-07-27 Thread Rolf Eike Beer
> In this review we have three portability problems: > > 1. On Apple OS X, Dr Konqi's dialog box hides itself underneath the main > window of the app that has just crashed, so is effectively useless. This > appears to be because Dr Konqi is started by a Linux/Unix method (fork() + > exec()?). If a