Review Request 119393: Offline cores segmentation fault fix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119393/ --- Review request for kde-workspace. Repository: ksysguard Description ---

Re: Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar

> On July 21, 2014, 5:16 a.m., Ian Wadham wrote: > > So where are we leaving this? Any conclusions? Any solutions or further > > patches? > > > > Should we report the inconsistent handling of Native file dialogs as a bug > > on bugs.kde.org (without a patch this time)? > > > > If so, against

Re: Review Request 118994: make CTRL+SHIFT+T reopen last closed tab

> On July 20, 2014, 9:56 p.m., Frank Reininghaus wrote: > > Thank you very much for working on this, Arjun, and thanks also for your > > very good suggestions, Emmanuel! > > > > I apologize for not responding earlier. I was a bit busy at work recently > > and did not really find the time to ch

Re: KDE Applications December 2014 release: which apps are targeting Qt4/Qt5?

Hi, 2014-07-21 23:34 GMT+02:00 Albert Astals Cid: > El Dilluns, 21 de juliol de 2014, a les 13:26:32, Frank Reininghaus va > escriure: >> Hello everyone, >> >> after KDE SC 4.14, the next release of the KDE applications that are >> part of the KDE SC is planned for December. It will contain not on

Re: KDE Applications December 2014 release: which apps are targeting Qt4/Qt5?

El Dilluns, 21 de juliol de 2014, a les 13:26:32, Frank Reininghaus va escriure: > Hello everyone, > > after KDE SC 4.14, the next release of the KDE applications that are > part of the KDE SC is planned for December. It will contain not only > applications that are still based on Qt4+kdelibs 4.x

Re: Review Request 119372: Fix Bug 337486 - Should not permit moving of read-only folder to a different directory

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119372/#review62821 --- lib/konq/konq_operations.cpp

Re: Review Request 118180: slideshow BUG patch fix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/#review62810 --- seems the patch doesn't apply anymore, at least reviewboard co

Re: Review Request 119372: Fix Bug 337486 - Should not permit moving of read-only folder to a different directory

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119372/ --- (Updated July 21, 2014, 7:42 p.m.) Review request for KDE Base Apps. Bu

Re: Review Request 118180: slideshow BUG patch fix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/ --- (Updated 七月 21, 2014, 1:12 p.m.) Review request for kde-workspace and Pla

Re: Review Request 118180: slideshow BUG patch fix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/#review62784 --- modulo the indentation, it should be ok - Marco Martin On G

Re: Review Request 118180: slideshow BUG patch fix

> On 七月 21, 2014, 12:39 p.m., Martin Gräßlin wrote: > > > > TOM Harrison wrote: > what kind of issue? tab and space different ? > > Sebastian Kügler wrote: > Yes, don't use tabs at all for code indentation, use 4 spaces. It should > look consistent with the surrounding code after that.

Re: Review Request 118180: slideshow BUG patch fix

> On July 21, 2014, 12:39 p.m., Martin Gräßlin wrote: > > > > TOM Harrison wrote: > what kind of issue? tab and space different ? Yes, don't use tabs at all for code indentation, use 4 spaces. It should look consistent with the surrounding code after that. - Sebastian -

Re: Review Request 118180: slideshow BUG patch fix

> On 七月 21, 2014, 12:39 p.m., Martin Gräßlin wrote: > > what kind of issue? tab and space different ? - TOM --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/#review62779 --

Re: Review Request 118180: slideshow BUG patch fix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/#review62779 --- libs/plasmagenericshell/backgrounddialog.cpp

Re: Review Request 118180: slideshow BUG patch fix

> On 六月 5, 2014, 10:12 a.m., Christoph Feck wrote: > > Please add Plasma developers to the group of reviewers. > > > > Btw, you cannot give "Ship It" to yourself, others have to approve it. > > TOM Harrison wrote: > that just a wrong click :) > > TOM Harrison wrote: > thanks for remind

Re: Review Request 118180: slideshow BUG patch fix

> On June 5, 2014, 10:12 a.m., Christoph Feck wrote: > > Please add Plasma developers to the group of reviewers. > > > > Btw, you cannot give "Ship It" to yourself, others have to approve it. > > TOM Harrison wrote: > that just a wrong click :) > > TOM Harrison wrote: > thanks for remi

Re: Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar

> On Juli 21, 2014, 5:16 vorm., Ian Wadham wrote: > > So where are we leaving this? Any conclusions? Any solutions or further > > patches? > > > > Should we report the inconsistent handling of Native file dialogs as a bug > > on bugs.kde.org (without a patch this time)? > > > > If so, against

KDE Applications December 2014 release: which apps are targeting Qt4/Qt5?

Hello everyone, after KDE SC 4.14, the next release of the KDE applications that are part of the KDE SC is planned for December. It will contain not only applications that are still based on Qt4+kdelibs 4.x, but also applications that have the first stable release of their Qt5+KF5 ports [1]. All a

Re: Review Request 119372: Fix Bug 337486 - Should not permit moving of read-only folder to a different directory

> On Juli 20, 2014, 9:21 vorm., Thomas Lübking wrote: > > lib/konq/konq_operations.cpp, line 479 > > > > > > is there any guarantee that all urls in lst are in the same directory? > > Arjun Ak wrote: > what?

Re: Review Request 118994: make CTRL+SHIFT+T reopen last closed tab

> On July 21, 2014, 3:26 a.m., Frank Reininghaus wrote: > > Thank you very much for working on this, Arjun, and thanks also for your > > very good suggestions, Emmanuel! > > > > I apologize for not responding earlier. I was a bit busy at work recently > > and did not really find the time to ch

Re: Review Request 119372: Fix Bug 337486 - Should not permit moving of read-only folder to a different directory

> On July 20, 2014, 2:51 p.m., Thomas Lübking wrote: > > lib/konq/konq_operations.cpp, line 473 > > > > > > this belongs into the ::supportsDeleting() branch ok > On July 20, 2014, 2:51 p.m., Thomas Lübking wr