Re: Review Request 119302: Make FindPyQt4 work with PyQt's new build system.

> On July 16, 2014, 1:42 a.m., Scott Kitterman wrote: > > This is the method used in qscintilla2's configure.py (which upstream has > > generally endorsed): > > > > #! /usr/bin/python > > > > import sys > > import os > > > > if sys.platform == 'win32': > > data_dir = sys.prefix > > else:

Re: Review Request 119221: Don't rewrite mailto: URLs als mailto://

> On July 15, 2014, 1:31 p.m., David Faure wrote: > > kdecore/io/kurl.cpp, line 1100 > > > > > > This comparison should be case insensitive, see > > (QString::compare(scheme(), QLatin1String("mailto"), Qt::Case

Re: Review Request 119221: Don't rewrite mailto: URLs als mailto://

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119221/ --- (Updated July 16, 2014, 9:40 p.m.) Status -- This change has been ma

Re: Review Request 119302: Make FindPyQt4 work with PyQt's new build system.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119302/ --- (Updated July 16, 2014, 7:49 p.m.) Status -- This change has been ma

Re: Review Request 119302: Make FindPyQt4 work with PyQt's new build system.

> On Lug. 16, 2014, 1:39 p.m., Raphael Kubo da Costa wrote: > > I guess it's important to note that PyKDE is still broken with this change > > -- it also assumes `pyqtconfig.py` exists. Fixing it is probably going to > > be more difficult. I will try to look at it, but I can't guarantee I'll d

Re: Review Request 118947: KJS: treat specified time correctly as localtime when passed to the Date() constructor

> On Juli 16, 2014, 2:27 nachm., Nicolás Alvarez wrote: > > Was this forward-ported to khtml frameworks? No, it was forward-ported to kjs framework, kjs is not a part of khtml - Bernd --- This is an automatically generated e-mail. To re

Re: Review Request 118947: KJS: treat specified time correctly as localtime when passed to the Date() constructor

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118947/#review62512 --- Was this forward-ported to khtml frameworks? - Nicolás Alvare

Re: Review Request 119302: Make FindPyQt4 work with PyQt's new build system.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119302/#review62509 --- I guess it's important to note that PyKDE is still broken with

Re: Review Request 119302: Make FindPyQt4 work with PyQt's new build system.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119302/#review62505 --- Ship it! Ship It! - Luca Beltrame On Lug. 16, 2014, 1:21 p

Re: Review Request 119302: Make FindPyQt4 work with PyQt's new build system.

> On July 16, 2014, 4:42 a.m., Scott Kitterman wrote: > > This is the method used in qscintilla2's configure.py (which upstream has > > generally endorsed): > > > > #! /usr/bin/python > > > > import sys > > import os > > > > if sys.platform == 'win32': > > data_dir = sys.prefix > > else:

Re: Review Request 119302: Make FindPyQt4 work with PyQt's new build system.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119302/ --- (Updated July 16, 2014, 4:21 p.m.) Review request for kdelibs, Alex Merry

Re: Review Request 108328: fix 234407 - set minimum width for system settings icon view

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/108328/#review62497 --- Do we have any movement on fixing the arbitrary value issue ra

Re: Review Request 119302: Make FindPyQt4 work with PyQt's new build system.

> On July 16, 2014, 1:42 a.m., Scott Kitterman wrote: > > This is the method used in qscintilla2's configure.py (which upstream has > > generally endorsed): > > > > #! /usr/bin/python > > > > import sys > > import os > > > > if sys.platform == 'win32': > > data_dir = sys.prefix > > else:

Re: Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar

On July 12, 2014, 2:11 p.m., Marko Käning wrote: > > Other than that it looks ok. Please update the patch though. > > Ian Wadham wrote: > I have tested the patch on Apple OS X in my kdesrc-build environment for > KDE 4.13 branch. Before I did so, I removed the comment from line 316 and > a

Re: Review Request 119302: Make FindPyQt4 work with PyQt's new build system.

> On July 16, 2014, 4:42 a.m., Scott Kitterman wrote: > > This is the method used in qscintilla2's configure.py (which upstream has > > generally endorsed): > > > > #! /usr/bin/python > > > > import sys > > import os > > > > if sys.platform == 'win32': > > data_dir = sys.prefix > > else:

Re: Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar

> On July 12, 2014, 10:08 a.m., Marko Käning wrote: > > > > Ian Wadham wrote: > It seems to me there should be a config item > UnifiedTitleAndToolBarOnMac=true (or false) in some KDE file somewhere. But > what is that file's name and where is it usually located in the Linux/KDE > directo

Re: Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar

> On July 12, 2014, 10:08 a.m., Marko Käning wrote: > > kdeui/widgets/kmainwindow.cpp, line 244 > > > > > > Actually, I don't know whether I want this integration as default... > > Ian Wadham wrote: > I have

Re: Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar

> On July 12, 2014, 2:11 p.m., Aleix Pol Gonzalez wrote: > > kio/kfile/kfiledialog.cpp, line 316 > > > > > > I don't know why you did that, but it doesn't look good. > > Marko Käning wrote: > Actually, when

Re: Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar

> On July 12, 2014, 10:08 a.m., Marko Käning wrote: > > > > Ian Wadham wrote: > It seems to me there should be a config item > UnifiedTitleAndToolBarOnMac=true (or false) in some KDE file somewhere. But > what is that file's name and where is it usually located in the Linux/KDE > directo

Re: Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar

> On July 12, 2014, 10:08 a.m., Marko Käning wrote: > > > > Ian Wadham wrote: > It seems to me there should be a config item > UnifiedTitleAndToolBarOnMac=true (or false) in some KDE file somewhere. But > what is that file's name and where is it usually located in the Linux/KDE > directo