Re: Review Request 119302: Make FindPyQt4 work with PyQt's new build system.

> On Lug. 16, 2014, 1:42 a.m., Scott Kitterman wrote: > > This is the method used in qscintilla2's configure.py (which upstream has > > generally endorsed): > > > > #! /usr/bin/python > > > > import sys > > import os > > > > if sys.platform == 'win32': > > data_dir = sys.prefix > > else:

Re: Review Request 119302: Make FindPyQt4 work with PyQt's new build system.

> On July 16, 2014, 1:42 a.m., Scott Kitterman wrote: > > This is the method used in qscintilla2's configure.py (which upstream has > > generally endorsed): > > > > #! /usr/bin/python > > > > import sys > > import os > > > > if sys.platform == 'win32': > > data_dir = sys.prefix > > else:

Re: Review Request 119302: Make FindPyQt4 work with PyQt's new build system.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119302/#review62457 --- This is the method used in qscintilla2's configure.py (which u

Re: Review Request 119302: Make FindPyQt4 work with PyQt's new build system.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119302/#review62456 --- I think PYQT4_SIP_DIR can still be determined automatically, b

Re: Review Request 119240: Preventing a crash in the KWindowInfo::Private destructor on OSX

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119240/ --- (Updated July 15, 2014, 11:02 p.m.) Status -- This change has been m

Re: Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar

> On Juli 12, 2014, 2:11 nachm., Aleix Pol Gonzalez wrote: > > kio/kfile/kfiledialog.cpp, line 316 > > > > > > I don't know why you did that, but it doesn't look good. > > Marko Käning wrote: > Actually, whe

Re: Review Request 119302: Make FindPyQt4 work with PyQt's new build system.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119302/#review62435 --- Ship it! +1 on my side, but please wait to what the build sys

Re: Review Request 119302: Make FindPyQt4 work with PyQt's new build system.

> On Lug. 15, 2014, 9:28 p.m., Luca Beltrame wrote: > > cmake/modules/FindPyQt.py, line 40 > > > > > > If I understand correctly, configuring without -DPYQT4_SIP_DIR > > specified may cause undefined behavior? >

Re: Review Request 119302: Make FindPyQt4 work with PyQt's new build system.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119302/#review62432 --- cmake/modules/FindPyQt.py

Review Request 119302: Make FindPyQt4 work with PyQt's new build system.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119302/ --- Review request for Build System, KDE Bindings, kdelibs, Alex Merry, Luca B

Re: Review Request 119014: KUrlRequester: fixing handling of start directory

> On Juli 15, 2014, 1:15 vorm., David Faure wrote: > > kio/kfile/kurlrequester.cpp, line 277 > > > > > > The notion of the "current path" in a GUI program (started graphically) > > makes little sense to me, but

Re: Review Request 118994: make CTRL+SHIFT+T reopen last closed tab

> On July 8, 2014, 7:56 p.m., Emmanuel Pescosta wrote: > > Thanks for your work and sorry for the delay! I like it :) > > > > A ship it from my side. (I still prefer "count > 0" over "count", but > > that's more a matter of taste) > > > > Please wait for Frank's ship it. @Frank: ping! - Emm

Re: 4.13.3 tarballs are available for packagers

Sure. First thing tomorrow. /Cheers Torgny Original message From: Albert Astals Cid Date:2014/07/14 19:32 (GMT+01:00) To: Vishesh Handa Cc: kde-de...@kde.org,kde-packager ,KDE release coordination ,kdelibs ,torgny nyblom Subject: Re: 4.13.3 tarballs are available for pa

Re: Review Request 117957: kcm_fonts: correctly restore default configuration values

> On July 9, 2014, 8:26 a.m., Andrea Iacovitti wrote: > > If there are no objections or other suggestions it would be good to have > > the bug fixed in 4.11.11 release :) > > Christoph Feck wrote: > Thanks Andrea. Could you please check if this also affects bug 244857, > bug 325868, or bug

Re: Review Request 119221: Don't rewrite mailto: URLs als mailto://

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119221/#review62400 --- Looks good, apart from the issue below. https://codereview.qt