Re: Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar

2014-07-12 Thread Ian Wadham
> On July 12, 2014, 10:08 a.m., Marko Käning wrote: > > It seems to me there should be a config item UnifiedTitleAndToolBarOnMac=true (or false) in some KDE file somewhere. But what is that file's name and where is it usually located in the Linux/KDE directory trees? And how could a user ge

Re: Review Request 119240: Preventing a crash in the KWindowInfo::Private destructor on OSX

2014-07-12 Thread David Faure
> On July 12, 2014, 6:49 p.m., David Faure wrote: > > Seems clear enough. > > > > In KF5 the file is in frameworks/kwindowsystem/src/kwindowinfo_mac.cpp > > Marko Käning wrote: > Thanks for the info about KF5! > > Which branch should this be committed to on kdelibs4? Simply on mast

Re: Review Request 119240: Preventing a crash in the KWindowInfo::Private destructor on OSX

2014-07-12 Thread Marko Käning
> On July 12, 2014, 8:49 p.m., David Faure wrote: > > Seems clear enough. > > > > In KF5 the file is in frameworks/kwindowsystem/src/kwindowinfo_mac.cpp Thanks for the info about KF5! Which branch should this be committed to on kdelibs4? Simply on master or also on (an)other branch(es)? - M

Re: 4.13.3 tarballs are available for packagers

2014-07-12 Thread Albert Astals Cid
El Dissabte, 12 de juliol de 2014, a les 20:11:35, Vishesh Handa va escriure: > On Sat, Jul 12, 2014 at 5:28 PM, Albert Astals Cid wrote: > > El Dissabte, 12 de juliol de 2014, a les 17:24:30, Albert Astals Cid va > > > > escriure: > > > Note that baloo unit tests are not passing and if it's not

Re: Review Request 119240: Preventing a crash in the KWindowInfo::Private destructor on OSX

2014-07-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119240/#review62201 --- Ship it! Seems clear enough. In KF5 the file is in framework

Re: Review Request 119240: Preventing a crash in the KWindowInfo::Private destructor on OSX

2014-07-12 Thread Marko Käning
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119240/ --- (Updated July 12, 2014, 8:17 p.m.) Review request for kdelibs, David Faur

Re: 4.13.3 tarballs are available for packagers

2014-07-12 Thread Vishesh Handa
On Sat, Jul 12, 2014 at 5:28 PM, Albert Astals Cid wrote: > El Dissabte, 12 de juliol de 2014, a les 17:24:30, Albert Astals Cid va > escriure: > > Note that baloo unit tests are not passing and if it's not fixed (+ > package > > respun) before tuesday it won't be part of the release. > > I mean

Re: Review Request 119240: Preventing a crash in the KWindowInfo::Private destructor on OSX

2014-07-12 Thread Marko Käning
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119240/ --- (Updated July 12, 2014, 7:02 p.m.) Review request for kdelibs, Martin Grä

Re: Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar

2014-07-12 Thread Marko Käning
> On July 12, 2014, 4:11 p.m., Aleix Pol Gonzalez wrote: > > kio/kfile/kfiledialog.cpp, line 316 > > > > > > I don't know why you did that, but it doesn't look good. Actually, when submitting this RR I was also

Re: Review Request 119240: Preventing a crash in the KWindowInfo::Private destructor on OSX

2014-07-12 Thread Marko Käning
> On July 12, 2014, 6:01 p.m., Martin Gräßlin wrote: > > Which branch should that go in? I do not know what is currently a release > > branch. > > > > It should probably also be forward ported to frameworks even if the Mac > > part is currently not compiled (hint: if someone adjusts the code i

Re: Review Request 119240: Preventing a crash in the KWindowInfo::Private destructor on OSX

2014-07-12 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119240/#review62192 --- Which branch should that go in? I do not know what is currentl

Re: 4.13.3 tarballs are available for packagers

2014-07-12 Thread Albert Astals Cid
El Dissabte, 12 de juliol de 2014, a les 17:24:30, Albert Astals Cid va escriure: > Note that baloo unit tests are not passing and if it's not fixed (+ package > respun) before tuesday it won't be part of the release. I mean http://build.kde.org/view/KDE%20SC%20stable/job/baloo_stable/ is not gr

Re: 4.13.3 tarballs are available for packagers

2014-07-12 Thread Albert Astals Cid
Note that baloo unit tests are not passing and if it's not fixed (+ package respun) before tuesday it won't be part of the release. Cheers, Albert El Divendres, 11 de juliol de 2014, a les 20:40:05, Torgny Nyblom va escriure: > Hi, > > tarballs for KDE SC 4.13.3 and kde-workspace 4.11.11 are

Re: Review Request 119240: Preventing a crash in the KWindowInfo::Private destructor on OSX

2014-07-12 Thread Marko Käning
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119240/ --- (Updated July 12, 2014, 4:22 p.m.) Review request for kdelibs, Martin Grä

Re: Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar

2014-07-12 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119243/#review62184 --- kio/kfile/kfiledialog.cpp

Re: Review Request 119025: Actually pass IBUS_DEFINITIONS when compiling ibus-panel

2014-07-12 Thread Vadim Zhukov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119025/ --- (Updated Июль 12, 2014, 5:12 п.п.) Review request for kde-workspace, Plas

Re: Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar

2014-07-12 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119243/#review62175 --- Just out of curiosity, but why would KIO need to know the plat

Re: Review Request 119240: Preventing a crash in the KWindowInfo::Private destructor on OSX

2014-07-12 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119240/#review62173 --- The patch is valid. My only question in this context would be

Re: Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar

2014-07-12 Thread Marko Käning
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119243/#review62168 --- kdeui/widgets/kmainwindow.cpp

Re: Downtime notification

2014-07-12 Thread Víctor Blázquez
Hi, The server has been migrated and bugs.kde.org is now up and running. Maybe you could find it not available for a short time until DNS gets updated. Thanks, Víctor Blázquez Víctor Blázquez On Thu, Jul 10, 2014 at 11:39 PM, Ben Cooksley wrote: > Hi all, > > To allow for a server move and s

Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar

2014-07-12 Thread Marko Käning
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119243/ --- Review request for kdelibs, Christoph Feck and Ian Wadham. Bugs: 337356

Review Request 119240: Preventing a crash in the KWindowInfo::Private destructor on OSX

2014-07-12 Thread Marko Käning
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119240/ --- Review request for kdelibs, Martin Gräßlin, Ian Wadham, and Thomas Lübking.