Re: Oxygen Fonts kdereview remove

2014-07-09 Thread Albert Astals Cid
El Dijous, 3 de juliol de 2014, a les 15:26:41, Jonathan Riddell va escriure: > Plasma 5 is going to default on Oxygen Fonts so we need Oxygen Fonts to move > to kde/workspace. > > It's currently in kdereview and I am using the release-0.4 branch. > > Please have a look and review. I could if i

Re: QDialog on stack+exec and dbus quit crash is no more

2014-07-09 Thread Albert Astals Cid
El Dimecres, 9 de juliol de 2014, a les 10:58:50, David Faure va escriure: > On Thursday 12 December 2013 20:01:42 Albert Astals Cid wrote: > > El Dijous, 12 de desembre de 2013, a les 19:57:25, David Faure va escriure: > > > On Monday 11 November 2013 21:04:35 Jan Kundrát wrote: > > > > On Monday

Re: Review Request 117957: kcm_fonts: correctly restore default configuration values

2014-07-09 Thread Andrea Iacovitti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117957/ --- (Updated July 9, 2014, 7:39 p.m.) Status -- This change has been mar

Re: code guideline

2014-07-09 Thread Thiago Macieira
On Saturday 28 June 2014 08:51:42 Rodrigo Bonifacio wrote: > Dear all, is there any code guideline that recommends developers to avoid > the use of exception handling mechanisms within the core libraries of KDE? I'm going to let others speak about the use of exceptions in your own code, but note

Re: Review Request 119025: Actually pass IBUS_DEFINITIONS when compiling ibus-panel

2014-07-09 Thread Vadim Zhukov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119025/ --- (Updated Июль 9, 2014, 7:52 п.п.) Review request for kde-workspace and Pl

Re: Review Request 117957: kcm_fonts: correctly restore default configuration values

2014-07-09 Thread Andrea Iacovitti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117957/ --- (Updated Lug. 9, 2014, 1:06 p.m.) Review request for kde-workspace. Cha

Re: KF5 Update Meeting Minutes 2014-w28

2014-07-09 Thread John Layt
On 9 July 2014 06:14, Kevin Ottens wrote: > Hello, > > On Wednesday 09 July 2014 09:57:27 Ben Cooksley wrote: >> On 9 July 2014 03:30, Kevin Ottens wrote: >> > * ervin hopes to see kdepimlibs bits getting in sooner rather than later; >> >> Hmm? Sysadmin has already received a request to get the

Re: QDialog on stack+exec and dbus quit crash is no more

2014-07-09 Thread Milian Wolff
On Wednesday 09 July 2014 10:58:50 David Faure wrote: > On Thursday 12 December 2013 20:01:42 Albert Astals Cid wrote: > > El Dijous, 12 de desembre de 2013, a les 19:57:25, David Faure va escriure: > > > On Monday 11 November 2013 21:04:35 Jan Kundrát wrote: > > > > On Monday, 11 November 2013 19

Re: QDialog on stack+exec and dbus quit crash is no more

2014-07-09 Thread David Faure
On Thursday 12 December 2013 20:01:42 Albert Astals Cid wrote: > El Dijous, 12 de desembre de 2013, a les 19:57:25, David Faure va escriure: > > On Monday 11 November 2013 21:04:35 Jan Kundrát wrote: > > > On Monday, 11 November 2013 19:17:22 CEST, Albert Astals Cid wrote: > > > > Not sure you're u

Re: Review Request 114484: Fix KMainWindow size management, esp. on asymmetric multiscreens

2014-07-09 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114484/#review61957 --- I cringe at the negative-values hack, please make it an extra

Re: Review Request 117957: kcm_fonts: correctly restore default configuration values

2014-07-09 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117957/#review61956 --- Ship it! kcontrol/fonts/fonts.cpp

Re: code guideline

2014-07-09 Thread David Faure
On Wednesday 09 July 2014 10:23:59 Kevin Ottens wrote: > On Wednesday 09 July 2014 10:15:03 David Faure wrote: > > On Saturday 28 June 2014 08:51:42 Rodrigo Bonifacio wrote: > > > Dear all, is there any code guideline that recommends developers to > > > avoid > > > the use of exception handling mec

Re: Review Request 119014: KUrlRequester: fixing handling of start directory

2014-07-09 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119014/#review61955 --- Looks good, but I'd feel safer if the unittest (kio/tests/kur

Re: Re: code guideline

2014-07-09 Thread Martin Gräßlin
On Wednesday 09 July 2014 10:23:59 Kevin Ottens wrote: > On Wednesday 09 July 2014 10:15:03 David Faure wrote: > > On Saturday 28 June 2014 08:51:42 Rodrigo Bonifacio wrote: > > > Dear all, is there any code guideline that recommends developers to > > > avoid > > > the use of exception handling mec

Re: Review Request 117957: kcm_fonts: correctly restore default configuration values

2014-07-09 Thread Andrea Iacovitti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117957/#review61954 --- If there are no objections or other suggestions it would be go

Re: code guideline

2014-07-09 Thread Kevin Ottens
On Wednesday 09 July 2014 10:15:03 David Faure wrote: > On Saturday 28 June 2014 08:51:42 Rodrigo Bonifacio wrote: > > Dear all, is there any code guideline that recommends developers to avoid > > the use of exception handling mechanisms within the core libraries of KDE? > > I don't think it's wri

Re: code guideline

2014-07-09 Thread David Faure
On Saturday 28 June 2014 08:51:42 Rodrigo Bonifacio wrote: > Dear all, is there any code guideline that recommends developers to avoid > the use of exception handling mechanisms within the core libraries of KDE? I don't think it's written down anywhere, but yes, please do avoid the use of excepti