Re: Review Request 119130: Fix template discovery in KNewFileMenu (incorrect port to QStandardPaths)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119130/ --- (Updated July 5, 2014, 6:54 p.m.) Status -- This change has been mar

Re: Review Request 119130: Fix template discovery in KNewFileMenu (incorrect port to QStandardPaths)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119130/#review61661 --- Ship it! Well spotted, and sorry for the copy/paste error dur

Re: Review Request 119130: Fix template discovery in KNewFileMenu (incorrect port to QStandardPaths)

> On July 5, 2014, 1:51 p.m., Mark Gaiser wrote: > > Last question, could you make a unittest for this? > > > > I'm not quite sure if it's even possible since this is in a private class. > > You might be able to test this using KNewFileMenu::checkUpToDate? > > KIO has very few unittests for KNe

Re: Review Request 119130: Fix template discovery in KNewFileMenu (incorrect port to QStandardPaths)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119130/#review61649 --- Last question, could you make a unittest for this? I'm not qu

Re: Review Request 119130: Fix template discovery in KNewFileMenu (incorrect port to QStandardPaths)

> On jul 5, 2014, 1:11 p.m., Mark Gaiser wrote: > > src/filewidgets/knewfilemenu.cpp, lines 875-878 > > > > > > You should be able to replace this with: > > files.append(dir.entryList(QStringList() << "*.desk

Re: Review Request 119130: Fix template discovery in KNewFileMenu (incorrect port to QStandardPaths)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119130/ --- (Updated July 5, 2014, 1:26 p.m.) Review request for kdelibs and David Fa

Re: Review Request 119130: Fix template discovery in KNewFileMenu (incorrect port to QStandardPaths)

> On July 5, 2014, 1:11 p.m., Mark Gaiser wrote: > > src/filewidgets/knewfilemenu.cpp, line 874 > > > > > > There is no need for this check since QStandardPaths::locateAll only > > returns paths that exist: > >

Re: Review Request 119130: Fix template discovery in KNewFileMenu (incorrect port to QStandardPaths)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119130/#review61646 --- src/filewidgets/knewfilemenu.cpp

Review Request 119130: Fix template discovery in KNewFileMenu (incorrect port to QStandardPaths)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119130/ --- Review request for kdelibs and David Faure. Repository: kio Description

Re: Review Request 118994: make CTRL+SHIFT+T reopen last closed tab

> On July 5, 2014, 2:15 p.m., Emmanuel Pescosta wrote: > > Arjun, thanks for the updated patch! > > > > Great so far, but looking at the code again, we should add a signal e.g. > > "closedTabsCountChanged(int)" to DolphinRecentTabsMenu and react on this > > signal in the main window. > > > >

Re: Review Request 118994: make CTRL+SHIFT+T reopen last closed tab

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118994/#review61644 --- Arjun, thanks for the updated patch! Great so far, but lookin

Re: Review Request 118994: make CTRL+SHIFT+T reopen last closed tab

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118994/#review61642 --- dolphin/src/dolphinrecenttabsmenu.cpp

Re: Review Request 118994: make CTRL+SHIFT+T reopen last closed tab

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118994/ --- (Updated July 5, 2014, 4:49 p.m.) Review request for Dolphin and KDE Base

Re: Review Request 118994: make CTRL+SHIFT+T reopen last closed tab

> On July 2, 2014, 11:30 p.m., Emmanuel Pescosta wrote: > > dolphin/src/dolphinmainwindow.cpp, lines 1136-1138 > > > > > > Why? > > > > This case should not happen, please add a Q_ASSERT instead It wou

Re: Review Request 118994: make CTRL+SHIFT+T reopen last closed tab

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118994/ --- (Updated July 5, 2014, 4:45 p.m.) Review request for Dolphin and KDE Base