Re: Review Request 119088: powerdevil - don't leak job pointer in brightness control

2014-07-02 Thread Mark Gaiser
> On July 2, 2014, 6:06 p.m., Mark Gaiser wrote: > > May i suggest to replace those new lines with a QScopedPointer > > (documentation for it: http://qt-project.org/doc/qt-5/qscopedpointer.html) > > objects? It kinda takes away the need for you to delete since it will > > simply run out of sco

Re: Review Request 119088: powerdevil - don't leak job pointer in brightness control

2014-07-02 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119088/#review61505 --- May i suggest to replace those new lines with a QScopedPointer

Re: Review Request 119088: powerdevil - don't leak job pointer in brightness control

2014-07-02 Thread Martin Bříza
> On July 2, 2014, 5:55 p.m., Lamarque Souza wrote: > > powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp, line 401 > > > > > > A line with 'delete job' before this return is missing here. > > Emmanu

Re: Review Request 119088: powerdevil - don't leak job pointer in brightness control

2014-07-02 Thread Emmanuel Pescosta
> On July 2, 2014, 7:55 p.m., Lamarque Souza wrote: > > powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp, line 401 > > > > > > A line with 'delete job' before this return is missing here. > > Martin

Re: Review Request 119088: powerdevil - don't leak job pointer in brightness control

2014-07-02 Thread Martin Bříza
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119088/ --- (Updated July 2, 2014, 6:02 p.m.) Review request for kde-workspace. Rep

Re: Review Request 118994: make CTRL+SHIFT+T reopen last closed tab

2014-07-02 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118994/#review61502 --- dolphin/src/dolphinmainwindow.h

Re: Review Request 119088: powerdevil - don't leak job pointer in brightness control

2014-07-02 Thread Lamarque Souza
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119088/#review61501 --- powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp

Review Request 119088: powerdevil - don't leak job pointer in brightness control

2014-07-02 Thread Martin Bříza
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119088/ --- Review request for kde-workspace. Repository: kde-workspace Description

Re: Review Request 118994: make CTRL+SHIFT+T reopen last closed tab

2014-07-02 Thread Arjun Ak
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118994/ --- (Updated July 2, 2014, 7:29 p.m.) Review request for Dolphin and KDE Base

Re: KDE

2014-07-02 Thread Marco Martin
On Wednesday 02 July 2014, Ben Cooksley wrote: > SVN commit 1392026 by bcooksley: > > Create new plasma-workspace-wallpapers module. > As requested by Marco Martin in sysadmin ticket #996. > CCMAIL: notm...@gmail.com > CCMAIL: kde-core-devel@kde.org > > A plasma-workspace-wallpapers