Review Request 119020: Forward port fix for 142957 to kio in frameworks

2014-06-29 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119020/ --- Review request for kdelibs and David Faure. Bugs: 142957 https://bugs

Review Request 119021: Forward port fix for 142957 to kinit in frameworks

2014-06-29 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119021/ --- Review request for kdelibs and David Faure. Repository: kinit Descripti

Re: Review Request 118858: Fix crashes in KUrlNavigator that are caused by accesses to objects which have been deleted in nested event loops

2014-06-29 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118858/#review61209 --- This review has been submitted with commit f1196e8e9a94993e4d

Re: Review Request 118858: Fix crashes in KUrlNavigator that are caused by accesses to objects which have been deleted in nested event loops

2014-06-29 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118858/ --- (Updated June 29, 2014, 7:09 p.m.) Status -- This change has been ma

Re: Review Request 118994: make CTRL+SHIFT+T reopen last closed tab

2014-06-29 Thread Frank Reininghaus
> On June 29, 2014, 2:50 p.m., Emmanuel Pescosta wrote: > > Thanks for the patch! > > > > I really like the idea to implement CTRL+SHIFT+T to reopen the previously > > closed tab, makes Dolphin more browser like :) > > > > But please implement this feature in master, because: > > 1. Dolphins f

code guideline

2014-06-29 Thread Rodrigo Bonifacio
Dear all, is there any code guideline that recommends developers to avoid the use of exception handling mechanisms within the core libraries of KDE? All the best, Rodrigo.

Re: Review Request 118954: Set directory to current working directory when executing "Open With..." dialog

2014-06-29 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118954/#review61186 --- This review has been submitted with commit 89d4585c087daf9bdc

Re: Review Request 118954: Set directory to current working directory when executing "Open With..." dialog

2014-06-29 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118954/ --- (Updated June 29, 2014, 4:06 p.m.) Status -- This change has been ma

Review Request 119014: KUrlRequester: fixing handling of start directory

2014-06-29 Thread Simon Bachmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119014/ --- Review request for kdelibs. Bugs: 92237 http://bugs.kde.org/show_bug.

Re: Review Request 118994: make CTRL+SHIFT+T reopen last closed tab

2014-06-29 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118994/#review61179 --- Thanks for the patch! I really like the idea to implement CTR

Re: Review Request 118954: Set directory to current working directory when executing "Open With..." dialog

2014-06-29 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118954/#review61177 --- Ship it! Thanks. kinit/klauncher.cpp