Re: Bug 92237: patch submitted, but... is anyone watching?

2014-06-26 Thread Simon Bachmann
On 24.06.2014 11:10, Frank Reininghaus wrote: Hi, 2014-06-22 13:04 GMT+02:00 Simon Bachmann: May I draw your attention to bug 92237? (https://bugs.kde.org/show_bug.cgi?id=92237) No, this is not a please-get-this-issue-fixed-ASAP kind of message. It's just that I submitted a patch to that bug a

Re: Review Request 118947: KJS: treat specified time correctly as localtime when passed to the Date() constructor

2014-06-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118947/#review61020 --- This review has been submitted with commit 198c1819e382aed93a

Re: Review Request 118947: KJS: treat specified time correctly as localtime when passed to the Date() constructor

2014-06-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118947/#review61019 --- This review has been submitted with commit 786e0a7821f195c5a2

Review Request 118954: Set directory to current working directory when executing "Open With..." dialog

2014-06-26 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118954/ --- Review request for kdelibs and David Faure. Bugs: 142597 http://bugs.

Re: Review Request 118947: KJS: treat specified time correctly as localtime when passed to the Date() constructor

2014-06-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118947/#review61018 --- This review has been submitted with commit 0137c691cfe02e6fc0

Re: Review Request 118947: KJS: treat specified time correctly as localtime when passed to the Date() constructor

2014-06-26 Thread Wolfgang Bauer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118947/ --- (Updated June 26, 2014, 12:03 p.m.) Status -- This change has been m

Re: Review Request 118763: Remove find_package(XCB) call as it is handled already by the top-level cmake file

2014-06-26 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118763/#review61017 --- Ship it! Ship It! - Hugo Pereira Da Costa On June 16, 2014

Re: Review Request 118763: Remove find_package(XCB) call as it is handled already by the top-level cmake file

2014-06-26 Thread Hugo Pereira Da Costa
> On June 16, 2014, 6:57 a.m., Martin Gräßlin wrote: > > looks good to me, +1. Please add Hugo Pereira Da Costa to the Review > > Request, though. > > > > The review request made me wonder whether we still need to find XLib in > > Oxygen, though. The parts shown only use XCB, so maybe we could

Re: Review Request 118947: KJS: treat specified time correctly as localtime when passed to the Date() constructor

2014-06-26 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118947/#review61013 --- Ship it! Good catch! Bug by me, I passed the correct utc valu

Review Request 118947: KJS: treat specified time correctly as localtime when passed to the Date() constructor

2014-06-26 Thread Wolfgang Bauer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118947/ --- Review request for kdelibs. Bugs: 335556 http://bugs.kde.org/show_bug