Re: Review Request 118898: KGamma: Apply user setting at login/startup

2014-06-23 Thread Christoph Feck
> On June 23, 2014, 10:41 p.m., Christoph Feck wrote: > > Not sure why you added Marcel to the list of reviewers... > > > > Anyway, if the current patch is all that is needed to restore sanity as in > > KDE 3, the I am all for getting it fixed. (And if the same issue was the cause for the KRan

Re: Review Request 118898: KGamma: Apply user setting at login/startup

2014-06-23 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118898/#review60866 --- Not sure why you added Marcel to the list of reviewers... Any

Re: Review Request 118898: KGamma: Apply user setting at login/startup

2014-06-23 Thread Wolfgang Bauer
> On June 23, 2014, 5:13 p.m., Martin Gräßlin wrote: > > kcmkgamma/init_kgamma.cpp, line 39 > > > > > > why delete config? I would just use a KSharedConfig::openConfig > > Wolfgang Bauer wrote: > I just copy/

Re: Review Request 118898: KGamma: Apply user setting at login/startup

2014-06-23 Thread Martin Gräßlin
> On June 23, 2014, 5:13 p.m., Martin Gräßlin wrote: > > kcmkgamma/init_kgamma.cpp, line 39 > > > > > > why delete config? I would just use a KSharedConfig::openConfig > > Wolfgang Bauer wrote: > I just copy/

Re: Review Request 118898: KGamma: Apply user setting at login/startup

2014-06-23 Thread Wolfgang Bauer
> On June 23, 2014, 5:13 p.m., Martin Gräßlin wrote: > > kcmkgamma/init_kgamma.cpp, lines 1-8 > > > > > > please use a copyright header as in > > http://techbase.kde.org/Policies/Licensing_Policy#GPL_Header I jus

Re: Review Request 118898: KGamma: Apply user setting at login/startup

2014-06-23 Thread Wolfgang Bauer
> On June 23, 2014, 3:21 p.m., Sebastian Kügler wrote: > > I think there's a couple of problems with this approach: > > > > - This slows down startup for everybody, not just those who changed the > > setting. I'm not super-familiar with this, but isn't kcminit for this > > use-case? > > - Chan

Re: Review Request 118898: KGamma: Apply user setting at login/startup

2014-06-23 Thread Wolfgang Bauer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118898/ --- (Updated June 23, 2014, 7:01 p.m.) Review request for kde-workspace, Plas

Move of SymbolEditor to Extragear/Graphics

2014-06-23 Thread Steve Allewell
Hi all The SymbolEditor application has been in review for a few weeks now. Albert identified a few minor issues that have now been fixed. If there is no more feedback, I would like to request SymbolEditor is moved to Extragear/Graphics. I'll submit a ticket in a couple of days but if anyon

Move of KXStitch to Extragear/Graphics

2014-06-23 Thread Steve Allewell
Hi all The KXStitch application has been in review for a few weeks now. Albert identified a few minor issues that have now been fixed. If there is no more feedback, I would like to request KXStitch is moved to Extragear/Graphics. I'll submit a ticket in a couple of days but if anyone would

Re: Review Request 118898: KGamma: Apply user setting at login/startup

2014-06-23 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118898/#review60809 --- kcmkgamma/init_kgamma.cpp

Re: Review Request 118898: KGamma: Apply user setting at login/startup

2014-06-23 Thread Wolfgang Bauer
> On June 23, 2014, 3:21 p.m., Sebastian Kügler wrote: > > I think there's a couple of problems with this approach: > > > > - This slows down startup for everybody, not just those who changed the > > setting. I'm not super-familiar with this, but isn't kcminit for this > > use-case? > > - Chan

Re: Review Request 118898: KGamma: Apply user setting at login/startup

2014-06-23 Thread Wolfgang Bauer
> On June 23, 2014, 3:21 p.m., Sebastian Kügler wrote: > > I think there's a couple of problems with this approach: > > > > - This slows down startup for everybody, not just those who changed the > > setting. I'm not super-familiar with this, but isn't kcminit for this > > use-case? > > - Chan

Re: Review Request 118366: Porting keyboard module to Framework5

2014-06-23 Thread shivam makkar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118366/ --- (Updated June 23, 2014, 1:46 p.m.) Review request for kde-workspace, KDE

Re: Review Request 118898: KGamma: Apply user setting at login/startup

2014-06-23 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118898/#review60795 --- I think there's a couple of problems with this approach: - Th

Review Request 118898: KGamma: Apply user setting at login/startup

2014-06-23 Thread Wolfgang Bauer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118898/ --- Review request for kde-workspace, Plasma and Marcel Wiesweg. Bugs: 218668

Re: Review Request 118366: Porting keyboard module to Framework5

2014-06-23 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118366/#review60787 --- Can you please try to generate a proper diff? The one you uplo

Re: Review Request 118851: Kde-baseapps- KF5 replace generic soversion.

2014-06-23 Thread Jonathan Riddell
> On June 23, 2014, 9:16 a.m., Raymond Wooninck wrote: > > Hmm, now we seem to have a strange situation between KDE4 and KF5/PN. > > > > The latest version of libkonq with KDE4 is 5.14.0 (libkonq.so.5.14.0) > > with libkonq.so.5 pointing to it. > > > > With this change libkonq has a lower

Re: Review Request 118851: Kde-baseapps- KF5 replace generic soversion.

2014-06-23 Thread Christoph Feck
> On June 23, 2014, 9:16 a.m., Raymond Wooninck wrote: > > Hmm, now we seem to have a strange situation between KDE4 and KF5/PN. > > > > The latest version of libkonq with KDE4 is 5.14.0 (libkonq.so.5.14.0) > > with libkonq.so.5 pointing to it. > > > > With this change libkonq has a lower

Re: Review Request 118851: Kde-baseapps- KF5 replace generic soversion.

2014-06-23 Thread Raymond Wooninck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118851/#review60757 --- Hmm, now we seem to have a strange situation between KDE4 and