Re: Review Request 118366: Porting keyboard module to Framework5

2014-06-20 Thread shivam makkar
> On June 19, 2014, 11:43 p.m., Aleix Pol Gonzalez wrote: > > kcms/keyboard/flags.cpp, line 21 > > > > > > remove? see the latest revision, apparently the diff is showing all the revisions made to the same file.

Re: Review Request 118366: Porting keyboard module to Framework5

2014-06-20 Thread shivam makkar
> On May 28, 2014, 6:10 a.m., Martin Gräßlin wrote: > > kcms/keyboard/kcmmisc.cpp, lines 77-78 > > > > > > for new connects I would use the new compile time checked syntax. > > shivam makkar wrote: > I tried

Re: Review Request 118366: Porting keyboard module to Framework5

2014-06-20 Thread shivam makkar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118366/ --- (Updated June 20, 2014, 9:24 p.m.) Review request for kde-workspace, KDE

Re: Review Request 118851: Kde-baseapps- KF5 replace generic soversion.

2014-06-20 Thread Scarlett Clark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118851/ --- (Updated June 20, 2014, 1:14 p.m.) Status -- This change has been ma

Re: Kronometer now in KDE Review

2014-06-20 Thread Albert Astals Cid
El Dimecres, 18 de juny de 2014, a les 18:50:12, David Faure va escriure: > On Wednesday 18 June 2014 16:27:43 Elvis Angelaccio wrote: > > Hello, > > in the last two months this thread has not been updated, so I assume that > > the Kronometer UI is ok. > > What is still not clear is whether to move

Re: Review Request 118851: Kde-baseapps- KF5 replace generic soversion.

2014-06-20 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118851/#review60620 --- Ship it! Ship It! - Alex Merry On June 20, 2014, 6:44 p.m.

Re: Review Request 118851: Kde-baseapps- KF5 replace generic soversion.

2014-06-20 Thread Scarlett Clark
> On June 20, 2014, 12:02 p.m., Alex Merry wrote: > > CMakeLists.txt, line 23 > > > > > > But now you'll want to put an actual version number in here (or remove > > the variable use altogether). I removed it all

Re: Review Request 118851: Kde-baseapps- KF5 replace generic soversion.

2014-06-20 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118851/#review60618 --- CMakeLists.txt

Re: Review Request 118851: Kde-baseapps- KF5 replace generic soversion.

2014-06-20 Thread Scarlett Clark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118851/ --- (Updated June 20, 2014, 11:44 a.m.) Review request for Dolphin, KDE Base

Re: Review Request 118851: Kde-baseapps- KF5 replace generic soversion.

2014-06-20 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118851/#review60617 --- CMakeLists.txt

Review Request 118851: Kde-baseapps- KF5 replace generic soversion.

2014-06-20 Thread Scarlett Clark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118851/ --- Review request for Dolphin, KDE Base Apps, Plasma, and Jonathan Riddell.

Re: Review Request 118366: Porting keyboard module to Framework5

2014-06-20 Thread Martin Gräßlin
> On May 28, 2014, 8:10 a.m., Martin Gräßlin wrote: > > kcms/keyboard/kcmmisc.cpp, lines 77-78 > > > > > > for new connects I would use the new compile time checked syntax. > > shivam makkar wrote: > I tried