Re: Review Request 118811: Fix compile with giflib-5.1.0 and upwards.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118811/#review60463 --- Is this patch not going into 4.13 branch? You can no longer co

Re: Review Request 118816: Don't crash konsole when a container destructs

> On June 18, 2014, 4:25 p.m., Kurt Hindenburg wrote: > > If it stops the crashing, go ahead - thanks. It's a bit inconsistent here. I can make it crash in konsole or yakuake by doing split view then exit in one of the splits. and sometimes it crashes still in yakuake when I hit the - button,

Re: Review Request 118816: Don't crash konsole when a container destructs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118816/#review60455 --- Ship it! If it stops the crashing, go ahead - thanks. - Kurt

Re: Kronometer now in KDE Review

Hello, in the last two months this thread has not been updated, so I assume that the Kronometer UI is ok. What is still not clear is whether to move Kronometer in extragear-utils or kdeutils and until this decision is not reached I can't file a sysadmin request to exit from kdereview. At the momen

Re: Review Request 118816: Don't crash konsole when a container destructs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118816/#review60449 --- Note: This is about https://bugs.kde.org/show_bug.cgi?id=33172

Re: Review Request 118816: Don't crash konsole when a container destructs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118816/ --- (Updated June 18, 2014, 9:51 p.m.) Review request for KDE Base Apps and E

Re: Review Request 118816: Don't crash konsole when a container destructs

> On June 18, 2014, 1:52 p.m., Dominik Haumann wrote: > > Still crashes Kate on close or session switch: > > > > #6 0x7f8f1c217d71 in QList::QList (this=0x7fff3f64f950, > > l=...) at /home/dh/kde/kf5/src/qt5/qtbase/src/corelib/tools/qlist.h:733 > > #7 0x7f8f1c2140df in Konsole::ViewCo

Re: Review Request 118816: Don't crash konsole when a container destructs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118816/#review60445 --- Still crashes Kate on close or session switch: #6 0x7f8f

Re: Review Request 118816: Don't crash konsole when a container destructs

> On June 18, 2014, 1:29 p.m., Thomas Lübking wrote: > > src/ViewContainer.cpp, line 763 > > > > > > shouldn't the call to removeViewWidget() just be omitted from > > viewDestroyed(QObject* object) - I assume re

Re: Review Request 118816: Don't crash konsole when a container destructs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118816/#review60442 --- src/ViewContainer.cpp

Re: Review Request 118816: Don't crash konsole when a container destructs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118816/ --- (Updated June 18, 2014, 1:24 p.m.) Review request for KDE Base Apps and E

Re: Review Request 118816: Don't crash konsole when a container destructs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118816/#review60435 --- A similar backtrace appears when closing Kate (KF5) and the em

Re: KXStitch moved to KDE Review

On 16/06/14 22:46, Albert Astals Cid wrote: El Dimarts, 27 de maig de 2014, a les 20:06:13, Steve Allewell va escriure: Greetings The application KXStitch was recently imported to KDE Playground under the KDE Incubator process having previously been hosted on Sourceforge. KXStitch is a cross s

Re: Review Request 118816: Don't crash konsole when a container destructs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118816/#review60430 --- I removed the qDebug() line for testing (wouldn't compile othe

Review Request 118816: Don't crash konsole when a container destructs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118816/ --- Review request for KDE Base Apps and Eike Hein. Repository: konsole Des

Re: Kronometer now in KDE Review

On Wednesday 18 June 2014 16:27:43 Elvis Angelaccio wrote: > Hello, > in the last two months this thread has not been updated, so I assume that > the Kronometer UI is ok. > What is still not clear is whether to move Kronometer in extragear-utils or > kdeutils and until this decision is not reached

Re: Review Request 118586: Optimize KConfigGroup::exists and similar operations.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118586/#review60382 --- This review has been submitted with commit 9a5d6523689067a9cd

Re: Review Request 118586: Optimize KConfigGroup::exists and similar operations.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118586/#review60380 --- This review has been submitted with commit eaffd50adfd7fcbeaf

Re: Review Request 118811: Fix compile with giflib-5.1.0 and upwards.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118811/ --- (Updated June 18, 2014, 11:40 a.m.) Status -- This change has been m

Re: Review Request 118586: Optimize KConfigGroup::exists and similar operations.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118586/ --- (Updated June 18, 2014, 11:40 a.m.) Status -- This change has been m

Re: Review Request 118811: Fix compile with giflib-5.1.0 and upwards.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118811/#review60381 --- This review has been submitted with commit 7c7a47575f1f57b5c0

Re: Review Request 118811: Fix compile with giflib-5.1.0 and upwards.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118811/#review60379 --- Ship it! Ship It! - Martin Tobias Holmedahl Sandsmark On J

Review Request 118811: Fix compile with giflib-5.1.0 and upwards.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118811/ --- Review request for kdelibs, Aleix Pol Gonzalez, Andreas Schwab, David Faure

Re: Review Request 118587: Optimize KConfigIniBackend::parseConfig by reducing allocations.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118587/ --- (Updated June 18, 2014, 11:18 a.m.) Review request for kdelibs, David Fau

Re: Review Request 118587: Optimize KConfigIniBackend::parseConfig by reducing allocations.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118587/ --- (Updated June 18, 2014, 11:15 a.m.) Review request for kdelibs, David Fau