Re: Review Request 118763: Remove find_package(XCB) call as it is handled already by the top-level cmake file

2014-06-15 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118763/#review60162 --- looks good to me, +1. Please add Hugo Pereira Da Costa to the

Re: Review Request 118749: Prevent crashes caused by invalid access of Konqueror's URL edit widget

2014-06-15 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118749/#review60159 --- This review has been submitted with commit 1e171b4230886c7c32

Re: Review Request 118749: Prevent crashes caused by invalid access of Konqueror's URL edit widget

2014-06-15 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118749/ --- (Updated June 16, 2014, 3:50 a.m.) Status -- This change has been ma

Re: Review Request 118749: Prevent crashes caused by invalid access of Konqueror's URL edit widget

2014-06-15 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118749/ --- (Updated June 16, 2014, 3:48 a.m.) Review request for KDE Base Apps and D

Re: Review Request 118749: Prevent crashes caused by invalid access of Konqueror's URL edit widget

2014-06-15 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118749/#review60147 --- Ship it! Looks good, except for one error konqueror/src

Review Request 118763: Remove find_package(XCB) call as it is handled already by the top-level cmake file

2014-06-15 Thread Bernd Steinhauser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118763/ --- Review request for kde-workspace. Repository: oxygen Description --

Re: Review Request 118750: Prevent use after free

2014-06-15 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118750/#review60124 --- Ship it! Please NOTICE that i've no mandate in the code secti

Re: Review Request 118750: Prevent use after free

2014-06-15 Thread Fabian Kosmale
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118750/ --- (Updated June 15, 2014, 8:18 a.m.) Review request for kde-workspace and A