Re: Moving plasma-nm to extragear

El Dimarts, 27 de maig de 2014, a les 20:41:23, Jan Grulich va escriure: > Hi, > > we would like to move plasma-nm to extragear/base and ask you for a review. Looks like in these i18n calls you should use proper argument placement and not "+" return i18n("Connected") + ", ⬇ " + Download + ", ⬆

Re: Review Request 118587: Optimize KConfigIniBackend::parseConfig by reducing allocations.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118587/ --- (Updated June 6, 2014, 11:35 a.m.) Review request for kdelibs, David Faur

Re: Review Request 118587: Optimize KConfigIniBackend::parseConfig by reducing allocations.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118587/ --- (Updated June 6, 2014, 11:28 a.m.) Review request for kdelibs, David Faur

Re: Review Request 118586: Optimize KConfigGroup::exists and similar operations.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118586/ --- (Updated June 6, 2014, 11:22 a.m.) Review request for kdelibs, David Faur

Re: Review Request 118587: Optimize KConfigIniBackend::parseConfig by reducing allocations.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118587/ --- (Updated June 6, 2014, 11:21 a.m.) Review request for kdelibs, David Faur

Re: Review Request 118587: Optimize KConfigIniBackend::parseConfig by reducing allocations.

> On June 6, 2014, 11:12 a.m., David Faure wrote: > > kdecore/config/bufferfragment_p.h, line 36 > > > > > > You could just declare as a friend the qHash function from within > > KConfigIniBackend, no? Yes, if y

Re: Review Request 118587: Optimize KConfigIniBackend::parseConfig by reducing allocations.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118587/#review59412 --- kdecore/config/bufferfragment_p.h

Re: Review Request 118587: Optimize KConfigIniBackend::parseConfig by reducing allocations.

> On June 6, 2014, 10:59 a.m., David Faure wrote: > > kdecore/config/kconfigini.cpp, line 109 > > > > > > This isn't always the case though. kmail does that, yes, but e.g. > > kdeglobals doesn't. > > Nor mos

Re: Review Request 118587: Optimize KConfigIniBackend::parseConfig by reducing allocations.

> On June 6, 2014, 10:59 a.m., David Faure wrote: > > kdecore/config/bufferfragment_p.h, line 36 > > > > > > Why? Now it could clash with an application class BufferFragment, on a > > system without "hidden visib

Re: Review Request 118587: Optimize KConfigIniBackend::parseConfig by reducing allocations.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118587/#review59406 --- kdecore/config/bufferfragment_p.h

Re: Review Request 118587: Optimize KConfigIniBackend::parseConfig by reducing allocations.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118587/ --- (Updated June 6, 2014, 9:31 a.m.) Review request for kdelibs and David Fa

Review Request 118587: Optimize KConfigIniBackend::parseConfig by reducing allocations.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118587/ --- Review request for kdelibs. Repository: kdelibs Description --- Op

Re: Review Request 118586: Optimize KConfigGroup::exists and similar operations.

> On June 6, 2014, 8:48 a.m., David Faure wrote: > > kdecore/config/kconfig.cpp, line 374 > > > > > > that one is a no-brainer (could be submitted separately right away) done. - Milian --

Re: Review Request 118586: Optimize KConfigGroup::exists and similar operations.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118586/ --- (Updated June 6, 2014, 9:05 a.m.) Review request for kdelibs and David Fa

Re: Review Request 118586: Optimize KConfigGroup::exists and similar operations.

> On June 6, 2014, 8:48 a.m., David Faure wrote: > > kdecore/config/kconfig.cpp, line 337 > > > > > > isn't this removal going to affect all callers of allSubGroups, > > possibly creating bugs? > > > >

Re: Review Request 118586: Optimize KConfigGroup::exists and similar operations.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118586/#review59386 --- Looks good to me, except for a small issue. I'd like to give

Review Request 118586: Optimize KConfigGroup::exists and similar operations.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118586/ --- Review request for kdelibs and David Faure. Repository: kdelibs Descrip