Re: Review Request 118563: kscreenlocker_greet: use SA_RESTART for signal handler

2014-06-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118563/#review59348 --- This review has been submitted with commit 705ec385df2b6fc0c8

Re: Review Request 118563: kscreenlocker_greet: use SA_RESTART for signal handler

2014-06-05 Thread Wolfgang Bauer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118563/ --- (Updated June 5, 2014, 4:20 p.m.) Status -- This change has been mar

Re: Review Request 118563: kscreenlocker_greet: use SA_RESTART for signal handler

2014-06-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118563/#review59346 --- This review has been submitted with commit 97bd72668224c1548d

Re: Review Request 118563: kscreenlocker_greet: use SA_RESTART for signal handler

2014-06-05 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118563/#review59329 --- Ship it! the master (plasma-workspace repo) has a unit test f

Review Request 118563: kscreenlocker_greet: use SA_RESTART for signal handler

2014-06-05 Thread Wolfgang Bauer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118563/ --- Review request for kde-workspace. Repository: kde-workspace Description

Re: Review Request 118180: slideshow BUG patch fix

2014-06-05 Thread TOM Harrison
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/ --- (Updated June 5, 2014, 10:32 a.m.) Review request for kde-workspace and P

Re: Review Request 118180: slideshow BUG patch fix

2014-06-05 Thread TOM Harrison
> On June 5, 2014, 10:12 a.m., Christoph Feck wrote: > > Please add Plasma developers to the group of reviewers. > > > > Btw, you cannot give "Ship It" to yourself, others have to approve it. > > TOM Harrison wrote: > that just a wrong click :) thanks for reminding for the missing reviewer

Re: Review Request 118180: slideshow BUG patch fix

2014-06-05 Thread TOM Harrison
> On June 5, 2014, 10:12 a.m., Christoph Feck wrote: > > Please add Plasma developers to the group of reviewers. > > > > Btw, you cannot give "Ship It" to yourself, others have to approve it. that just a wrong click :) - TOM --- This i

Re: Review Request 118180: slideshow BUG patch fix

2014-06-05 Thread TOM Harrison
> On None, TOM Harrison wrote: > > Ship It! wrong click:( - TOM --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/#review58086 --

Re: Review Request 118180: slideshow BUG patch fix

2014-06-05 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/#review59300 --- Please add Plasma developers to the group of reviewers. Btw,