Re: Review Request 118366: Porting keyboard module to Framework5

2014-05-31 Thread shivam makkar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118366/ --- (Updated May 31, 2014, 7:27 p.m.) Review request for kde-workspace, KDE F

Re: Review Request 112294: Implement multi-seat support in KDM

2014-05-31 Thread Oswald Buddenhagen
> On May 31, 2014, 9:35 a.m., Oswald Buddenhagen wrote: > > kdm/backend/dm.c, line 1463 > > > > > > this is actually tricky ... what if the display is still there but the > > seat changed? i don't think you are

Re: Review Request 112294: Implement multi-seat support in KDM

2014-05-31 Thread Stefan Brüns
> On May 31, 2014, 9:35 a.m., Oswald Buddenhagen wrote: > > kdm/backend/dm.c, line 1463 > > > > > > this is actually tricky ... what if the display is still there but the > > seat changed? i don't think you are

Re: Review Request 112294: Implement multi-seat support in KDM

2014-05-31 Thread Stefan Brüns
> On May 26, 2014, 8:32 a.m., Oswald Buddenhagen wrote: > > kdm/backend/dm.c, line 1436 > > > > > > "no matching unused" > > Stefan Brüns wrote: > "There is no unused or no matching unused dynamic display f

Re: Review Request 112294: Implement multi-seat support in KDM

2014-05-31 Thread Stefan Brüns
> On May 31, 2014, 9:35 a.m., Oswald Buddenhagen wrote: > > kdm/backend/dm.c, line 1416 > > > > > > that should go into the if for clarity. > > > > more importantly, you also need an unregisterInput() a

Re: Review Request 112294: Implement multi-seat support in KDM

2014-05-31 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112294/#review58845 --- kdm/backend/dm.c

Re: Review Request 112294: Implement multi-seat support in KDM

2014-05-31 Thread Oswald Buddenhagen
> On May 26, 2014, 8:32 a.m., Oswald Buddenhagen wrote: > > kdm/backend/dm.c, line 1436 > > > > > > "no matching unused" > > Stefan Brüns wrote: > "There is no unused or no matching unused dynamic display f