Re: Review Request 112294: Implement multi-seat support in KDM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112294/ --- (Updated May 29, 2014, 7:03 p.m.) Review request for kde-workspace and Os

Re: Review Request 112294: Implement multi-seat support in KDM

> On May 26, 2014, 8:32 a.m., Oswald Buddenhagen wrote: > > kdm/backend/client.c, line 1465 > > > > > > you forgot the free(envbuf). > > > > i don't like the interminglig with the other type of setting

Re: Review Request 112294: Implement multi-seat support in KDM

> On May 24, 2014, 11:46 a.m., Oswald Buddenhagen wrote: > > kdm/config.def, line 838 > > > > > > this should come before the ReserveServers - as mentioned before, > > hypothetically, you could have reserve disp

Re: Review Request 112294: Implement multi-seat support in KDM

> On May 26, 2014, 2:50 p.m., Stefan Brüns wrote: > > kdm/backend/dm.c, line 1430 > > > > > > Hm, I prefer this notation, in particular as this is the same as for > > std::string (guaranteed since C++03, workin

Re: Review Request 112294: Implement multi-seat support in KDM

> On March 28, 2014, 10:59 a.m., Oswald Buddenhagen wrote: > > kdm/backend/client.c, line 1467 > > > > > > this is redundant with the line below. > > if some particular pam module needs this setting, it shou

Re: Review Request 118407: Fix invalid processor information in usergent string for Safari4+

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118407/ --- (Updated May 29, 2014, 2:26 p.m.) Review request for KDE Base Apps. Bug

Review Request 118407: Fix invalid processor information in usergent string for Safari4+

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118407/ --- Review request for KDE Base Apps. Bugs: 335552 http://bugs.kde.org/sh

Re: Review Request 118366: Porting keyboard module to Framework5

> On May 28, 2014, 6:10 a.m., Martin Gräßlin wrote: > > kcms/keyboard/kcmmisc.cpp, lines 77-78 > > > > > > for new connects I would use the new compile time checked syntax. I tried it but it was giving some error

Re: Review Request 118366: Porting keyboard module to Framework5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118366/ --- (Updated May 29, 2014, 7:53 a.m.) Review request for kde-workspace, KDE F