Re: Review Request 117644: screenlocker: don't leave behind screensaver processes

2014-04-24 Thread Wolfgang Bauer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117644/ --- (Updated April 24, 2014, 10:28 p.m.) Status -- This change has been

Re: Review Request 117644: screenlocker: don't leave behind screensaver processes

2014-04-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117644/#review56437 --- This review has been submitted with commit 26a8ddc018d940ea19

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

2014-04-24 Thread Wolfgang Bauer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117091/ --- (Updated April 24, 2014, 10:20 p.m.) Status -- This change has been

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

2014-04-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117091/#review56431 --- This review has been submitted with commit 026bd64b2f681b0725

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

2014-04-24 Thread Wolfgang Bauer
> On April 24, 2014, 10:01 p.m., Thomas Lübking wrote: > > ksmserver/screenlocker/greeter/main.cpp, line 94 > > > > > > was there a problem with SA_RESTART? > > > > --- > > > > KDE Workspaces 4.1

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

2014-04-24 Thread Thomas Lübking
> On April 24, 2014, 8:01 p.m., Thomas Lübking wrote: > > ksmserver/screenlocker/greeter/main.cpp, line 94 > > > > > > was there a problem with SA_RESTART? > > > > --- > > > > KDE Workspaces 4.11

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

2014-04-24 Thread Wolfgang Bauer
> On April 24, 2014, 10:01 p.m., Thomas Lübking wrote: > > ksmserver/screenlocker/greeter/main.cpp, line 94 > > > > > > was there a problem with SA_RESTART? > > > > --- > > > > KDE Workspaces 4.1

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

2014-04-24 Thread Wolfgang Bauer
> On April 24, 2014, 10:01 p.m., Thomas Lübking wrote: > > ksmserver/screenlocker/greeter/main.cpp, line 94 > > > > > > was there a problem with SA_RESTART? > > > > --- > > > > KDE Workspaces 4.1

Re: Review Request 117644: screenlocker: don't leave behind screensaver processes

2014-04-24 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117644/#review56416 --- and this as well then. - Thomas Lübking On April 24, 2014,

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

2014-04-24 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117091/#review56415 --- ksmserver/screenlocker/greeter/main.cpp

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

2014-04-24 Thread Wolfgang Bauer
> On April 22, 2014, 7:34 p.m., Thomas Lübking wrote: > > see minor nitpicks, but in general the patch seems fine and required to me. > > "shipIt!" unless veto ;-) So, can I submit this now? Today 4.11.9 is going to be tagged... I have of course built and tested it again after the latest change

Re: Review Request 117644: screenlocker: don't leave behind screensaver processes

2014-04-24 Thread Wolfgang Bauer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117644/ --- (Updated April 24, 2014, 3:42 p.m.) Review request for kde-workspace and

Re: Review Request 117174: Fix installing and removing desktop plasma theme packages.

2014-04-24 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117174/#review56363 --- Ship it! Looks good to me. - Sebastian Kügler On April 23,

Open Source Organizational Culture

2014-04-24 Thread Marius Storm-Olsen
Hi, I would like to request your participation in a survey on Open Source Organizational Culture, which will provide valuable insight into how Open Source projects are run, how their participants act, how they might change going forward, and how particular Open Source projects compare with

Re: Kronometer now in KDE Review

2014-04-24 Thread Elvis Angelaccio
2014-04-23 14:28 GMT+02:00 Thomas Lübking : > On Mittwoch, 23. April 2014 13:17:02 CEST, Elvis Angelaccio wrote: > > I don't understand. Since there are only numbers I think that your point >> is >> already accomplished. >> > Nope. > To get monospace glyphs for sure, you must select a monospace f

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

2014-04-24 Thread Wolfgang Bauer
> On April 23, 2014, 5:43 p.m., Martin Gräßlin wrote: > > ksmserver/screenlocker/greeter/main.cpp, line 34 > > > > > > I'm wondering about the variable naming. It's m_ so one would assume > > it's a member variab

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

2014-04-24 Thread Wolfgang Bauer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117091/ --- (Updated April 24, 2014, 10:52 a.m.) Review request for kde-workspace, Pl