Re: Review Request 116783: Change ftpFileExists to use relative paths for SIZE requests

2014-03-13 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116783/ --- (Updated March 13, 2014, 11:30 p.m.) Status -- This change has been

Re: Review Request 116783: Change ftpFileExists to use relative paths for SIZE requests

2014-03-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116783/#review52918 --- This review has been submitted with commit 0d8913d2b544c16043

Re: Review Request 116784: Fix incorrect use of KDateTime.toTime_t in kio_http

2014-03-13 Thread Dawit Alemayehu
> On March 13, 2014, 5:30 p.m., David Jarvie wrote: > > The handling of return values from KDateTime::toTime_t() in the existing > > kio_http code is not correct, because the return value's type is implicitly > > cast to other types before being checked. For example, in one place it is > > cas

Re: Review Request 116783: Change ftpFileExists to use relative paths for SIZE requests

2014-03-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116783/#review52916 --- Ship it! Ship It! - David Faure On March 13, 2014, 10:15 p

Re: Review Request 116783: Change ftpFileExists to use relative paths for SIZE requests

2014-03-13 Thread Dawit Alemayehu
> On March 13, 2014, 1:10 p.m., David Faure wrote: > > kioslave/ftp/ftp.cpp, line 2302 > > > > > > Misunderstanding, I wasn't talking about indentation (which indeed ends > > up being 4 spaces everywhere in fra

Re: Review Request 116783: Change ftpFileExists to use relative paths for SIZE requests

2014-03-13 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116783/ --- (Updated March 13, 2014, 10:15 p.m.) Review request for kdelibs and David

Re: Review Request 109675: Make sure that the KDE prefix comes first in XDG_DATA_DIRS

2014-03-13 Thread Rex Dieter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/109675/#review52898 --- introduced regression'y behavior, see https://bugs.kde.org/sh

Re: Review Request 116784: Fix incorrect use of KDateTime.toTime_t in kio_http

2014-03-13 Thread David Jarvie
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116784/#review52897 --- The handling of return values from KDateTime::toTime_t() in th

Re: Review Request 116783: Change ftpFileExists to use relative paths for SIZE requests

2014-03-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116783/#review52891 --- kioslave/ftp/ftp.cpp

Re: Review Request 116783: Change ftpFileExists to use relative paths for SIZE requests

2014-03-13 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116783/ --- (Updated March 13, 2014, 12:58 p.m.) Review request for kdelibs and David

Re: Review Request 116783: Change ftpFileExists to use relative paths for SIZE requests

2014-03-13 Thread Dawit Alemayehu
> On March 13, 2014, 12:40 p.m., David Faure wrote: > > kioslave/ftp/ftp.cpp, line 2260 > > > > > > It's a bit confusing to have two methods called ftpSize. Maybe call > > this one ftpSizeCmd() or something? (c

Review Request 116784: Fix incorrect use of KDateTime.toTime_t in kio_http

2014-03-13 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116784/ --- Review request for kdelibs, Andreas Hartmetz and David Faure. Repository:

Re: Review Request 116783: Change ftpFileExists to use relative paths for SIZE requests

2014-03-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116783/#review52887 --- Looks good, apart from method name and coding style (spaces in

Review Request 116783: Change ftpFileExists to use relative paths for SIZE requests

2014-03-13 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116783/ --- Review request for kdelibs and David Faure. Repository: kdelibs Descrip

ECM uninstall target

2014-03-13 Thread Harald Sitter
alohas, I just ported phonon/five to ECM and noticed that apparently ECM does not have an include or something to introduce an uninstall target. Are there plans to introduce such a thing or am I simply blind and not seeing the already existing include? HS