Re: Review Request 116524: Make kio_ftp work with ftp server that don't support absolute path with SIZE command

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116524/ --- (Updated March 7, 2014, 6:48 a.m.) Review request for kdelibs and David F

Re: Review Request 116524: Make kio_ftp work with ftp server that don't support absolute path with SIZE command

> On March 5, 2014, 7:47 a.m., David Faure wrote: > > kioslave/ftp/ftp.cpp, line 2275 > > > > > > This is surely wrong. > > > > If you're in /home/dfaure (as the CWD would be, by default, on > > non-an

Review Request 116570: Ask user for confirmation before doing POST -> POST redirection in KIO

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116570/ --- Review request for kdelibs, Andrea Iacovitti and David Faure. Repository:

Re: Review Request 116122: Do not add trailing slash on http DELETE requests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116122/ --- (Updated March 7, 2014, 6:05 a.m.) Review request for kdelibs, Andrea Iac

Re: Review Request 116122: Do not add trailing slash on http DELETE requests

> On March 6, 2014, 9:10 p.m., Andrea Iacovitti wrote: > > I tested your patch, no trailing slash is added whether the request refers > > to a collection or resource (as it was before commit 58294ac). > > Dawit Alemayehu wrote: > Right, but now the webdav server should redirect to the right

Re: Review Request 116122: Do not add trailing slash on http DELETE requests

> On March 6, 2014, 9:10 p.m., Andrea Iacovitti wrote: > > I tested your patch, no trailing slash is added whether the request refers > > to a collection or resource (as it was before commit 58294ac). > > Dawit Alemayehu wrote: > Right, but now the webdav server should redirect to the right

Re: Review Request 116122: Do not add trailing slash on http DELETE requests

> On March 6, 2014, 9:10 p.m., Andrea Iacovitti wrote: > > I tested your patch, no trailing slash is added whether the request refers > > to a collection or resource (as it was before commit 58294ac). Right, but now the webdav server should redirect to the right address (with trailing slash) a

Re: Review Request 116555: Add support for pam-kwallet in kwalletd

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116555/#review52298 --- For the release time, since this is really like I would like t

Re: Review Request 116555: Add support for pam-kwallet in kwalletd

> On March 6, 2014, 7:52 p.m., Albert Astals Cid wrote: > > I wonder if you're being too much verbose with the debugs. Since it is a beta I want to take the most of it in case any issue appears, I can remove verbosity before release if needed (think that this debug only happens once on session

Re: Review Request 116555: Add support for pam-kwallet in kwalletd

> On March 6, 2014, 7:52 p.m., Albert Astals Cid wrote: > > kwalletd/main.cpp, line 100 > > > > > > Make this function static like the other ones? You are right, I will fix it tomorrow morning. - Àlex --

Re: Review Request 116122: Do not add trailing slash on http DELETE requests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116122/#review52294 --- I tested your patch, no trailing slash is added whether the re

Re: Review Request 116604: Allow directories with . as output for meinproc

> On March 5, 2014, 3:36 p.m., Burkhard Lück wrote: > > src/meinproc.cpp, lines 170-179 > > > > > > How does this affect this code in KHelpcenter: > > > > kde-runtime/khelpcenter/glossary.cpp:149:KPr

Re: Review Request 116555: Add support for pam-kwallet in kwalletd

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116555/#review52293 --- I wonder if you're being too much verbose with the debugs. k