Re: KF5 Update Meeting Minutes 2014-w10

2014-03-05 Thread Kevin Ottens
Hello, On Thursday 06 March 2014 02:13:36 Valentin Rusu wrote: > Catching up with KF5 progress... > > On Tuesday, March 04, 2014 04:59:58 PM Kevin Ottens wrote: > > * Repository merges for kwallet and kdnssd still reported as pending... > > What's that? Is that about merging 4.xx repository wit

Re: KF5 Update Meeting Minutes 2014-w10

2014-03-05 Thread Valentin Rusu
Hello, Catching up with KF5 progress... On Tuesday, March 04, 2014 04:59:58 PM Kevin Ottens wrote: > * Repository merges for kwallet and kdnssd still reported as pending... What's that? Is that about merging 4.xx repository with the KF5 one? > * afiestas has kwallet patches in need of review

Re: Review Request 116555: Add support for pam-kwallet in kwalletd

2014-03-05 Thread Valentin Rusu
> On March 3, 2014, 11:57 p.m., Albert Astals Cid wrote: > > The Beta 1 of 4.13 is on Wednesday. Can the maintainer of the code affected > > by this give a evaluation of how "dangerous" this patch is and his > > recommendation for the Freeze exception? Oh, I only see this now. Is it too late?

Re: Review Request 116555: Add support for pam-kwallet in kwalletd

2014-03-05 Thread Valentin Rusu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116555/#review52218 --- Ship it! Ship It! - Valentin Rusu On March 2, 2014, 11:33

Re: Review Request 115351: Use kDebug instead of qDebug in QSpellEnchantDict

2014-03-05 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115351/ --- (Updated March 5, 2014, 7:11 p.m.) Status -- This change has been ma

Re: Review Request 115351: Use kDebug instead of qDebug in QSpellEnchantDict

2014-03-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115351/#review52204 --- This review has been submitted with commit 42b779e3efca6cddf3

Re: Review Request 116604: Allow directories with . as output for meinproc

2014-03-05 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116604/#review52091 --- src/meinproc.cpp

Re: Review Request 116122: Do not add trailing slash on http DELETE requests

2014-03-05 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116122/ --- (Updated March 5, 2014, 2:01 p.m.) Review request for kdelibs, Andrea Iac

Re: Review Request 116523: Do not call ftpSendMimeType for empty files in Ftp::ftpGet

2014-03-05 Thread Dawit Alemayehu
> On March 4, 2014, 7:42 p.m., David Faure wrote: > > I don't get it. What's the problem with sending a mimetype for empty files? > > I would think this is actually expected - for all files, including empty > > ones. Why does this fix the bug? It fails and ends up sending an error message. See

Re: Review Request 115351: Use kDebug instead of qDebug in QSpellEnchantDict

2014-03-05 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115351/#review52053 --- Heh, the Git history looks very sad in this part of kdelibs. N

Re: Review Request 115351: Use kDebug instead of qDebug in QSpellEnchantDict

2014-03-05 Thread Milian Wolff
> On Jan. 28, 2014, 5:49 p.m., Aleix Pol Gonzalez wrote: > > Should we even comment/remove them? Doesn't seem like anybody's going to > > read this output ever... Ping, can someone tell me what to do with this? Can I either push this change or remove the output altogether? - Milian ---