Re: Review Request 116017: Implement POST -> POST redirection support in KIO

2014-02-24 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116017/ --- (Updated Feb. 25, 2014, 6:07 a.m.) Review request for kdelibs, Andrea Iac

Re: Review Request 116017: Implement POST -> POST redirection support in KIO

2014-02-24 Thread Dawit Alemayehu
> On Feb. 24, 2014, 8:47 p.m., Andrea Iacovitti wrote: > > I quickly tested the patch using a basic html form and it seems it break > > http post operation (regardless of redirection). > > I get back a "400 Bad Request" from the server and can see the following > > debug message: > > "kio_http(

Re: Review Request 116017: Implement POST -> POST redirection support in KIO

2014-02-24 Thread Dawit Alemayehu
> On Feb. 24, 2014, 7:17 p.m., David Faure wrote: > > kio/kio/job.h, line 307 > > > > > > "recommended you use the function for when..." - rather unclear. Which > > function? In the commit log you said you wante

Re: Review Request 116017: Implement POST -> POST redirection support in KIO

2014-02-24 Thread Andrea Iacovitti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116017/#review50761 --- I quickly tested the patch using a basic html form and it seem

Re: Review Request 116017: Implement POST -> POST redirection support in KIO

2014-02-24 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116017/#review50701 --- Just typos and docu issues, the core of the fix seems ok to me

Review Request 116017: Implement POST -> POST redirection support in KIO

2014-02-24 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116017/ --- Review request for kdelibs, Andrea Iacovitti and David Faure. Repository: