Re: Review Request 114567: RFC: SecondaryActiveChanged signal for advanced screenlocking (global pause MPRIS2, Telepathy N/A status, etc)

2014-02-07 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114567/#review49231 --- Can I confirm that I've understood this patch correctly. The g

Re: Repository rename and consequences

2014-02-07 Thread Michael Pyne
On Sat, February 8, 2014 10:58:23 Ben Cooksley wrote: > Once the procedure has been completed, automated build scripts such as > kdesrc-build should automatically clone the repositories under their > new names - however custom scripts and procedures will need to be > adjusted by hand. I would just

Re: Review Request 113175: Always use an external viewer application to view files

2014-02-07 Thread Sven Brauch
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113175/ --- (Updated Feb. 7, 2014, 10:13 p.m.) Status -- This change has been di

Repository rename and consequences

2014-02-07 Thread Ben Cooksley
Hello all, Sysadmin has received a request to rename the repository "kwallet" (currently located at kde/kdeutils) to "kwalletmanager" in order to free this name up. Once that has been completed, the repository "kwallet-framework" (located at frameworks/) will be renamed to "kwallet". This will h

Re: Review Request 115408: Right align mime icon in kpropertiesdialog

2014-02-07 Thread kdeuser56 kdeuser56
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115408/ --- (Updated Feb. 7, 2014, 7:07 p.m.) Review request for kdelibs and Frank Re

Re: Review Request 115408: Right align mime icon in kpropertiesdialog

2014-02-07 Thread Thomas Lübking
> On Jan. 30, 2014, 9:20 p.m., Thomas Lübking wrote: > > tried to center align it? > > kdeuser56 kdeuser56 wrote: > Center what? The widget or the iconlabel? I think in case of the widget > it makes no sense. > In case of the iconlabel the icon itself would be on the exact same > posi

Re: Review Request 115408: Right align mime icon in kpropertiesdialog

2014-02-07 Thread kdeuser56 kdeuser56
> On Jan. 30, 2014, 9:20 p.m., Thomas Lübking wrote: > > tried to center align it? > > kdeuser56 kdeuser56 wrote: > Center what? The widget or the iconlabel? I think in case of the widget > it makes no sense. > In case of the iconlabel the icon itself would be on the exact same > posi

Re: Review Request 115408: Right align mime icon in kpropertiesdialog

2014-02-07 Thread Thomas Lübking
> On Jan. 30, 2014, 9:20 p.m., Thomas Lübking wrote: > > tried to center align it? > > kdeuser56 kdeuser56 wrote: > Center what? The widget or the iconlabel? I think in case of the widget > it makes no sense. > In case of the iconlabel the icon itself would be on the exact same > posi

Re: Review Request 115408: Right align mime icon in kpropertiesdialog

2014-02-07 Thread kdeuser56 kdeuser56
> On Jan. 30, 2014, 9:20 p.m., Thomas Lübking wrote: > > tried to center align it? > > kdeuser56 kdeuser56 wrote: > Center what? The widget or the iconlabel? I think in case of the widget > it makes no sense. > In case of the iconlabel the icon itself would be on the exact same > posi

Re: Review Request 115497: Replace SHA with PBKDF2-SHA512+Salt

2014-02-07 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115497/ --- (Updated Feb. 7, 2014, 5:39 p.m.) Review request for KDE Runtime, Teo Mrn

Re: Review Request 115497: Replace SHA with PBKDF2-SHA512+Salt

2014-02-07 Thread Àlex Fiestas
> On Feb. 7, 2014, 5:14 a.m., Michael Pyne wrote: > > kwalletd/backend/kwalletbackend.cc, line 387 > > > > > > Again, might want to add error-checking here. If the salt can't be > > saved for whatever reason t

Re: Review Request 115515: [oxygen] Check whether we are on platform X11 before calling into xcb

2014-02-07 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115515/ --- (Updated Feb. 7, 2014, 12:13 p.m.) Status -- This change has been ma

Re: Review Request 115515: [oxygen] Check whether we are on platform X11 before calling into xcb

2014-02-07 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115515/#review49181 --- This review has been submitted with commit 1a4df7587968a1de26

Re: Review Request 115515: [oxygen] Check whether we are on platform X11 before calling into xcb

2014-02-07 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115515/#review49179 --- Ship it! ship it, again :) - Hugo Pereira Da Costa On Feb.

Re: Review Request 115519: Do not use KDE_VERSION_STRING for workspace applications

2014-02-07 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115519/ --- (Updated Feb. 7, 2014, 11:33 a.m.) Status -- This change has been ma

Re: Review Request 115519: Do not use KDE_VERSION_STRING for workspace applications

2014-02-07 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115519/#review49175 --- This review has been submitted with commit 18e31e1e183a695ba4