Re: Review Request 115497: Replace SHA with PBKDF2-SHA512+Salt

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115497/#review49163 --- A couple of minor things but definitely looks a lot better. Ho

Re: KDE Review: Move kqtquickcharts to KDE Edu

El Dimecres, 5 de febrer de 2014, a les 17:25:48, Sebastian Gottfried va escriure: > Hi everyone, Hi > > kqtquickcharts (formerly known as kqmlgraphs) provides components for line > and bar charts for QtQuick applications. > > As discussed earlier, I want to release the project as soon as poss

Re: Review Request 115519: Do not use KDE_VERSION_STRING for workspace applications

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115519/#review49158 --- Ship it! If it compiles, makes sense to me :D - Albert Astal

Re: Review Request 115497: Replace SHA with PBKDF2-SHA512+Salt

> On Feb. 5, 2014, 7:18 p.m., Michael Pyne wrote: > > kwalletd/backend/kwalletbackend.cc, line 129 > > > > > > libgcrypt supports the "scrypt" key derivation function since 1.6.0, > > and we require 1.6.1. > >

Review Request 115519: Do not use KDE_VERSION_STRING for workspace applications

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115519/ --- Review request for kde-workspace and Release Team. Repository: kde-worksp

Re: Review Request 115497: Replace SHA with PBKDF2-SHA512+Salt

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115497/ --- (Updated Feb. 6, 2014, 3:28 p.m.) Review request for KDE Runtime, Teo Mrn

KDE Review: Move kqtquickcharts to KDE Edu

Hi everyone, kqtquickcharts (formerly known as kqmlgraphs) provides components for line and bar charts for QtQuick applications. As discussed earlier, I want to release the project as soon as possible (read: 4.13) so KTouch and artikulate can use it. The release of artikulate depends on this,

Re: Review Request 115515: [oxygen] Check whether we are on platform X11 before calling into xcb

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115515/ --- (Updated Feb. 6, 2014, 1:22 p.m.) Review request for kde-workspace and Hu

Re: Review Request 115515: [oxygen] Check whether we are on platform X11 before calling into xcb

> On Feb. 6, 2014, 12:26 p.m., Hugo Pereira Da Costa wrote: > > @Martin > > in kstyles/oxygen > > you are missing oxygenblurhelper (and likely kate will crash when showing a > > tooltip) > > > > in kwin/clients/oxygen (but might be another review) > > oxygenclient > > oxygensizegrip > > config/

Re: Review Request 115497: Replace SHA with PBKDF2-SHA512+Salt

> On Feb. 5, 2014, 7:18 p.m., Michael Pyne wrote: > > kwalletd/backend/kwalletbackend.cc, line 130 > > > > > > The salt here seems to be based off of the user's login-name, which can > > change (for instance, so

Re: Review Request 115497: Replace SHA with PBKDF2-SHA512+Salt

> On Feb. 5, 2014, 7:18 p.m., Michael Pyne wrote: > > kwalletd/backend/kwalletbackend.cc, line 635 > > > > > > Seems to be no error checking here, if this fails and we overwrite the > > hashed passwords on disk,

Re: Review Request 115497: Replace SHA with PBKDF2-SHA512+Salt

> On Feb. 5, 2014, 7:18 p.m., Michael Pyne wrote: > > kwalletd/backend/kwalletbackend.cc, line 130 > > > > > > The salt here seems to be based off of the user's login-name, which can > > change (for instance, so

Re: Review Request 115515: [oxygen] Check whether we are on platform X11 before calling into xcb

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115515/#review49102 --- Ship it! @Martin in kstyles/oxygen you are missing oxygenblur

Review Request 115515: [oxygen] Check whether we are on platform X11 before calling into xcb

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115515/ --- Review request for kde-workspace and Hugo Pereira Da Costa. Repository: k