Re: KDE Review - Moving Artikulate to KDE Edu

2014-01-26 Thread Albert Astals Cid
El Diumenge, 26 de gener de 2014, a les 17:01:39, Christoph Feck va escriure: > On Sunday 26 January 2014 16:39:08 Albert Astals Cid wrote: > > So I did have a look at Artikulate yesterday and just found some > > minor nagging user flow issues that I told Andreas and he says he > > would be fixing.

Re: KDE Review - Moving Artikulate to KDE Edu

2014-01-26 Thread Christoph Feck
On Sunday 26 January 2014 16:39:08 Albert Astals Cid wrote: > So I did have a look at Artikulate yesterday and just found some > minor nagging user flow issues that I told Andreas and he says he > would be fixing. > > Other than that, looks good to me to move to kdeedu *but* we need > to decide wh

Re: KDE Review - Moving Artikulate to KDE Edu

2014-01-26 Thread Albert Astals Cid
El Dimarts, 14 de gener de 2014, a les 19:52:57, Albert Astals Cid va escriure: > El Dimarts, 14 de gener de 2014, a les 09:18:10, Andreas Cord-Landwehr va > > escriure: > > Hi, > > > > > I think you should work on getting kqmlgraphplugin released first, > > > depending on something unreleased s

Re: Review Request 114715: Attempt to fix KZoneAllocator issue

2014-01-26 Thread Kevin Funk
> On Jan. 24, 2014, 4:32 p.m., David Faure wrote: > > Urgh - a static object in a library? How did we not notice before... Needs > > to be fixed indeed. > > > > I would have used Q_GLOBAL_STATIC (which has methods like isDestroyed()), > > but I guess that's equivalent to your sharedpointer + s

Re: Review Request 113413: Improved Keyboard Layout Preview

2014-01-26 Thread shivam makkar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113413/#review48292 --- Ship it! Ship It! - shivam makkar On Nov. 15, 2013, 9:37 a

Re: Review Request 114737: KInfocenter/OpenGL: reimplement the ReadPipe() function with QProcess

2014-01-26 Thread Wolfgang Bauer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114737/ --- (Updated Jan. 26, 2014, 10:43 a.m.) Review request for kde-workspace and

Re: Review Request 114737: KInfocenter/OpenGL: reimplement the ReadPipe() function with QProcess

2014-01-26 Thread Wolfgang Bauer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114737/#review48287 --- I made another change because I noticed a "QProcess: Destroyed