KDE Review: Moving Smb4K to extragear/network

2014-01-14 Thread Alexander Reinholdt
Hello, Smb4K is an advanced network neighborhood browser and Samba share mounting utility. It already exists about ten years and just recently version 1.1 was released to the public. Until recently the code resided in playground/network (Subversion repository) and I though now is the time to

Re: Review Request 114737: KInfocenter/OpenGL: reimplement the ReadPipe() function with QProcess

2014-01-14 Thread David Stephen Hubner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114737/#review47419 --- Ship it! Looks good to me - David Stephen Hubner On Jan. 4

Re: Review Request 114999: Add KF5 namespace to dbus interface

2014-01-14 Thread Thomas Lübking
> On Jan. 14, 2014, 7:22 p.m., Martin Gräßlin wrote: > > like with the other patch I'm not sure whether that's a good idea as that > > breaks any communication with the kdelibs4. > > Thomas Lübking wrote: > is there a functional incompitibility between SC4 and KF5 that requires > such disa

Re: Review Request 114999: Add KF5 namespace to dbus interface

2014-01-14 Thread Martin Gräßlin
> On Jan. 14, 2014, 8:22 p.m., Martin Gräßlin wrote: > > like with the other patch I'm not sure whether that's a good idea as that > > breaks any communication with the kdelibs4. > > Thomas Lübking wrote: > is there a functional incompitibility between SC4 and KF5 that requires > such disa

Re: Review Request 114686: Do not use a standard shortcut for KMessageWidget's "close" action

2014-01-14 Thread Aurélien Gâteau
> On Jan. 14, 2014, 9:05 a.m., Aurélien Gâteau wrote: > > Makes sense to me, go for it. > > Frank Reininghaus wrote: > Thanks! > > BTW, I was just going to forward-port the patch to Frameworks > (kwidgetsaddons), but I see that KMessageWidget does not use KStandardAction > any mor

Re: Review Request 114686: Do not use a standard shortcut for KMessageWidget's "close" action

2014-01-14 Thread Frank Reininghaus
> On Jan. 14, 2014, 8:05 a.m., Aurélien Gâteau wrote: > > Makes sense to me, go for it. Thanks! BTW, I was just going to forward-port the patch to Frameworks (kwidgetsaddons), but I see that KMessageWidget does not use KStandardAction any more. I think that this means that no shortcut is assi

Re: Review Request 114686: Do not use a standard shortcut for KMessageWidget's "close" action

2014-01-14 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114686/ --- (Updated Jan. 14, 2014, 8:30 p.m.) Status -- This change has been ma

Re: Review Request 114686: Do not use a standard shortcut for KMessageWidget's "close" action

2014-01-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114686/#review47398 --- This review has been submitted with commit 209c36d93c8d22276d

Re: Review Request 114999: Add KF5 namespace to dbus interface

2014-01-14 Thread Thomas Lübking
> On Jan. 14, 2014, 7:22 p.m., Martin Gräßlin wrote: > > like with the other patch I'm not sure whether that's a good idea as that > > breaks any communication with the kdelibs4. is there a functional incompitibility between SC4 and KF5 that requires such disambiguation or is this merely a pac

Re: Review Request 114999: Add KF5 namespace to dbus interface

2014-01-14 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114999/#review47390 --- like with the other patch I'm not sure whether that's a good i

Re: Review Request 113493: Fix entering kcm_kdm resets settings of current session

2014-01-14 Thread Luc Menut
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113493/ --- (Updated Jan. 14, 2014, 7:16 p.m.) Status -- This change has been ma

Re: KDE Review - Moving Artikulate to KDE Edu

2014-01-14 Thread Albert Astals Cid
El Dimarts, 14 de gener de 2014, a les 09:18:10, Andreas Cord-Landwehr va escriure: > Hi, > > > I think you should work on getting kqmlgraphplugin released first, > > depending on something unreleased scares me a bit. > > Just talked to Sebastian (maintainer of the plugin) and he will do a > tec

Re: Re: KDE Review - Moving Artikulate to KDE Edu

2014-01-14 Thread Andreas Cord-Landwehr
Hi, > I think you should work on getting kqmlgraphplugin released first, depending > on something unreleased scares me a bit. Just talked to Sebastian (maintainer of the plugin) and he will do a technical preview release of the plugin soon. BTW this code already exists in KTouch for quite some

KF5 Update Meeting Minutes 2014-w3

2014-01-14 Thread Kevin Ottens
Hello everyone, This is the minutes of the Week 3 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: afiestas, agateau, alexmerry, dfaure, mck182, Riddell, valir and myself. Announcement: * We're *still* actively looking for maintainers! Konqi wants YOU! *

Re: Review Request 114999: Add KF5 namespace to dbus interface

2014-01-14 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114999/ --- (Updated Jan. 14, 2014, 3:21 p.m.) Review request for KDE Runtime, David

Re: Review Request 114686: Do not use a standard shortcut for KMessageWidget's "close" action

2014-01-14 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114686/#review47356 --- Ship it! Makes sense to me, go for it. - Aurélien Gâteau O