Re: Review Request 114717: Language detection in Sonnet

2014-01-08 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114717/ --- (Updated Jan. 8, 2014, 7:24 p.m.) Status -- This change has been mar

Re: KDE Frameworks: Moving toward 5.0 final and Governance

2014-01-08 Thread Michal Humpula
On Tuesday 07 of January 2014 23:10:11 John Layt wrote: > On 7 January 2014 19:55, Albert Astals Cid wrote: > > El Dimarts, 7 de gener de 2014, a les 18:24:41, Alex Merry va escriure: > >> On 07/01/14 17:10, John Layt wrote: > >> > I've put myself down (rather obviously) for KPrintUtils. Most of

[ANN] Registration for C++Now 2014 is Open

2014-01-08 Thread Boris Kolpackov
Hi, Registration is now open for the eighth annual C++Now conference (formerly BoostCon) which will be held in Aspen, Colorado, USA, May 12th to 17th, 2014. C++Now is a general C++ conference for C++ experts and enthusiasts. It is not specific to any library/framework or compiler vendor and has t

Re: Review Request 114910: Patch for bug 317066 ("systray leaves garbage on the panel when resizing ")

2014-01-08 Thread Dmitry Ivanov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114910/ --- (Updated Jan. 8, 2014, 8:25 p.m.) Review request for kde-workspace and Pl

Re: Review Request 114910: Patch for bug 317066 ("systray leaves garbage on the panel when resizing ")

2014-01-08 Thread Dmitry Ivanov
> On Jan. 8, 2014, 5:06 p.m., Thomas Lübking wrote: > > briefly looking at the bug - wouldn't it be better to only cause a full > > parent repaint when adding/removing an (fdo) icon? I have tried it but without success. Adding/removing/changing visibility preference of icons is done on QML sid

Re: Review Request 114910: Patch for bug 317066 ("systray leaves garbage on the panel when resizing ")

2014-01-08 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114910/#review47049 --- briefly looking at the bug - wouldn't it be better to only cau

Re: Review Request 110813: Add support for just smooth window movement and resizing to wobbly windows effect

2014-01-08 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/110813/#review47043 --- sorry for the late review. It didn't end in my review board in

Re: KDE Frameworks: Moving toward 5.0 final and Governance

2014-01-08 Thread John Layt
On 7 January 2014 23:52, Alex Merry wrote: > If these additions are something that applications would need to be > aware of, I see no issue with creating a wrapper class or some such > as-and-when we find a use for one. > > If they are something that would be hidden to applications, would you > c

Re: KDE Frameworks: Moving toward 5.0 final and Governance

2014-01-08 Thread Kevin Ottens
On Wednesday 08 January 2014 10:56:41 John Layt wrote: > On 8 January 2014 07:17, Kevin Ottens wrote: > > For the record, if that depends on QtPrintSupport it can't make it to > > KGuiAddons (which should depend only on QtCore and QtGui). > > Good point :-) > > > I'm fine keeping it even if it's

Re: Review Request 114889: Fix KIO::convertSize(...) returning string with "(I18N_ARGUMENT_MISSING)" inside

2014-01-08 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114889/#review47040 --- This review has been submitted with commit 149fd780c71b3d8d3d

Re: Review Request 114889: Fix KIO::convertSize(...) returning string with "(I18N_ARGUMENT_MISSING)" inside

2014-01-08 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114889/ --- (Updated Jan. 8, 2014, 10:43 a.m.) Status -- This change has been ma

Re: KDE Frameworks: Moving toward 5.0 final and Governance

2014-01-08 Thread John Layt
On 8 January 2014 07:17, Kevin Ottens wrote: > For the record, if that depends on QtPrintSupport it can't make it to > KGuiAddons (which should depend only on QtCore and QtGui). Good point :-) > I'm fine keeping it even if it's small. OK, I'll take the chainsaw to it this weekend and see what

Re: KDE Frameworks: Moving toward 5.0 final and Governance

2014-01-08 Thread John Layt
On 7 January 2014 23:30, Michal Humpula wrote: > If I may post a little input here. I've implemented print preview in kate > (KF5) with QPrintPreviewDialog, mainly for the reasons mentioned above. But > what I'm missing is ability to add custom configuration tabs as in > KdePrint::createPrintDial

Re: Review Request 114841: Screenlocker: don't set the mouse cursor when grabbing the mouse

2014-01-08 Thread Wolfgang Bauer
> On Jan. 8, 2014, 8:10 a.m., Martin Gräßlin wrote: > > If you have the possibility (build setup) please merge to master and fix > > the merge conflict I expect to see :-) I merged 4.11 into master yesterday > > so there should no be anything else which could conflict. > > Wolfgang Bauer wrote

Re: Review Request 114841: Screenlocker: don't set the mouse cursor when grabbing the mouse

2014-01-08 Thread Martin Gräßlin
> On Jan. 8, 2014, 8:10 a.m., Martin Gräßlin wrote: > > If you have the possibility (build setup) please merge to master and fix > > the merge conflict I expect to see :-) I merged 4.11 into master yesterday > > so there should no be anything else which could conflict. > > Wolfgang Bauer wrote

Re: Review Request 114889: Fix KIO::convertSize(...) returning string with "(I18N_ARGUMENT_MISSING)" inside

2014-01-08 Thread Chusslove Illich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114889/#review47027 --- Ship it! Ship It! - Chusslove Illich On Jan. 7, 2014, 5:24

Re: Review Request 114841: Screenlocker: don't set the mouse cursor when grabbing the mouse

2014-01-08 Thread Wolfgang Bauer
> On Jan. 8, 2014, 8:10 a.m., Martin Gräßlin wrote: > > If you have the possibility (build setup) please merge to master and fix > > the merge conflict I expect to see :-) I merged 4.11 into master yesterday > > so there should no be anything else which could conflict. I have committed to 4.11

Re: Review Request 114841: Screenlocker: don't set the mouse cursor when grabbing the mouse

2014-01-08 Thread Wolfgang Bauer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114841/ --- (Updated Jan. 8, 2014, 8:59 a.m.) Status -- This change has been mar

Re: Review Request 114841: Screenlocker: don't set the mouse cursor when grabbing the mouse

2014-01-08 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114841/#review47023 --- This review has been submitted with commit c1761755915ab59f41

Re: Review Request 114910: Patch for bug 317066 ("systray leaves garbage on the panel when resizing ")

2014-01-08 Thread Dmitry Ivanov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114910/ --- (Updated Jan. 8, 2014, 12:59 p.m.) Review request for kde-workspace and P