Re: KClasses vs. Qt5Classes

2014-01-02 Thread Aleix Pol
On Tue, Dec 31, 2013 at 12:42 PM, Martin Graesslin wrote: > On Tuesday 31 December 2013 12:15:09 David Faure wrote: > > > QSystemTrayIcon => KNotificationItem > > > > No clue. I can't even find KNotificationItem in KF5 anywhere !?!? > > In fact it doesn't exist in kdelibs4 either. > > > > I th

Re: Review Request 114717: Language detection in Sonnet

2014-01-02 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114717/#review46650 --- src/core/settings.cpp

Re: KClasses vs. Qt5Classes

2014-01-02 Thread Kevin Krammer
On Tuesday, 2013-12-31, 12:42:22, Martin Graesslin wrote: > On Tuesday 31 December 2013 12:15:09 David Faure wrote: > > > QSystemTrayIcon => KNotificationItem > > > > No clue. I can't even find KNotificationItem in KF5 anywhere !?!? > > In fact it doesn't exist in kdelibs4 either. > > > > I t

Re: Review Request 109609: disable session management for screensavers

2014-01-02 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/109609/#review46637 --- This review has been submitted with commit c014af7836a9fa7df8

Re: Review Request 109609: disable session management for screensavers

2014-01-02 Thread Wolfgang Bauer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/109609/ --- (Updated Jan. 2, 2014, 6:57 p.m.) Status -- This change has been mar

Re: Review Request 114717: Language detection in Sonnet

2014-01-02 Thread Martin Tobias Holmedahl Sandsmark
> On Jan. 2, 2014, 2:47 p.m., Vishesh Handa wrote: > > src/plugins/CMakeLists.txt, line 29 > > > > > > We don't care about Enchant any more? it's seems to be unmaintained, is just an abstraction library, and it s

Re: Review Request 114807: Don't dim display if backlight brightness is already 0

2014-01-02 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114807/#review46632 --- This review has been submitted with commit b3db8b1407d45d0c3b

Re: Review Request 114807: Don't dim display if backlight brightness is already 0

2014-01-02 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114807/#review46631 --- Please don't forget to submit it for the 4.12 branch as well

Re: Review Request 113518: KDM/KFrontend: Avoid potentially exploitable privilege dropping

2014-01-02 Thread Martin Bříza
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113518/ --- (Updated Jan. 2, 2014, 3:28 p.m.) Status -- This change has been dis

Re: Review Request 113518: KDM/KFrontend: Avoid potentially exploitable privilege dropping

2014-01-02 Thread Martin Bříza
> On Nov. 5, 2013, 6:54 p.m., Oswald Buddenhagen wrote: > > what exploit do you have in mind? Originally I submitted it for avoiding leaving supplemental groups assigned to the process but it's not necessary in this case... discarding - Martin ---

Re: Review Request 114717: Language detection in Sonnet

2014-01-02 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114717/#review46626 --- README.md

Re: Review Request 114807: Don't dim display if backlight brightness is already 0

2014-01-02 Thread Alexander Mezin
> On Jan. 2, 2014, 5:58 p.m., Àlex Fiestas wrote: > > Looks good, I have been suffering from this too ! Most probably this patch won't solve your problem. There is also a bug in Intel driver. It changes backlight brightness when queried with XRandr. It's fixed only in 2.99.905 and only for SNA

Re: Review Request 114807: Don't dim display if backlight brightness is already 0

2014-01-02 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114807/#review46617 --- This review has been submitted with commit 6326ee72a1fd895b68

Re: Review Request 114807: Don't dim display if backlight brightness is already 0

2014-01-02 Thread Alexander Mezin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114807/ --- (Updated Jan. 2, 2014, 12:14 p.m.) Status -- This change has been ma

Re: Review Request 114807: Don't dim display if backlight brightness is already 0

2014-01-02 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114807/#review46610 --- Ship it! Ship It! - Lukáš Tinkl On Jan. 2, 2014, 3:50 a.m.

Re: Review Request 114808: Fixes 305694 : Zoom Slider fails to show correct icon size on mouse over

2014-01-02 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114808/#review46609 --- Thanks for this patch, but this change brings in some unwanted

Re: Review Request 114808: Fixes 305694 : Zoom Slider fails to show correct icon size on mouse over

2014-01-02 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114808/#review46608 --- Thanks for this patch, but this change brings in some unwanted

Re: Review Request 114807: Don't dim display if backlight brightness is already 0

2014-01-02 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114807/#review46603 --- Ship it! Looks good, I have been suffering from this too ! -

Review Request 114807: Don't dim display if backlight brightness is already 0

2014-01-02 Thread Alexander Mezin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114807/ --- Review request for kde-workspace and Dario Freddi. Repository: kde-worksp