Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-25 Thread Albert Astals Cid
El Dimarts, 24 de desembre de 2013, a les 11:28:11, Vishesh Handa va escriure: > Hey guys > > I would like to move Baloo and Baloo-widgets into KDE SC soon. It would be > nice if someone could review the code. Both the projects are in kdereview. baloo-widgets does not load it's catalog message an

Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-25 Thread Albert Astals Cid
El Dimarts, 24 de desembre de 2013, a les 11:28:11, Vishesh Handa va escriure: > Hey guys > > I would like to move Baloo and Baloo-widgets into KDE SC soon. It would be > nice if someone could review the code. Both the projects are in kdereview. The pim agent Messages.sh catalog name is wrong as

Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-25 Thread David Edmundson
On Wed, Dec 25, 2013 at 10:15 PM, Thomas Lübking wrote: > On Mittwoch, 25. Dezember 2013 21:06:56 CEST, David Edmundson wrote: > >> With the planned slow transition of apps from kdelibs4 to frameworks >> we are going to have a point where we have apps on either side. >> I expect Dolphin to port ve

Klook/dolphin

2013-12-25 Thread Michael Reeves
Is anybody still working on Klook? If so I have an updated patch for dolphin integration. signature.asc Description: This is a digitally signed message part.

Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-25 Thread Thomas Lübking
On Mittwoch, 25. Dezember 2013 21:06:56 CEST, David Edmundson wrote: With the planned slow transition of apps from kdelibs4 to frameworks we are going to have a point where we have apps on either side. I expect Dolphin to port very soon, KMail isn't planned for a long time as KDE PIM libs are to

Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-25 Thread David Edmundson
Vishesh, Review of the folder "core" itemtype.h is useless. - it is not namespaced and it doesn't do anything. datastore.h - it's public, so should use a d-pointer. query.cpp - you don't delete d ? - there's a few things still TODO result.h does it make sense to use Baloo::Item::Id inste

Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-25 Thread David Edmundson
On Tue, Dec 24, 2013 at 11:32 PM, Thomas Lübking wrote: > On Dienstag, 24. Dezember 2013 22:03:28 CEST, Àlex Fiestas wrote: >> >> On Tuesday 24 December 2013 21:25:37 Ivan Čukić wrote: > > > The point is, that you virtually cannot make a release that breaks half the > former nepomuk clients. > You