Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-24 Thread Ivan Čukić
On Tuesday, 24. December 2013. 22.03.28 Àlex Fiestas wrote: > As I see it, the nepomuk maintainer says it works better than Nepomuk for > all cases covered by SC. I don't see any reason not to move forward then. The truthfulness of Vishesh's claim does not enter into it. If we believe it (and I d

Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-24 Thread Thomas Lübking
On Dienstag, 24. Dezember 2013 22:03:28 CEST, Àlex Fiestas wrote: On Tuesday 24 December 2013 21:25:37 Ivan Čukić wrote: I would like baloo to be available in 4.x, with no API stability guarantees, ... As I see it, the nepomuk maintainer says it works better than Nepomuk for all cases cove

Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-24 Thread Àlex Fiestas
On Tuesday 24 December 2013 19:57:17 Thomas Lübking wrote: > On Dienstag, 24. Dezember 2013 19:29:11 CEST, Vishesh Handa wrote: > > On Tuesday 24 Dec 2013 13:06:55 Christoph Feck wrote: > >> How does Baloo cooperate with Nepomuk? Note that we have ABI > >> guarantees, so if the metadata is not shar

Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-24 Thread Àlex Fiestas
On Tuesday 24 December 2013 21:25:37 Ivan Čukić wrote: > > As I understand it there are no plans to remove the nepomuk-core or > > nepomuk-widget libraries. If you switch to Baloo, anything compiled > > against > > nepomuk will still run but will act as if nepomuk is disabled. This is > > something

Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-24 Thread Ivan Čukić
> As I understand it there are no plans to remove the nepomuk-core or > nepomuk-widget libraries. If you switch to Baloo, anything compiled against > nepomuk will still run but will act as if nepomuk is disabled. This is > something clients previously had to cope with anyway. Meaning that everyth

Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-24 Thread David Edmundson
On 24 Dec 2013 18:57, "Thomas Lübking" wrote: > > On Dienstag, 24. Dezember 2013 19:29:11 CEST, Vishesh Handa wrote: >> >> On Tuesday 24 Dec 2013 13:06:55 Christoph Feck wrote: >>> >>> How does Baloo cooperate with Nepomuk? Note that we have ABI >>> guarantees, so if the metadata is not shared bet

Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-24 Thread Thomas Lübking
On Dienstag, 24. Dezember 2013 19:29:11 CEST, Vishesh Handa wrote: On Tuesday 24 Dec 2013 13:06:55 Christoph Feck wrote: How does Baloo cooperate with Nepomuk? Note that we have ABI guarantees, so if the metadata is not shared between running instances of two services, but applications would hav

Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-24 Thread Vishesh Handa
On Tuesday 24 Dec 2013 13:06:55 Christoph Feck wrote: > How does Baloo cooperate with Nepomuk? Note that we have ABI > guarantees, so if the metadata is not shared between running instances > of two services, but applications would have to be ported to the new > ABI, then you cannot introduce Baloo

KF5 Update Meeting Minutes 2013-w52

2013-12-24 Thread Kevin Ottens
Hello everyone, This is the minutes of the Week 52 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: alexmerry, apol and myself. Announcement: * I lined up that one to see who would show up, merry christmas! * alexmerry has been working on getting jenkins

Re: Review Request 114436: Set WindowModality of all KIO message box to Qt::WindowModal

2013-12-24 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114436/ --- (Updated Dec. 24, 2013, 3:01 p.m.) Status -- This change has been ma

Re: Review Request 114436: Set WindowModality of all KIO message box to Qt::WindowModal

2013-12-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114436/#review46137 --- This review has been submitted with commit 7ca1acc9f491bc7358

Re: Review Request 114479: Select the newly created bookmark folder as the current item

2013-12-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114479/#review46135 --- This review has been submitted with commit 2d83344174fe956dd6

Re: Review Request 114479: Select the newly created bookmark folder as the current item

2013-12-24 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114479/ --- (Updated Dec. 24, 2013, 2:50 p.m.) Status -- This change has been ma

Re: Review Request 114479: Select the newly created bookmark folder as the current item

2013-12-24 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114479/#review46134 --- Ship it! Ship It! - David Faure On Dec. 24, 2013, 2:26 p.m

Re: Review Request 114479: Select the newly created bookmark folder as the current item

2013-12-24 Thread Dawit Alemayehu
> On Dec. 24, 2013, 8:14 a.m., David Faure wrote: > > kio/bookmarks/kbookmarkdialog.cc, line 350 > > > > > > this method could now call the other one with an empty selectGroup, to > > remove the code duplication

Re: Review Request 114479: Select the newly created bookmark folder as the current item

2013-12-24 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114479/ --- (Updated Dec. 24, 2013, 2:26 p.m.) Review request for kdelibs and David F

Re: Review Request 114623: kjs: Implement es6 Math.fround

2013-12-24 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114623/#review46132 --- Ship it! what a silly function, but looks okay to me. - Mart

Re: Review Request 114455: kjs: Implement ES6 Math.imul

2013-12-24 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114455/#review46131 --- Ship it! Ship It! - Martin Tobias Holmedahl Sandsmark On D

Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-24 Thread Christoph Feck
On Tuesday 24 December 2013 11:28:11 Vishesh Handa wrote: > Hey guys > > I would like to move Baloo and Baloo-widgets into KDE SC soon. It > would be nice if someone could review the code. Both the projects > are in kdereview. > > Baloo is a metadata and search framework which is a successor to >

Moving Baloo and Baloo-widgets into KDE SC

2013-12-24 Thread Vishesh Handa
Hey guys I would like to move Baloo and Baloo-widgets into KDE SC soon. It would be nice if someone could review the code. Both the projects are in kdereview. Baloo is a metadata and search framework which is a successor to the Nepomuk project. It primarily provides - * An API for searching *

Re: Review Request 114479: Select the newly created bookmark folder as the current item

2013-12-24 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114479/#review46109 --- Much better, but... :) kio/bookmarks/kbookmarkdialog.h