Re: Review Request 114436: Set WindowModality of all KIO message box to Qt::WindowModal

2013-12-14 Thread Dawit Alemayehu
> On Dec. 13, 2013, 2:27 p.m., Frank Reininghaus wrote: > > Thanks for looking into this, Dawit! I greatly appreciate this effort. > > > > > > Two questions come to my mind: > > > > 1. Why should these dialogs be modal at all? Everything that KIO does is > > asynchronous, so it could very wel

Re: Review Request 114464: kjs: Implement ES6 Number isFinite, isInteger, isSafeInteger, isNaN and add MAX_SAFE_INTEGER, MIN_SAFE_INTEGER constants

2013-12-14 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114464/#review45706 --- Ship it! Ship It! - Martin Tobias Holmedahl Sandsmark On De

Re: Nepomuk in 4.13 and beyond

2013-12-14 Thread Ingo Klöcker
On Friday 13 December 2013 12:42:39 Marco Martin wrote: > On Thursday 12 December 2013, Vishesh Handa wrote: > > On Thursday 12 Dec 2013 19:40:11 Ivan Čukić wrote: > > > From my POV, it would be much nicer if you forced a single db (as > > > an > > > actual store, not as a cache like nepomuk is for

Review Request 114464: kjs: Implement ES6 Number isFinite, isInteger, isSafeInteger, isNaN and add MAX_SAFE_INTEGER, MIN_SAFE_INTEGER constants

2013-12-14 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114464/ --- Review request for kdelibs. Repository: kdelibs Description --- kjs

Re: Review Request 114437: Add right click contextmenu for Plasma Components TextField

2013-12-14 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114437/#review45699 --- Ship it! Looks good. - Sebastian Kügler On Dec. 13, 2013, 3

Re: Review Request 114454: kjs: Implement ES6 Math.hypot

2013-12-14 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114454/#review45696 --- Ship it! Ship It! - Martin Tobias Holmedahl Sandsmark On De

Re: Review Request 114454: kjs: Implement ES6 Math.hypot

2013-12-14 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114454/ --- (Updated Dec. 14, 2013, 6:53 p.m.) Review request for kdelibs. Changes -

Re: Review Request 114449: kjs: Implement ES6 acosh, asinh, cbrt, cosh, exmp1, log1p, log10, sign, sinh, tanh, trunc Math Functions

2013-12-14 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114449/#review45691 --- Ship it! Ship It! - Martin Tobias Holmedahl Sandsmark On De

Re: Review Request 114454: kjs: Implement ES6 Math.hypot

2013-12-14 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114454/#review45690 --- how about just a single loop, but store if we've found a nan? t

Re: Review Request 114448: kjs: reogranize basic math functions & function checking

2013-12-14 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114448/#review45689 --- Ship it! Ship It! - Martin Tobias Holmedahl Sandsmark On De

Review Request 114455: kjs: Implement ES6 Math.imul

2013-12-14 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114455/ --- Review request for kdelibs. Repository: kdelibs Description --- kjs

Review Request 114454: kjs: Implement ES6 Math.hypot

2013-12-14 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114454/ --- Review request for kdelibs. Repository: kdelibs Description --- kjs

Review Request 114449: kjs: Implement ES6 acosh, asinh, cbrt, cosh, exmp1, log1p, log10, sign, sinh, tanh, trunc Math Functions

2013-12-14 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114449/ --- Review request for kdelibs. Repository: kdelibs Description --- kjs

Review Request 114448: kjs: reogranize basic math functions & function checking

2013-12-14 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114448/ --- Review request for kdelibs. Repository: kdelibs Description --- kjs

Re: Review Request 111851: Split KCModules into different Categories in KHelpcenter's navigation tree

2013-12-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111851/#review45673 --- This review has been submitted with commit 34d57d6cb99c6840f9a

Re: Review Request 111851: Split KCModules into different Categories in KHelpcenter's navigation tree

2013-12-14 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111851/ --- (Updated Dec. 14, 2013, 11:33 a.m.) Status -- This change has been ma