Re: Review Request 114219: Do not encode QString to QByteArray and cast it back to QString. This causes problem when there are Unicode characters in ${HOME}

2013-11-29 Thread Yichao Yu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114219/ --- (Updated Nov. 29, 2013, 11:38 p.m.) Review request for kde-workspace, Davi

Re: Review Request 114219: Do not encode QString to QByteArray and cast it back to QString. This causes problem when there are Unicode characters in ${HOME}

2013-11-29 Thread Yichao Yu
> On Nov. 29, 2013, 7:45 p.m., Thomas Lübking wrote: > > kcontrol/krdb/krdb.cpp, line 102 > > > > > > QFile::encodeName() seems equal to QString::toLocal8Bit(), > > ::decodeName() to ::fromLocal8Bit() > > >

Re: Review Request 114219: Do not encode QString to QByteArray and cast it back to QString. This causes problem when there are Unicode characters in ${HOME}

2013-11-29 Thread Yichao Yu
> On Nov. 29, 2013, 7:45 p.m., Thomas Lübking wrote: > > kcontrol/krdb/krdb.cpp, line 102 > > > > > > QFile::encodeName() seems equal to QString::toLocal8Bit(), > > ::decodeName() to ::fromLocal8Bit() > > >

Re: Review Request 114219: Do not encode QString to QByteArray and cast it back to QString. This causes problem when there are Unicode characters in ${HOME}

2013-11-29 Thread Thomas Lübking
> On Nov. 30, 2013, 12:45 a.m., Thomas Lübking wrote: > > kcontrol/krdb/krdb.cpp, line 102 > > > > > > QFile::encodeName() seems equal to QString::toLocal8Bit(), > > ::decodeName() to ::fromLocal8Bit() > > >

Re: Review Request 114219: Do not encode QString to QByteArray and cast it back to QString. This causes problem when there are Unicode characters in ${HOME}

2013-11-29 Thread Yichao Yu
> On Nov. 29, 2013, 7:45 p.m., Thomas Lübking wrote: > > kcontrol/krdb/krdb.cpp, line 102 > > > > > > QFile::encodeName() seems equal to QString::toLocal8Bit(), > > ::decodeName() to ::fromLocal8Bit() > > >

Re: Review Request 114219: Do not encode QString to QByteArray and cast it back to QString. This causes problem when there are Unicode characters in ${HOME}

2013-11-29 Thread Yichao Yu
> On Nov. 29, 2013, 7:45 p.m., Thomas Lübking wrote: > > kcontrol/krdb/krdb.cpp, line 102 > > > > > > QFile::encodeName() seems equal to QString::toLocal8Bit(), > > ::decodeName() to ::fromLocal8Bit() > > >

Re: Review Request 114219: Do not encode QString to QByteArray and cast it back to QString. This causes problem when there are Unicode characters in ${HOME}

2013-11-29 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114219/#review44857 --- kcontrol/krdb/krdb.cpp

Review Request 114219: Do not encode QString to QByteArray and cast it back to QString. This causes problem when there are Unicode characters in ${HOME}

2013-11-29 Thread Yichao Yu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114219/ --- Review request for kde-workspace, David Faure, Martin Gräßlin, and Hugo Pere

Best practice for libraries supporting both Qt4 and Qt5

2013-11-29 Thread Michael Palimaka
Hi, Is there an established best practice for libraries to support both Qt4 and Qt5? Currently, some libraries such as phonon rename their Qt5 versions, permitting full parallel installation and usage (even of development and CMake config files). Other libraries such as attica bump the maj

Re: Review Request 114214: remove QDesktopWidget global static

2013-11-29 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114214/ --- (Updated Nov. 29, 2013, 9 p.m.) Review request for kdelibs and kdewin. R

Review Request 114214: remove QDesktopWidget global static

2013-11-29 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114214/ --- Review request for kdelibs and kdewin. Repository: kdelibs Description -

Re: Review Request 111851: Split KCModules into different Categories in KHelpcenter's navigation tree

2013-11-29 Thread Ben Cooksley
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111851/#review44837 --- Patch looks fine to me, sucks a bit that the names have to be h

Re: projects page dead ?

2013-11-29 Thread Ben Cooksley
On Sat, Nov 30, 2013 at 1:25 AM, Hugo Pereira Da Costa wrote: > https://projects.kde.org/projects/ > gives 'bad gateway'. Is it just me ? A known (hopefully temporary) issue ? > Has the page moved ? > This was a temporary fault, which has now been resolved. Thanks for reporting. > > Thanks in

Re: Review Request 112880: Added KColorSchemeToken class.

2013-11-29 Thread Denis Kuplyakov
> On Oct. 21, 2013, 11:22 a.m., Kevin Ottens wrote: > > To get in this patch would benefit from being based on the frameworks > > branch and go into kdeclarative. > > Kevin Ottens wrote: > Any chance for an update? > > Denis Kuplyakov wrote: > Yes I will finish it, when have time. Ther

Re: Review Request 111342: make kinfocenter compile on non x11 systems and Windows

2013-11-29 Thread Patrick von Reth
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111342/ --- (Updated Nov. 29, 2013, 2:54 p.m.) Status -- This change has been mar

Re: Review Request 111342: make kinfocenter compile on non x11 systems and Windows

2013-11-29 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111342/#review44806 --- This review has been submitted with commit 40ded3efd3fa093247d

Re: Review Request 111851: Split KCModules into different Categories in KHelpcenter's navigation tree

2013-11-29 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111851/ --- (Updated Nov. 29, 2013, 12:37 p.m.) Review request for Documentation, KDE

Review Request 114201: define property X-KDE-PluginKeyword in kdelibs/kio/kcmodule.desktop

2013-11-29 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114201/ --- Review request for kdelibs and David Faure. Repository: kdelibs Descript

Re: projects page dead ?

2013-11-29 Thread Gilles Caulier
same here... Gilles Caulier 2013/11/29 Hugo Pereira Da Costa : > https://projects.kde.org/projects/ > gives 'bad gateway'. Is it just me ? A known (hopefully temporary) issue ? > Has the page moved ? > > Thanks in advance, > > Hugo

projects page dead ?

2013-11-29 Thread Hugo Pereira Da Costa
https://projects.kde.org/projects/ gives 'bad gateway'. Is it just me ? A known (hopefully temporary) issue ? Has the page moved ? Thanks in advance, Hugo