Re: Review Request 113985: Remove no-ops in KCategorizedView

2013-11-26 Thread Yichao Yu
> On Nov. 25, 2013, 1:35 p.m., David Faure wrote: > > Ship It! Thanks for the review. However, I don't have a git account yet and I cannot find others to push it for me this time. Could you please push it for me? - Yichao --- This is a

Re: Review Request 114017: Fix crash with horizontal wheel on tabs

2013-11-26 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114017/ --- (Updated Nov. 26, 2013, 11:43 p.m.) Status -- This change has been di

Re: ksysguard failing tests

2013-11-26 Thread Albert Astals Cid
El Dilluns, 25 de novembre de 2013, a les 10:05:50, Vadim Zhukov va escriure: > 25.11.2013 3:18 пользователь "Albert Astals Cid" написал: > > Hi, there are two ksysguard failing tests in jenkins > > http://build.kde.org/view/KDE%20SC%20stable/job/kde-workspace_stable/lastCom > pletedBuild/testRep

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

2013-11-26 Thread Mark Gaiser
> On Nov. 26, 2013, 5:12 p.m., Kevin Ottens wrote: > > It's been stalled for almost three months now, any chance to see progress > > or should it be discarded? No, it should most certainly not be disgarded. It was even working when i posted this post up for review. Dawit, how are you doing in

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

2013-11-26 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/#review44515 --- It's been stalled for almost three months now, any chance to se

Re: Review Request 113866: kio bookmarks: Only iterate over element nodes in findToolbar()

2013-11-26 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113866/#review44510 --- Ship it! Looks good, just one improvement below: kio/bookmar

Re: Review Request 113858: Add .reviewboardrc

2013-11-26 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113858/#review44508 --- Yes, but please add BRANCH = 'master' (we already have this in

Re: Review Request 114011: Add ctrl-shift-s as default shortcut for save-as

2013-11-26 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114011/#review44507 --- Ship it! I like it. - David Faure On Nov. 22, 2013, 10:13 a

KF5 Update Meeting Minutes 2013-w48

2013-11-26 Thread Kevin Ottens
Hello everyone, This is the minutes of the Week 48 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: afiestas, agateau, apol, dfaure, markg85, mgraesslin, miroslav, randomguy3, Riddell, sebas, svuorela, teo and myself. Announcement: * We're close to be ready

Re: KMountPoint::probablySlow and cifs mount points

2013-11-26 Thread Aurélien Gâteau
Le lundi 25 novembre 2013 20:38:58 Ingo Klöcker a écrit : > On Monday 25 November 2013 18:46:27 Aurélien Gâteau wrote: > > Le lundi 25 novembre 2013 18:23:53 Mark Gaiser a écrit : > > > On Mon, Nov 25, 2013 at 5:41 PM, Aurélien Gâteau > > wrote: > > > >> 2. If you follow this route, you are alrea

Re: Review Request 114017: Fix crash with horizontal wheel on tabs

2013-11-26 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114017/#review44503 --- looks like the tabwidget sends an event to one of its own child

Re: Review Request 114017: Fix crash with horizontal wheel on tabs

2013-11-26 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114017/ --- (Updated Nov. 26, 2013, 11:29 a.m.) Review request for kdelibs. Summary

Re: Review Request 114017: Possibly fix crash with horizontal wheel on tabs

2013-11-26 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114017/ --- (Updated Nov. 26, 2013, 11:22 a.m.) Review request for kdelibs. Changes

Re: ksysguard failing tests

2013-11-26 Thread Vadim Zhukov
25.11.2013 3:18 пользователь "Albert Astals Cid" написал: > > Hi, there are two ksysguard failing tests in jenkins > > http://build.kde.org/view/KDE%20SC%20stable/job/kde-workspace_stable/lastCompletedBuild/testReport/ > > There is one because of an API misuse expecting that a float will give you

Re: KMountPoint::probablySlow and cifs mount points

2013-11-26 Thread henry miller
"Aurélien Gâteau" wrote: >Le dimanche 24 novembre 2013 19:42:25 Mark Gaiser a écrit : >> On Sun, Nov 24, 2013 at 5:05 PM, Albert Astals Cid >wrote: >> > In Okular we just got bug >> > https://bugs.kde.org/show_bug.cgi?id=327846 >> > PDF Render time is unreasonably slow over cifs on high latency