Re: Review Request 111851: Split KCModules into different Categories in KHelpcenter's navigation tree

2013-11-20 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111851/#review44080 --- kcmshell/main.cpp

Review Request 113987: tier3/kpty: Improve dependency specifications

2013-11-20 Thread Johannes Huber
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113987/ --- Review request for kdelibs. Repository: kdelibs Description --- Imp

Re: Review Request 113969: Do not assume every items have the same height

2013-11-20 Thread Yichao Yu
> On Nov. 20, 2013, 5:27 p.m., Christoph Feck wrote: > > I love people who report bugs, and one year later come up with a patch :P > > > > Anyway, nice analysis, and this probably also fixes bug 290971, but have > > not tested it yet. Unfortunately I think I can still reproduce those problems.

Re: Review Request 113969: Do not assume every items have the same height

2013-11-20 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113969/#review44071 --- I love people who report bugs, and one year later come up with

Re: Review Request 113969: Do not assume every items have the same height

2013-11-20 Thread Yichao Yu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113969/ --- (Updated Nov. 20, 2013, 4:47 p.m.) Review request for kdelibs, David Faure

Re: Review Request 113969: Do not assume every items have the same height

2013-11-20 Thread Yichao Yu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113969/ --- (Updated Nov. 20, 2013, 4:46 p.m.) Review request for kdelibs, David Faure

Review Request 113985: Remove no-ops in KCategorizedView

2013-11-20 Thread Yichao Yu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113985/ --- Review request for kdelibs, David Faure, Rafael Fernández López, and Michael

Re: Review Request 113965: Possible fix for bug 321100

2013-11-20 Thread Thomas Lübking
> On Nov. 20, 2013, 6:02 p.m., Albert Astals Cid wrote: > > I don't see why this should fix anything. Do you think anyone in the bug > > can provide a valgrind trace to better understand why it's crashing? > > Christoph Feck wrote: > See also https://git.reviewboard.kde.org/r/102981/ which

Re: Review Request 113965: Possible fix for bug 321100

2013-11-20 Thread Albert Astals Cid
> On Nov. 20, 2013, 6:02 p.m., Albert Astals Cid wrote: > > I don't see why this should fix anything. Do you think anyone in the bug > > can provide a valgrind trace to better understand why it's crashing? > > Christoph Feck wrote: > See also https://git.reviewboard.kde.org/r/102981/ which

Re: Review Request 113965: Possible fix for bug 321100

2013-11-20 Thread Thomas Lübking
> On Nov. 20, 2013, 6:02 p.m., Albert Astals Cid wrote: > > I don't see why this should fix anything. Do you think anyone in the bug > > can provide a valgrind trace to better understand why it's crashing? > > Christoph Feck wrote: > See also https://git.reviewboard.kde.org/r/102981/ which

Re: Review Request 113965: Possible fix for bug 321100

2013-11-20 Thread Christoph Feck
> On Nov. 20, 2013, 6:02 p.m., Albert Astals Cid wrote: > > I don't see why this should fix anything. Do you think anyone in the bug > > can provide a valgrind trace to better understand why it's crashing? > > Christoph Feck wrote: > See also https://git.reviewboard.kde.org/r/102981/ which

Re: Review Request 113965: Possible fix for bug 321100

2013-11-20 Thread Albert Astals Cid
> On Nov. 20, 2013, 6:02 p.m., Albert Astals Cid wrote: > > I don't see why this should fix anything. Do you think anyone in the bug > > can provide a valgrind trace to better understand why it's crashing? > > Christoph Feck wrote: > See also https://git.reviewboard.kde.org/r/102981/ which

Re: Review Request 113965: Possible fix for bug 321100

2013-11-20 Thread Christoph Feck
> On Nov. 20, 2013, 6:02 p.m., Albert Astals Cid wrote: > > I don't see why this should fix anything. Do you think anyone in the bug > > can provide a valgrind trace to better understand why it's crashing? See also https://git.reviewboard.kde.org/r/102981/ which has some discussion and links t

Re: Review Request 113965: Possible fix for bug 321100

2013-11-20 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113965/#review44060 --- I don't see why this should fix anything. Do you think anyone i

Review Request 113969: Do not assume every items have the same height

2013-11-20 Thread Yichao Yu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113969/ --- Review request for kdelibs, David Faure, Rafael Fernández López, and Michael

Re: Review Request 113969: Do not assume every items have the same height

2013-11-20 Thread Yichao Yu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113969/ --- (Updated Nov. 20, 2013, 12:24 p.m.) Review request for kdelibs, David Faur

Re: Review Request 113885: 3 types of blur

2013-11-20 Thread Marco Martin
> On Nov. 20, 2013, 12:21 p.m., Fredrik Höglund wrote: > > tier1/kwindowsystem/src/kwindoweffects.h, line 143 > > > > > > An unfortunate side effect of this is that this API becomes > > incompatible with the equi

Re: Review Request 113885: 3 types of blur

2013-11-20 Thread Fredrik Höglund
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113885/#review44042 --- tier1/kwindowsystem/src/kwindoweffects.h

Review Request 113965: Possible fix for bug 321100

2013-11-20 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113965/ --- Review request for kdelibs. Bugs: 321100 http://bugs.kde.org/show_bug.