Re: Review Request 113915: kio_smb, Increase MAX_XFER_BUF_SIZE

2013-11-18 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113915/#review43921 --- No. It is not acceptable to set the maximum xfer buffer size to

Review Request 113931: Fix process list to start already sorted

2013-11-18 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113931/ --- Review request for kde-workspace and John Tapsell. Bugs: 282636 http:/

Re: Review Request 113591: Reduce UDSEntry memory usage by sharing the contained QStrings if possible

2013-11-18 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113591/ --- (Updated Nov. 18, 2013, 10:37 p.m.) Status -- This change has been ma

Re: Review Request 113591: Reduce UDSEntry memory usage by sharing the contained QStrings if possible

2013-11-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113591/#review43914 --- This review has been submitted with commit 6d8fac9e342cfbcafb2

Re: FindKDE4Internal.cmake & clang & c++11 & -fdelayed-template-parsing

2013-11-18 Thread Raphael Kubo da Costa
Milian Wolff writes: >> > Also, have you reported the errors that clang outputs to the developers? >> > If >> > it's correct analysis, it should be fixed - even if it's error-prone >> > work. >> >> In this case, I don't think there's a bug: I haven't investigated in >> depth, but clang seems to b

Re: Review Request 113885: 3 types of blur

2013-11-18 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113885/#review43889 --- tier1/kwindowsystem/src/kwindoweffects.h

class SimpleJob requires a valid object of class QCoreApplication

2013-11-18 Thread Krzysztof Żelechowski
If no valid application object is present, the constructor of SimpleJob causes a NULL pointer dereference. Please add the following comment to the description of class SimpleJob: An object of this class (or of a derived class) may only be created when the application object (derived from QCoreA

Re: FindKDE4Internal.cmake & clang & c++11 & -fdelayed-template-parsing

2013-11-18 Thread Milian Wolff
On Monday 18 November 2013 01:45:26 Raphael Kubo da Costa wrote: > Milian Wolff writes: > > There is no alternative, see above. Rather have bigger binaries than not > > being able to compile at all. > > Finally fixed: http://commits.kde.org/kdelibs/daa54a25 Thank you! > > Also, have you reporte