Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-11-15 Thread Christoph Feck
> On Nov. 12, 2013, 10:39 a.m., Commit Hook wrote: > > This review has been submitted with commit > > 53e8e439af2483c86b21ad4d53ffe4da622e8c44 by Martin Klapetek to branch > > frameworks. > > Christoph Feck wrote: > Locally, I get this error: > > AUTOMOC: error: process for > /lo

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-11-15 Thread Martin Klapetek
> On Nov. 12, 2013, 10:39 a.m., Commit Hook wrote: > > This review has been submitted with commit > > 53e8e439af2483c86b21ad4d53ffe4da622e8c44 by Martin Klapetek to branch > > frameworks. > > Christoph Feck wrote: > Locally, I get this error: > > AUTOMOC: error: process for > /lo

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-11-15 Thread Martin Klapetek
> On Nov. 15, 2013, 10:09 p.m., Commit Hook wrote: > > This review has been submitted with commit > > 7ec8cf76bad0f16a2947eb6d5986af436a3bdc69 by Martin Klapetek to branch > > frameworks. Erm, sorry, wrong review number in the commit. - Martin --

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-11-15 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113260/#review43784 --- This review has been submitted with commit 7ec8cf76bad0f16a294

Re: FindKDE4Internal.cmake & clang & c++11 & -fdelayed-template-parsing

2013-11-15 Thread Alexander Neundorf
On Friday 15 November 2013, Milian Wolff wrote: > On Tuesday 22 October 2013 10:17:02 Raphael Kubo da Costa wrote: > > Milian Wolff writes: > > > Hey Raphael! > > > > > > Thank you for working on clang support in FindKDE4Internal.cmake. > > > > > > Since recently though I have build issues with

Re: Review Request 113503: make dbus dependency optional in JobWidgets

2013-11-15 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113503/#review43742 --- Any chance to see Stephen's comments addressed or this patch is

Re: FindKDE4Internal.cmake & clang & c++11 & -fdelayed-template-parsing

2013-11-15 Thread Milian Wolff
On Tuesday 22 October 2013 10:17:02 Raphael Kubo da Costa wrote: > Milian Wolff writes: > > Hey Raphael! > > > > Thank you for working on clang support in FindKDE4Internal.cmake. > > > > Since recently though I have build issues with clang due to the -fdelayed- > > template-parsing flag passed i

Review Request 113885: 3 types of blur

2013-11-15 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113885/ --- Review request for kdelibs and kwin. Repository: kdelibs Description ---

Re: Review Request 113866: kio bookmarks: Only iterate over element nodes in findToolbar()

2013-11-15 Thread Stefan Brüns
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113866/ --- (Updated Nov. 15, 2013, 2:06 p.m.) Review request for kdelibs and Frank Re

Re: QDialog on stack+exec and dbus quit crash is no more

2013-11-15 Thread Jan Kundrát
On Thursday, 14 November 2013 22:02:09 CEST, Michael Reeves wrote: That link is broken. Try this one -- it's from valgrind, not the gdb, but it points to the actual problem: http://kde.6490.n7.nabble.com/QDialog-on-stack-exec-and-dbus-quit-crash-is-no-more-tp1549181p1549244.html Cheers, Jan

Re: Review Request 112982: copy[To|From]File support for kio_smb

2013-11-15 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112982/ --- (Updated Nov. 15, 2013, 11:59 a.m.) Review request for KDE Runtime and Dav

Re: QDialog on stack+exec and dbus quit crash is no more

2013-11-15 Thread Michael Reeves
On Monday, November 11, 2013 9:22:57 PM Albert Astals Cid wrote: > El Dilluns, 11 de novembre de 2013, a les 19:36:45, Kevin Krammer va escriure: > Of course one can say that the crash in [1] is a bug that someone will fix, > any taker? > > Cheers, > Albert > > [1] http://pastebin.kde.org/pol

Re: kde-workspace git broken ?

2013-11-15 Thread Wolfgang Bauer
Am Mittwoch, 13. November 2013, 18:42:33 schrieb Ben Cooksley: > On Tue, Nov 12, 2013 at 2:21 AM, Wolfgang Bauer wrote: > > > > Sorry, it was my fault. > > And there's also commit 925af7a94eacbe7fef101c6e0f6415b1898d3bfe now. > > Hi Wolfgang, > > The sha you have just referenced is a blob, no

Re: Review Request 113413: Improved Keyboard Layout Preview

2013-11-15 Thread shivam makkar
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113413/ --- (Updated Nov. 15, 2013, 9:37 a.m.) Review request for KDE Runtime, kde-wor