Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-11-13 Thread Christoph Feck
> On Nov. 12, 2013, 10:39 a.m., Commit Hook wrote: > > This review has been submitted with commit > > 53e8e439af2483c86b21ad4d53ffe4da622e8c44 by Martin Klapetek to branch > > frameworks. Locally, I get this error: AUTOMOC: error: process for /local/build/kf5/runtime/ktimezoned/ktimezoned.moc

Re: Moving KScreen and libkscreen to extragear

2013-11-13 Thread Àlex Fiestas
On Wednesday 13 November 2013 22:56:37 Christoph Feck wrote: > On Wednesday 13 November 2013 21:16:01 Ben Cooksley wrote: > > Based on Alex's request, I have now moved libkscreen and kscreen to > > their relevant locations in Extragear. > > Multiple screen support was one of the "weak spots" left

Re: Moving KScreen and libkscreen to extragear

2013-11-13 Thread Luigi Toscano
Ben Cooksley wrote: > Hi all, > > Based on Alex's request, I have now moved libkscreen and kscreen to their > relevant locations in Extragear. > If there are any objections, please let me know. Translations moved as well: http://websvn.kde.org/?view=revision&revision=1369681 Ciao -- Luigi

Re: Moving KScreen and libkscreen to extragear

2013-11-13 Thread Christoph Feck
On Wednesday 13 November 2013 21:16:01 Ben Cooksley wrote: > Based on Alex's request, I have now moved libkscreen and kscreen to > their relevant locations in Extragear. Multiple screen support was one of the "weak spots" left in KDE 4. Nice to see it's finally fixed. Thanks to everyone involved!

Re: Review Request 113846: fix kicontheme::list

2013-11-13 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113846/#review43637 --- tier3/kiconthemes/src/kicontheme.cpp

Re: Moving KScreen and libkscreen to extragear

2013-11-13 Thread Ben Cooksley
Hi all, Based on Alex's request, I have now moved libkscreen and kscreen to their relevant locations in Extragear. If there are any objections, please let me know. Thanks, Ben Cooksley KDE Sysadmin

Re: Review Request 113846: fix kicontheme::list

2013-11-13 Thread Albert Astals Cid
> On Nov. 13, 2013, 7:11 p.m., Aleix Pol Gonzalez wrote: > > Ship it, as long as tests still pass. :) And maybe even add a test that fails without this patch so it doesn't break again? - Albert --- This is an automatically generated e-

Re: Review Request 113846: fix kicontheme::list

2013-11-13 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113846/#review43623 --- Ship it! Ship it, as long as tests still pass. :) - Aleix Pol

Review Request 113846: fix kicontheme::list

2013-11-13 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113846/ --- Review request for kdelibs and David Faure. Repository: kdelibs Descript

Re: Moving KScreen and libkscreen to extragear

2013-11-13 Thread Àlex Fiestas
Ok so, after all this time (sorry for that) it is about time to move kscreen to extragear. We also need to handle the translations, since as soon as we are in extragear we plan to have 1.0 branch and 1.1. Thanks to everybody !

Re: Review Request 113841: kcm locale: use kcmshell5

2013-11-13 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113841/#review43595 --- Ship it! Ship It! - Sebastian Kügler On Nov. 13, 2013, 2:42

Review Request 113841: kcm locale: use kcmshell5

2013-11-13 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113841/ --- Review request for KDE Runtime and Sebastian Kügler. Repository: kde-runti

Review Request 113839: kcmshell: change internal references to kcmshell5

2013-11-13 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113839/ --- Review request for KDE Runtime and Marco Martin. Repository: kde-runtime

Re: Review Request 113833: fix include file in kio

2013-11-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113833/#review43578 --- This review has been submitted with commit e2f70932b4b1e08f286

Re: Review Request 113833: fix include file in kio

2013-11-13 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113833/ --- (Updated Nov. 13, 2013, 12:08 p.m.) Status -- This change has been ma

Re: Review Request 113833: fix include file in kio

2013-11-13 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113833/#review43574 --- Makes sense. For reference: kde-devel@thinktatil:~/frameworks/

Review Request 113833: fix include file in kio

2013-11-13 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113833/ --- Review request for kdelibs and Aleix Pol Gonzalez. Repository: kdelibs D

Re: Review Request 113819: don't install dbus interface file

2013-11-13 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113819/ --- (Updated Nov. 13, 2013, 9:51 a.m.) Status -- This change has been mar

Re: Review Request 113819: don't install dbus interface file

2013-11-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113819/#review43566 --- This review has been submitted with commit d490e35d20a8788fcf1

Re: Review Request 113819: don't install dbus interface file

2013-11-13 Thread Jonathan Riddell
> On Nov. 12, 2013, 11:26 p.m., Martin Klapetek wrote: > > Actually the file is not equivalent, the signal names were changed and one > > signal was removed completely. all the more reason not to ship it :) - Jonathan --- This is an au